Re: [PATCH 1/2] gpiolib: of: Only apply the SPI CS quirk to SPI peripherals

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Functional regression breaking SPI chip select polarity for minimal SPI peripherals, breaking git bisect.
--

--- Patch [1]: [PATCH 1/2] gpiolib: of: Only apply the SPI CS quirk to SPI peripherals ---
commit 119ec452c0cd58efb0a9c22023e3cbf0565c7c18
Author: Maciej Andrzejewski ICEYE <maciej.andrzejewski@m-works.net>

gpiolib: of: Only apply the SPI CS quirk to SPI peripherals

This commit restricts the legacy SPI chip-select polarity quirk to nodes
that actually represent SPI peripherals, identifying them by checking for
properties with an "spi-" prefix. It aims to prevent the quirk from
improperly applying to other subsystems like NAND controllers that also use
the "cs-gpios" property.

>     This is a convention rather than a guarantee: compatible and reg are the
>     only properties spi-controller.yaml makes mandatory for a peripheral, so
>     a minimal one may carry no "spi-" property at all. The next patch covers
>     those by looking at the controller instead.

[Severity: High]
Does deferring the fix for minimal SPI peripherals to the next patch
introduce a functional regression at this specific commit?

Since every individual commit must be self-contained and fully functional to
preserve git bisect, should the logic covering the controller be combined
into this patch to avoid breaking boards with minimal SPI peripherals during
a bisection?

> diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c
> index 940b566946ce3..bd9a623f2ae16 100644
> --- a/drivers/gpio/gpiolib-of.c
> +++ b/drivers/gpio/gpiolib-of.c
[ ... ]
> @@ -374,6 +393,11 @@ static void of_gpio_flags_quirks(const struct device_node *np,
>  			if (ret)
>  				continue;
>  			if (cs == index) {
> +				bool active_high;
> +
> +				if (!of_gpio_child_is_spi_peripheral(child))
> +					break;

[Severity: High]
Will this break SPI chip select polarity for minimal SPI peripherals that
lack "spi-" prefixed properties?

If of_gpio_child_is_spi_peripheral() returns false for a node that only has
"compatible" and "reg", the early break skips the of_gpio_quirk_polarity()
fixup. Their chip selects would default to active-high, potentially leaving
the device permanently deselected and unusable.

> +
>  				/*
>  				 * SPI children have active low chip selects
>  				 * by default. This can be specified negatively

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260810141629.81650-1-maciej.andrzejewski@m-works.net?part=1