Re: [PATCH v9 14/26] cachefiles,netfs: sunset ondemand mode

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The function declaration `cachefiles_flush_reqs` was left in `fs/cachefiles/internal.h` despite its definition being completely removed.
--

--- Patch [14]: [PATCH v9 14/26] cachefiles,netfs: sunset ondemand mode ---
commit 3258008555b130612d694792049c301874f06845
Author: Gao Xiang <xiang@kernel.org>
cachefiles,netfs: sunset ondemand mode

This commit removes the on-demand read mode from cachefiles and netfslib. Since
EROFS no longer acts as a network filesystem and doesn't use this mode, the
associated code and documentation are cleaned up.

Link: https://lore.kernel.org/r/CAOQ4uxi4dzxArY24YO=+kBCK2gGoq3Ptb8WkzCqSogPgU_R3dQ@mail.gmail.com

> diff --git a/fs/cachefiles/internal.h b/fs/cachefiles/internal.h
> index b62cd3e9a18e4..409492744bde6 100644
> --- a/fs/cachefiles/internal.h
> +++ b/fs/cachefiles/internal.h

[ ... ]

> @@ -191,8 +146,6 @@ extern int cachefiles_has_space(struct cachefiles_cache *cache,
>   */
>  extern const struct file_operations cachefiles_daemon_fops;
>  extern void cachefiles_flush_reqs(struct cachefiles_cache *cache);

[Severity: Low]
This isn't a bug, but it looks like the prototype for cachefiles_flush_reqs() 
was left behind in the header even though its implementation was removed from 
fs/cachefiles/daemon.c. Should this declaration be removed as well?

> -extern void cachefiles_get_unbind_pincount(struct cachefiles_cache *cache);
> -extern void cachefiles_put_unbind_pincount(struct cachefiles_cache *cache);
>  
>  /*
>   * error_inject.c

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260810144746.574036-1-dhowells@redhat.com?part=14