From: Christoph Hellwig <hch@lst.de>
To: Andrey Albershteyn <aalbersh@kernel.org>
Cc: linux-xfs@vger.kernel.org, djwong@kernel.org, hch@lst.de, cem@kernel.org
Subject: Re: [PATCH] xfs: fix IOMAP_F_DIRTY flag overwrite in zoned DIO
Date: Mon, 10 Aug 2026 17:23:15 +0200 [thread overview]
Message-ID: <20260810152315.GA19201@lst.de> (raw)
In-Reply-To: <20260810152132.495705-1-aalbersh@kernel.org>
On Mon, Aug 10, 2026 at 05:21:31PM +0200, Andrey Albershteyn wrote:
> Missing IOMAP_F_DIRTY prevents completion handlers from updating i_size
> on the direct IO path, the flag is set but was overwritten by
> IOMAP_F_ANON_WRITE latter. The writeback path for buffered IO doesn't
> seem to require IOMAP_F_DIRTY and looks like an error.
>
> Fixes: 2e2383405824 ("xfs: implement direct writes to zoned RT devices")
> Signed-off-by: Andrey Albershteyn <aalbersh@kernel.org>
I actually have exactly the same fix in a series I'm about to send
out, and a cleanup to move this into common code.
I guess we both saw the same Sashiko comment :)
prev parent reply other threads:[~2026-08-10 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 15:21 [PATCH] xfs: fix IOMAP_F_DIRTY flag overwrite in zoned DIO Andrey Albershteyn
2026-08-10 15:23 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810152315.GA19201@lst.de \
--to=hch@lst.de \
--cc=aalbersh@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.