From: Petr Vorel <pvorel@suse.cz>
To: Andrea Cervesato <andrea.cervesato@suse.de>
Cc: Linux Test Project <ltp@lists.linux.it>
Subject: Re: [LTP] [PATCH 1/2] sctp: add lapi fallback definitions
Date: Mon, 10 Aug 2026 19:39:20 +0200 [thread overview]
Message-ID: <20260810173920.GE1049677@pevik> (raw)
In-Reply-To: <20260810-sctphantom-v1-1-f8e9ee72a648@suse.com>
Hi: Andrea,
> +/* SCTP wire format values, see include/linux/sctp.h in the kernel */
+1 for that comment.
> +#ifndef SCTP_CID_INIT
> +# define SCTP_CID_INIT 1
> +#endif
> +
> +#ifndef SCTP_CID_INIT_ACK
> +# define SCTP_CID_INIT_ACK 2
> +#endif
> +
> +#ifndef SCTP_CID_ASCONF_ACK
> +# define SCTP_CID_ASCONF_ACK 0x80
> +#endif
> +
> +#ifndef SCTP_CID_ASCONF
> +# define SCTP_CID_ASCONF 0xc1
> +#endif
> +
> +#ifndef SCTP_PARAM_IPV4_ADDRESS
> +# define SCTP_PARAM_IPV4_ADDRESS 5
> +#endif
> +
> +#ifndef SCTP_PARAM_DEL_IP
> +# define SCTP_PARAM_DEL_IP 0xc002
> +#endif
> +
> +#ifndef SCTP_PARAM_ERR_CAUSE
> +# define SCTP_PARAM_ERR_CAUSE 0xc003
I hope cpu_to_be16(0xc003) is really on all supported archs 0xc003 :).
Anyway, the rest LGTM.
Reviewed-by: Petr Vorel <pvorel@suse.cz>
Kind regards,
Petr
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-08-10 17:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-10 16:28 [LTP] [PATCH 0/2] Add reproducer for sctphantom CVE Andrea Cervesato
2026-08-10 16:28 ` [LTP] [PATCH 1/2] sctp: add lapi fallback definitions Andrea Cervesato
2026-08-10 16:57 ` [LTP] " linuxtestproject.agent
2026-08-10 17:39 ` Petr Vorel [this message]
2026-08-10 16:28 ` [LTP] [PATCH 2/2] cve/sctphantom: Add reproducer for CVE-2026-64564 Andrea Cervesato
2026-08-10 18:06 ` Petr Vorel
2026-08-10 18:14 ` Andrea Cervesato via ltp
2026-08-11 5:35 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810173920.GE1049677@pevik \
--to=pvorel@suse.cz \
--cc=andrea.cervesato@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.