From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A92A342DA2A for ; Mon, 10 Aug 2026 18:30:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786386631; cv=none; b=c4rOapvsXJ/EhFvLBxE4R3XC/qP3wjkpgeI1ZG5eLkd+sd+L5p9q6Gt83VvbB9CKg1aa78VpI8fbznztvYtB/9JjjNj4NBVC9WVvO/82wFsqLSaPgwS403zfPplDe1BcXjc/KooX+3u8uYIAeNS0ggleACeo12nwi3OpA5BNG7s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786386631; c=relaxed/simple; bh=e4k9uDCZJqMsaHoGUfEXMC98BegQ+PL0kOH6ev2mS24=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=Oe5UcPgINFEHhxHrA+aLXD11VlN9Sy3Eh6/jAazzsvirA4t8G3I0d5yyCdTlhTmQb8Ss8dyEpZZZisLtI+8YIyhnFU22HgRR24F4FN5ELq/nYwIPedJm2K4Xcxw9u8g6T/dLyam4Q/nL+mZwVpip/JFnpUE9vqQckJug4wgOIZc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Z8bbUzyp; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Z8bbUzyp" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-cbb7926836eso1528147a12.3 for ; Mon, 10 Aug 2026 11:30:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786386629; x=1786991429; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=jHGYfRwrvjsJp3TM66oHmnwWqtIxW+4ymQvyIWeruC0=; b=Z8bbUzyp4Y5LD4IwgFZYrJgJC/NTv+5P46v8pTIgQFk0O0HsyKxXGa0hSs8ZpNCc5p 0/tqCVkZhAcXCfXFzeRChhVCdkWot+4G4WFYQ65Oey/j0e6x+RhUFRvIa1xReK8CXyJu nv+kmb1T2/dkO6Ifd0YbOYLvLUqm53I56/jq6fp93LTsTfYs+TSU8SgJ6sFRA/PubRkH dmkS4mCx4kqhzqgzuKGbWhefPpuI3mOcThky3tmpKfe2k1PdamMjF5z8OtjyYQb/flE5 4CAlelJ3mhNqxoeTWnoO5kQ2fzLDq/yxnl9yw5tQP7KgxkDjxNsskjLfgSFZ1DXZ7K/s FCWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786386629; x=1786991429; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jHGYfRwrvjsJp3TM66oHmnwWqtIxW+4ymQvyIWeruC0=; b=sa9kX3hEKZmBFEn2YHCa5kX8S6gxniL6G1CMSm7Va/rZdqt12QuV29JMzEJC9WTBh6 iG4TOjDa4zFfrAxvqQbjNh08rzPBID5M5KVf+aoPm+RufgT10RnGHH/BVM4raALBJ5Wt 1k8MszK4FCXiml/vOGnriVSYh74QinnzFLEzM9it4o90L1t1M4mnCmYNVWe/5Ad3ec4C dTrYbAYZsI4xxwHim65BuWyoVOOJZphfeFu40QwE3DBDSwten+1MSiVwDfypEBzI+yUY mm/YFW9ikOeSE4yNOZUQJBbLuLHDRpGJH/lK1mjznAAsXqSSnI8uX915v8a4K7n6VZh4 Bfgw== X-Forwarded-Encrypted: i=1; AHgh+Ro95mFCZiXxkSNw+P3KDbGyoxWLQHUNIOdNT8FQO6VFXZfr5it2O9HSXdsJLWjdWPXMJ5OT/AjjUhAl@vger.kernel.org X-Gm-Message-State: AOJu0YwHpcSGdj/0NIDoq7ufBpOMbon56JQK30dFONzrXeGIIf6Zjq/+ GZxELFDNgacvEEnq99DGiChj7VCBGIyElehJCNXkvvFw7CQNvxoW6q4a X-Gm-Gg: AR+sD12AgtYmSxwKrjFiFTKaTDwIdxVe3ko6OmGQYKJmQ2+ZQzIALhc+d5UjTjhCOxe 7nZEeYuLAE+eHtS7XxLt3N8hpBUIO5LL4AeQ1sNde6t5iDFVTE27JrczgLfaBUjkPFnm2jJALSl +wAELTC1FhTo4JxYw7UMiih2ASlwtQAL0WgsGYxq/jErKfD+QSYBGddaYzrcg5S/dXDKt3XNckC CbR2kWXzfpMxkYfrANFqNhuVO93aZj/GJYfNGUNJ0Ld7yMT7868N8CicguI7LXQigioB0zOPFqS gqHgHbFVWetjZJd73Ci7FDM6O7lAatCeKfKnGrHnHYGTt/IOIbvHz6d/ishGaXZj3da7wXssKEj 6E+mJ/lxgFwxjjwowWppRI7EZ8Wt9K0/ODqTsM4gSycR97CLNlKKilFBDsJEO3Gi4HVk43lbaoy lFLx46cey3QXUAiY0Dmu0YsNAA3B9mau8XcPCPQXNfVSpCkR65ViEu6yiVnmHan8TGFCR1FB4SU LKOhP2p5VRLjxMW4Q== X-Received: by 2002:a05:6a00:3a11:b0:847:9188:e492 with SMTP id d2e1a72fcca58-84f9c9b6d6bmr3399185b3a.22.1786386628920; Mon, 10 Aug 2026 11:30:28 -0700 (PDT) Received: from acer-nitro-anv15-41.entro.com ([118.34.230.2]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84f5a3d3422sm4335399b3a.19.2026.08.10.11.30.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 11:30:28 -0700 (PDT) From: Shaikh Kamaluddin To: Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Dan Williams , Ira Weiny , Li Ming , Ben Cheatham , tony.luck@intel.com, bp@alien8.de Cc: linux-cxl@vger.kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, x86@kernel.org Subject: [PATCH] cxl/mce: Only act on uncorrected memory errors Date: Tue, 11 Aug 2026 00:00:13 +0530 Message-ID: <20260810183013.47085-1-shaikhkamal2012@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-edac@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit cxl_handle_mce() offlines the aliased page of an ELC region on any record with a usable address; it does not check MCI_STATUS_UC or filter non-memory errors. uc_decode_notifier(), the equivalent handler for plain memory on the same chain at the same priority, filters on mce->severity and leaves corrected errors untouched. cxl_handle_mce() has no such gate, so a corrected error - which the generic handler ignores - still causes the alias to be permanently retired via memory_failure(). Corrected errors do reach the chain: machine_check_poll() logs them via the same mce_gen_pool_process() path that feeds x86_mce_decoder_chain, and cxl_extended_linear_cache_resize() extends p->res to cover the DRAM half of the ELC pair, so a routine DRAM CE carries an address inside the region resource. Filter the record as nfit_handle_mce() does. Commit fc08a4703a41 ("acpi, nfit: Fix the memory error check in nfit_handle_mce()") and commit 5d96c9342c23 ("acpi/nfit, x86/mce: Handle only uncorrectable machine checks") established this filter for an equivalent handler on the same notifier chain; the consequence here is more severe, as the CXL handler calls memory_failure() rather than recording a bad block. mce_is_correctable() is used instead of copying uc_decode_notifier()'s AO/DEFERRED test because the alias must still be offlined on MCE_AR_SEVERITY, where kill_me_maybe() owns the reported page but nothing owns the alias. Fixes: 516e5bd0b6bf ("cxl: Add mce notifier to emit aliased address for extended linear cache") Signed-off-by: Shaikh Kamaluddin --- Reproduced under QEMU/vng. QEMU's cxl-type3 does not emulate the HMAT extended-linear address_mode bit, so ELC was forced locally for testing via a one-line debug hack in cxl_region_probe() (not part of this patch): if (!p->cache_size && p->res) p->cache_size = resource_size(p->res) / 2; Steps: 1. Boot with an Intel CPU model under TCG (KVM host-passthrough will otherwise leak the host's real vendor ID, and AMD/SMCA takes a different mce_usable_address() path than the one under test): vng -v -r ./arch/x86/boot/bzImage --disable-kvm --qemu-opts='-cpu Skylake-Server-v4,+mce,+mca -m 4G -machine q35,cxl=on -object memory-backend-ram,id=cxl-mem0,size=512M -device pxb-cxl,bus_nr=12,bus=pcie.0,id=cxl.0 -device cxl-rp,port=0,bus=cxl.0,id=root_port0,chassis=0,slot=0 -device cxl-type3,bus=root_port0,volatile-memdev=cxl-mem0,id=cxl-mem-device0 -M cxl-fmw.0.targets.0=cxl.0,cxl-fmw.0.size=512M' 2. modprobe mce-inject $cxl list -M $cxl list -D $cxl create-region -m mem0 -d decoder0.0 -w 1 -g 256 -t ram $dmesg | grep "DEBUG: forced cache_size" $modprobe device_dax $modprobe kmem $ls /sys/bus/dax/devices/ $daxctl reconfigure-device dax0.0 --mode=system-ram $lsmem it will show as below: dax0.0 [ 42.857642] Fallback order for Node 0: 0 [ 42.857828] Built 1 zonelists, mobility grouping on. Total pages: 1010805 [ 42.858446] Policy zone: Normal [ { "chardev":"dax0.0", "size":536870912, "target_node":0, "align":2097152, "mode":"system-ram", "online_memblocks":4, "total_memblocks":4, "movable":true } ] reconfigured 1 device RANGE SIZE STATE REMOVABLE BLOCK 0x0000000000000000-0x000000007fffffff 2G online yes 0-15 0x0000000100000000-0x000000017fffffff 2G online yes 32-47 0x0000000190000000-0x00000001afffffff 512M online yes 50-53 Memory block size: 128M Total online memory: 4.5G Total offline memory: 0B 3. Load the injector if not loaded earlier and derive the two MCi_STATUS values. modprobe mce-inject MCi_STATUS bit layout used here (arch/x86/include/asm/mce.h): bit 63 VAL - record valid bit 61 UC - uncorrected (0 = corrected error under test) bit 60 EN - error reporting enabled bit 59 MISCV - MCi_MISC valid bit 58 ADDRV - MCi_ADDR valid bits[15:0] MCACOD - bit 7 set = memory-error signature, per mce_is_memory_error()'s Intel branch python3 -c " VAL, UC, EN, MISCV, ADDRV = 1<<63, 1<<61, 1<<60, 1<<59, 1<<58 MCACOD_MEM = 1<<7 # memory error signature ce = VAL | EN | MISCV | ADDRV | MCACOD_MEM uc = ce | UC print(f'CE status = {hex(ce)}') print(f'UC status = {hex(uc)}')" # CE status = 0x9c00000000000080 # UC status = 0xbc00000000000080 MCi_MISC: address-mode field, bits[8:6], must be 2 (physical): python3 -c "print(hex(2 << 6))" # misc = 0x80 4. $ cd /sys/kernel/debug/mce-inject $echo sw > flags $echo 0x9C00000000000080 > status $echo 0x80 > misc $echo 0x190010000 > addr $echo 9 > bank [ 221.813395] mce: [Hardware Error]: Machine check events logged [ 221.814716] cxl_mce_debug: entered status=0x9c00000000000080 addr=0x190010000 cache_size=0x10000000 res=[mem 0x190000000-0x1afffffff flags 0x200] usable=1 [ 221.816200] cxl_mce_debug: spa=0x190010000 contains=1 [ 221.817089] cxl_mce_debug: spa_alias=0x1a0010000 pfn=0x1a0010 pfn_valid=1 [ 221.817655] cxl_region region0: Offlining aliased SPA address0: 0x1a0010000 [ 221.821504] Memory failure: 0x1a0010: recovery action for free buddy page: Recovered [ 221.823903] mce: [Hardware Error]: CPU 0: Machine Check: 0 Bank 9: 9c00000000000080 [ 221.824617] mce: [Hardware Error]: TSC a605ccda40 ADDR 190010000 MISC 80 [ 221.824997] mce: [Hardware Error]: PROCESSOR 0:50654 TIME 1786375908 SOCKET 0 APIC 0 microcode 1 root@virtme-ng:/sys/kernel/debug/mce-inject# root@virtme-ng:/sys/kernel/debug/mce-inject# grep HardwareCorrupted /proc/meminfo HardwareCorrupted: 4 kB CE without this patch: cxl_region region0: Offlining aliased SPA address0: 0x1a0010000 Memory failure: 0x1a0010: recovery action for free buddy page: Recovered HardwareCorrupted: 4 kB ------------------------------------- CE with this patch: (no "Offlining aliased SPA" message logged) HardwareCorrupted: 0 kB $cd /sys/kernel/debug/mce-inject $echo sw > flags $echo 0x9C00000000000080 > status $echo 0x80 > misc $echo 0x190010000 > addr $echo 9 > bank addr bank cpu flags ipid misc README status synd [ 61.681659] mce: [Hardware Error]: Machine check events logged [ 61.683442] cxl_mce_debug: entered status=0x9c00000000000080 addr=0x190010000 cache_size=0x10000000 res=[mem 0x190000000-0x1afffffff flags 0x200] usable=1 [ 61.684528] mce: [Hardware Error]: CPU 0: Machine Check: 0 Bank 9: 9c00000000000080 [ 61.684974] mce: [Hardware Error]: TSC 2eeae32fe0 ADDR 190010000 MISC 80 [ 61.688880] mce: [Hardware Error]: PROCESSOR 0:50654 TIME 1786377156 SOCKET 0 APIC 0 microcode 1 [ 86.504456] clocksource: Watchdog remote CPU 11 read timed out $grep HardwareCorrupted /proc/meminfo HardwareCorrupted: 0 kB ------------------------- For UC, same steps only status bit information will change : $cd /sys/kernel/debug/mce-inject $echo sw > flags $echo 0xbc00000000000080 > status $echo 0x80 > misc $echo 0x190010000 > addr $echo 9 > bank $dmesg | grep cxl_mce_debug $grep HardwareCorrupted /proc/meminfo [ 313.398747] mce: [Hardware Error]: Machine check events logged [ 313.400518] cxl_mce_debug: entered status=0xbc00000000000080 addr=0x190010000 cache_size=0x10000000 res=[mem 0x190000000-0x1afffffff flags 0x200] usable=1 [ 313.401727] cxl_mce_debug: spa=0x190010000 contains=1 [ 313.402157] cxl_mce_debug: spa_alias=0x1a0010000 pfn=0x1a0010 pfn_valid=1 [ 313.402663] cxl_region region0: Offlining aliased SPA address0: 0x1a0010000 [ 313.405999] Memory failure: 0x1a0010: recovery action for free buddy page: Recovered [ 313.408375] mce: [Hardware Error]: CPU 0: Machine Check: 0 Bank 9: bc00000000000080 [ 313.408999] mce: [Hardware Error]: TSC e9dd2869e0 ADDR 190010000 MISC 80 [ 313.409367] mce: [Hardware Error]: PROCESSOR 0:50654 TIME 1786377750 SOCKET 0 APIC 0 microcode 1 Patched, UC: alias still offlined, confirming uncorrected handling is unchanged by this patch. cxl_region region0: Offlining aliased SPA address0: 0x1a0010000 Memory failure: 0x1a0010: recovery action for free buddy page: Recovered HardwareCorrupted: 4 kB drivers/cxl/core/mce.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/cxl/core/mce.c b/drivers/cxl/core/mce.c index 65fed913b221..ee70c1c9f9b9 100644 --- a/drivers/cxl/core/mce.c +++ b/drivers/cxl/core/mce.c @@ -18,7 +18,14 @@ static int cxl_handle_mce(struct notifier_block *nb, unsigned long val, u64 spa, spa_alias; unsigned long pfn; - if (!mce || !mce_usable_address(mce)) + if (!mce) + return NOTIFY_DONE; + + /* Only uncorrected memory errors warrant taking down the alias page */ + if (!mce_is_memory_error(mce) || mce_is_correctable(mce)) + return NOTIFY_DONE; + + if (!mce_usable_address(mce)) return NOTIFY_DONE; spa = mce->addr & MCI_ADDR_PHYSADDR; base-commit: 7098e9cd98a05c0c5de2fae0c2465f9d966fdd07 -- 2.43.0