From: Stephen Hemminger <stephen@networkplumber.org>
To: Rita Ruvinsky <rita.ruvinsky@weka.io>
Cc: dev@dpdk.org, longli@microsoft.com, weh@microsoft.com, stable@dpdk.org
Subject: Re: [PATCH v2 1/2] net/mana: fix MR length truncation for chunks over 4GB
Date: Mon, 10 Aug 2026 20:57:52 -0700 [thread overview]
Message-ID: <20260810205752.185c69ab@phoenix.local> (raw)
In-Reply-To: <20260806172640.2456451-1-rita.ruvinsky@weka.io>
On Thu, 6 Aug 2026 20:26:39 +0300
Rita Ruvinsky <rita.ruvinsky@weka.io> wrote:
> mana_range.len is a uint32_t, so a mempool chunk of 4GB or more
> truncates modulo 2^32 -- exactly 4GB becomes 0, 15GB becomes 3GB.
>
> The guard against priv->max_mr_size cannot catch this because it
> compares the already-truncated value, and the device advertises
> max_mr_size as UINT64_MAX. ibv_reg_mr() then fails with EINVAL on a
> zero length, or silently registers a region far shorter than the pool,
> so lookups for buffers past that boundary never find an MR and no Rx
> WQE can be posted.
>
> Widen the length to uint64_t through the MR path, including the
> multi-process request that forwards it to the primary process.
>
> Fixes: 0f5db3c68ba7 ("net/mana: implement memory registration")
> Cc: stable@dpdk.org
> Signed-off-by: Rita Ruvinsky <rita.ruvinsky@weka.io>
> Reviewed-by: Long Li <longli@microsoft.com>
> ---
Both patches are queued into net-next.
Added you to the .mailmap file.
prev parent reply other threads:[~2026-08-11 3:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 17:26 [PATCH v2 1/2] net/mana: fix MR length truncation for chunks over 4GB Rita Ruvinsky
2026-08-06 17:26 ` [PATCH v2 2/2] net/mana: fix double free of mbuf on Rx WQE post failure Rita Ruvinsky
2026-08-11 3:57 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810205752.185c69ab@phoenix.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=longli@microsoft.com \
--cc=rita.ruvinsky@weka.io \
--cc=stable@dpdk.org \
--cc=weh@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.