From: Andrew Morton <akpm@linux-foundation.org>
To: mm-commits@vger.kernel.org,stable@vger.kernel.org,rppt@kernel.org,peterx@redhat.com,jianhuizzzzz@gmail.com,akpm@linux-foundation.org
Subject: [obsolete] mm-userfaultfd-clear-uffd-wp-pte-state-when-re-registering-without-wp.patch removed from -mm tree
Date: Mon, 10 Aug 2026 15:17:33 -0700 [thread overview]
Message-ID: <20260810221734.510251F000E9@smtp.kernel.org> (raw)
The quilt patch titled
Subject: mm/userfaultfd: clear uffd-wp PTE state when re-registering without WP
has been removed from the -mm tree. Its filename was
mm-userfaultfd-clear-uffd-wp-pte-state-when-re-registering-without-wp.patch
This patch was dropped because it is obsolete
------------------------------------------------------
From: Jianhui Zhou <jianhuizzzzz@gmail.com>
Subject: mm/userfaultfd: clear uffd-wp PTE state when re-registering without WP
Date: Mon, 1 Jun 2026 16:26:09 +0800
UFFDIO_REGISTER can be issued on a range that is already registered in the
same userfaultfd context, replacing the VMA's userfaultfd tracking mode.
For example, a range can be registered with UFFDIO_REGISTER_MODE_WP and
later re-registered with UFFDIO_REGISTER_MODE_MISSING.
When the second registration removes VM_UFFD_WP, the VMA flags are updated
but existing uffd-wp state in page-table entries is left behind. That
stale state can survive in swap PTEs. On swapin, do_swap_page() restores
_PAGE_UFFD_WP from the swap PTE and can then install a writable PTE,
triggering page_table_check:
pte_uffd_wp(pte) && pte_write(pte)
Handle removal of WP mode through UFFDIO_REGISTER the same way as
UFFDIO_UNREGISTER: resolve the per-PTE uffd-wp state before dropping
VM_UFFD_WP from the VMA.
Also make the same-context fast path require an exact UFFD mode match.
The old subset check treats MISSING|WP -> MISSING as a no-op, even though
WP mode is being removed.
Link: https://lore.kernel.org/20260601082609.170076-1-jianhuizzzzz@gmail.com
Fixes: f45ec5ff16a7 ("userfaultfd: wp: support swap and page migration")
Signed-off-by: Jianhui Zhou <jianhuizzzzz@gmail.com>
Reported-by: syzbot+18d274a59b87cf80e86d@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=18d274a59b87cf80e86d
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Peter Xu <peterx@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
mm/userfaultfd.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
--- a/mm/userfaultfd.c~mm-userfaultfd-clear-uffd-wp-pte-state-when-re-registering-without-wp
+++ a/mm/userfaultfd.c
@@ -2337,7 +2337,7 @@ static int userfaultfd_register_range(st
* userfaultfd and with the right tracking mode too.
*/
if (vma->vm_userfaultfd_ctx.ctx == ctx &&
- vma_test_all_mask(vma, vma_flags))
+ (vma->vm_flags & __VM_UFFD_FLAGS) == vm_flags)
goto skip;
/*
@@ -2352,6 +2352,14 @@ static int userfaultfd_register_range(st
start = vma->vm_start;
vma_end = min(end, vma->vm_end);
+ /*
+ * Re-registering into the same userfaultfd can remove WP mode.
+ * Clear any per-PTE uffd-wp state before dropping VM_UFFD_WP,
+ * matching the UFFDIO_UNREGISTER cleanup semantics.
+ */
+ if (userfaultfd_wp(vma) && !(vm_flags & VM_UFFD_WP))
+ uffd_wp_range(vma, start, vma_end - start, false);
+
new_vma_flags = vma->flags;
vma_flags_clear_mask(&new_vma_flags, __VMA_UFFD_FLAGS);
vma_flags_set_mask(&new_vma_flags, vma_flags);
_
Patches currently in -mm which might be from jianhuizzzzz@gmail.com are
reply other threads:[~2026-08-10 22:17 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260810221734.510251F000E9@smtp.kernel.org \
--to=akpm@linux-foundation.org \
--cc=jianhuizzzzz@gmail.com \
--cc=mm-commits@vger.kernel.org \
--cc=peterx@redhat.com \
--cc=rppt@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.