From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com [209.85.221.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 158EE3B9DB3 for ; Mon, 10 Aug 2026 23:06:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786403182; cv=none; b=IR/owW7zEcDL1mBmaoh88Yo/z1aQ3JydlO7wZR/ZpsgQ/qDEpGiMtNZ6NOokssMGG5gXkQtZnGfwS3t7mrVcPtqyf4is8PJ8Z2wripm+Mu/p61FCy0M30OWq9lSB3R4yyCEwGJiqBUtdIH5OOtb4653IywEq0JK4YS+qK0JWS6A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786403182; c=relaxed/simple; bh=cN3dntYSRKkBZpxQVRebrXb/QZ7i856/vDVWzWsugXQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rUyx0/ZNzvJ+NWESIRH5XvY1xDvCOfwT21rullltbTrH+JX7zMKZWmkEzS5mhevth2pl1fLLuj/ts6lP0g16v2ZDqq923g6sBmzr8HAALqEo2ib/or6si9hzyP5g2uca2dGCEPmacwd0mkbSQ1a3HAt1nGwFoJ8RgNLKhgVcrMk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peridio.com; spf=pass smtp.mailfrom=peridio.com; dkim=pass (2048-bit key) header.d=peridio.com header.i=@peridio.com header.b=zgTLPEIy; arc=none smtp.client-ip=209.85.221.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=peridio.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=peridio.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=peridio.com header.i=@peridio.com header.b="zgTLPEIy" Received: by mail-vk1-f171.google.com with SMTP id 71dfb90a1353d-5bfa60aa6caso62550e0c.2 for ; Mon, 10 Aug 2026 16:06:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=peridio.com; s=google; t=1786403180; x=1787007980; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qEP94udPMsH7DZzh3NprgOqukKgliAk1nMK36vluOns=; b=zgTLPEIyDyNu03GghCP+oVAaanG4lX4gWWNonwSreaw6IUbyXQ/6jAj/0VruyPuFuQ mN9YNSxlSBSd1aG30b8B744F3hfbjwDyrECr5br5dQys+vScw5/+KuOzLola9tewQuBy gFux9/mfLs3rUshN4vcpceBDR1j45kirwBTnlXWmJUfgZEpUAh1n8TdXHmLYYDyaSsj9 grQU1S6quBNtuqQYizjYSItidQXnCZbRx1vamqVR/QsObnL5CTSixUG+PwSgH2OTtden rKtHVaTGTWT8BXvDi4SBQE0Aqyg9qAWohOT01mcOKd+3iIzkP6j+ulG95EY/1LPVy9XF +vKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786403180; x=1787007980; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qEP94udPMsH7DZzh3NprgOqukKgliAk1nMK36vluOns=; b=H3H0UtOizZRoyzRp+t0+IjK0MMP6+pgzafeBbzgNu3k9ZSYQc/d9QRkh0I7+QvYe/+ p+0/EN4Omw5OHfsfwfQCL0zEsXAwNRVIZefQfIkSjctWQFg/SnHf7leM6menIFV8Tzz2 VZo7w+T4FuFHrLdttu7yn41TP6P7gfnPQzVOpQXCT4CrQaRAFD235IE0Q+dt1m6u3QTV X4LJgx/a3ca6RavUtXeP945n1h7wdZEuwiuflSWTQ3oObbEqtGU7DxM0VlNMMRaw03dc SNgb4RVAc6YrHzoOSQcnAwgNrb2uYezL4FoxZkyDL7fPTeUYo6bg8xSVUog5O95Q+GLH 8KbQ== X-Forwarded-Encrypted: i=1; AHgh+Rok1Foy3DHdU4uvLqBRB/OBmkPfsKv2FBO6ZanQyKyaGHGC0BU7FAbnf+XSfXwgXuh7buPuDpjnMidruzM=@vger.kernel.org X-Gm-Message-State: AOJu0YxCIdSOfTClVt+JKuZ7af3yCZUI/+Y7zq1UAr017i/XGrFclbKV 6qfAxXo7bU52VnNHKlatVf1LI3FWStjL5nnplx6HZf4Ud3FgpVivlh2o514kVmI821dsEmRHtTg hp5GSrX0= X-Gm-Gg: AR+sD11YGlOE1dEc5/L+WyUXCud9+K0IhMdNXdaZOnW9f12TSzH2t9HaLQbtnKrgKhF hIJj43iPmCT29T7tqvZa5ZeHNGKx/CxO+Vi71YJxEcJ4v5LKQUtmXElT3TBp/boveZ73vKvczA6 0631xnI/hKc6gVhHaJouVljygprJ3PJT0a1gOyRBuDBERfKNcKk1YwNhrg5anGGId4Mpud5Ghar QUwi89JjFR7P/64DkOEVsZ1JN6A8g2KoLc29ereBSpHIcbZN5DtjP7KdpqDgQrKjnC3TnUwaAXq ZikrN/PvIAmbiOFGgMsjWOyboygdh2X2GdYtrwbAYPgFPweomhcFVErasTXm9msjWTc9SaiIWvB iKKhc4yztIr/ho2jT1xTIEIuiADrLiJj4DC4RFJF6waiTS5U5FX8t4HaEYp0ZSWvOE22Dc6Ri6k PmLGjMn5diPjQKX3F/BzpzMf7oDBNhOwLbyrXWGrbNHINdBANgbJ4g7d5mWFXHI9DqP9xA3xif0 GKBmtajmBLzJXc= X-Received: by 2002:a05:6122:6b8d:10b0:5c3:6e8a:4a22 with SMTP id 71dfb90a1353d-5c3d940b089mr3357590e0c.3.1786403179879; Mon, 10 Aug 2026 16:06:19 -0700 (PDT) Received: from localhost ([190.113.101.40]) by smtp.gmail.com with ESMTPSA id 71dfb90a1353d-5c420a2d1d8sm3340875e0c.6.2026.08.10.16.06.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Aug 2026 16:06:19 -0700 (PDT) Sender: Javier Tia From: Javier Tia X-Google-Original-From: Javier Tia To: Carlos Maiolino Cc: "Darrick J . Wong" , Dave Chinner , Allison Henderson , Andrey Albershteyn , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/6] xfs: give the deferred barrier op type a name Date: Mon, 10 Aug 2026 17:06:14 -0600 Message-ID: <20260810230611.2859909-10-floss@jetm.me> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260810230611.2859909-8-floss@jetm.me> References: <20260810230611.2859909-8-floss@jetm.me> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1371; i=floss@jetm.me; h=from:subject; bh=cN3dntYSRKkBZpxQVRebrXb/QZ7i856/vDVWzWsugXQ=; b=owEB7QES/pANAwAKAbXuwwuoZ3cfAcsmYgBqelljZqnJOJa7RnkDd+smQ6u6sTV39cbOgg3pl R42h1J2EW+JAbMEAAEKAB0WIQSbE7ILzw7eI0VKk8m17sMLqGd3HwUCanpZYwAKCRC17sMLqGd3 HwjgC/9W+RZggkTvAas8vSgCzWt+sCY/+LWSwn8Zb63ECol+aJvCAiPZRr2cOROR+wuB+Oc6Hq+ fX7Ku1B4/T9TIPW4ClO5az8YG31sz23EgwCDSEt5DCagmasNmF9N0OWRZA0BJz+RFfxFtuAU+Ln 7gNV54+UuYYCbSrYBZPlUawEJzZxIqctSqKZvAU06FfJ0sNQs9Qz8Fgj5bAJf+vOFocrgkTlGMR CXBpTXLLvzR/xp0PlzyriXzO0AMcmf4i7CRM0nxFoZ5DTzQ93+/pSTu2lfcOB07p3bN99s556b4 /pWImMOIck8AYgKa10wxkRe9ZhiZSHt8KD8k1RsoFu969z6PONSTSwIpOLMBJVMeBqj4iRnt+V7 czDk5j4n5ld4UWZqYs51fSEYShsMtoimfnKUsl89mYWWB/QZ7fH1VgzX/F13Xg4eNhVz1elL7e3 7kr7G9JC7sVywFxWmCmyMM91RzR/q6P4jT7Vhv1jkUB/muX5Y2Q08b4mfrgdiaohHLvSs= X-Developer-Key: i=floss@jetm.me; a=openpgp; fpr=9B13B20BCF0EDE23454A93C9B5EEC30BA867771F Content-Transfer-Encoding: 8bit xfs_barrier_defer_type is the only xfs_defer_op_type with no .name. Every other one carries a short string used for tracing and reporting: attr, bmap, extent_free, agfl_free, rtextent_free, refcount, rtrefcount, rmap, rtrmap and exchmaps. That has been harmless because nothing dereferences the field, but it leaves a NULL in a table where every other entry is populated, so the first caller to print it gets "(null)" in the kernel and undefined behaviour in the userspace libxfs build of this file, where xfs_alert lands in fprintf. xfs_defer_add() already treats a missing member of this table as worth shutting the filesystem down for, so an unpopulated one is out of step with how the file handles its own ops tables. Signed-off-by: Javier Tia Reviewed-by: "Darrick J. Wong" --- fs/xfs/libxfs/xfs_defer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/xfs/libxfs/xfs_defer.c b/fs/xfs/libxfs/xfs_defer.c index 843c33304441..75f0d37914d5 100644 --- a/fs/xfs/libxfs/xfs_defer.c +++ b/fs/xfs/libxfs/xfs_defer.c @@ -229,6 +229,7 @@ xfs_defer_barrier_cancel_item( } static const struct xfs_defer_op_type xfs_barrier_defer_type = { + .name = "barrier", .max_items = 1, .create_intent = xfs_defer_barrier_create_intent, .abort_intent = xfs_defer_barrier_abort_intent, -- Javier Tia