From: Henrik Grimler <henrik.grimler@axis.com>
To: "Sebastian Reichel" <sre@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Pali Rohár" <pali@kernel.org>, "Andrew F. Davis" <afd@ti.com>,
"Chris Lapa" <chris@lapa.com.au>, "Dan Murphy" <dmurphy@ti.com>
Cc: <linux-pm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Sebastian Reichel <sebastian.reichel@collabora.com>,
<kernel@axis.com>, Henrik Grimler <henrik.grimler@axis.com>
Subject: [PATCH 4/5] power: supply: bq27xxx: bq28z610: fix invalid AverageEnergy address
Date: Tue, 11 Aug 2026 13:47:46 +0200 [thread overview]
Message-ID: <20260811-bq27z746-v1-4-3a4fa38205cc@axis.com> (raw)
In-Reply-To: <20260811-bq27z746-v1-0-3a4fa38205cc@axis.com>
bq28z610 currently uses the AveragePower reg, 0x22, for reading both
AveragePower and AvailableEnergy. The technical reference manual does
not mention AvailableEnergy, and it does not make sense to read a
cumulative, always positive, property like AvailableEnergy from a rate
property like AveragePower. Set REG_AE as invalid to fix it.
Fixes: 707d678a5c7c ("power: supply: bq27xxx_battery: Add the BQ28z610 Battery monitor")
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
drivers/power/supply/bq27xxx_battery.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/bq27xxx_battery.c b/drivers/power/supply/bq27xxx_battery.c
index e28eca53c7ee..4985eb54090e 100644
--- a/drivers/power/supply/bq27xxx_battery.c
+++ b/drivers/power/supply/bq27xxx_battery.c
@@ -518,7 +518,7 @@ static u8
[BQ27XXX_REG_RC] = 0x10,
[BQ27XXX_REG_FCC] = 0x12,
[BQ27XXX_REG_CYCT] = 0x2a,
- [BQ27XXX_REG_AE] = 0x22,
+ [BQ27XXX_REG_AE] = INVALID_REG_ADDR,
[BQ27XXX_REG_SOC] = 0x2c,
[BQ27XXX_REG_DCAP] = 0x3c,
[BQ27XXX_REG_AP] = 0x22,
--
2.43.0
next prev parent reply other threads:[~2026-08-11 11:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 11:47 [PATCH 0/5] power: supply: bq27xxx: add bq27z746, and fix some regs Henrik Grimler
2026-08-11 11:47 ` [PATCH 1/5] dt-bindings: power: bq27xxx: document bq27z746 Henrik Grimler
2026-08-17 7:50 ` Krzysztof Kozlowski
2026-08-17 15:00 ` Henrik Grimler
2026-08-17 15:14 ` Krzysztof Kozlowski
2026-08-11 11:47 ` [PATCH 2/5] power: supply: bq27xxx: add support for bq27z746 Henrik Grimler
2026-08-11 11:47 ` [PATCH 3/5] power: supply: bq27xxx: bq27520g4: fix REG_TTES address Henrik Grimler
2026-08-11 11:47 ` Henrik Grimler [this message]
2026-08-11 11:47 ` [PATCH 5/5] power: supply: bq27xxx: bq27z561: fix invalid AverageEnergy address Henrik Grimler
2026-08-12 22:23 ` (subset) [PATCH 0/5] power: supply: bq27xxx: add bq27z746, and fix some regs Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811-bq27z746-v1-4-3a4fa38205cc@axis.com \
--to=henrik.grimler@axis.com \
--cc=afd@ti.com \
--cc=chris@lapa.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali@kernel.org \
--cc=robh@kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.