From: "Rénich Bon Ćirić" <renich@evalinux.com>
To: Harshitha Ramamurthy <hramamurthy@google.com>
Cc: netdev@vger.kernel.org, "Joshua Washington" <joshwash@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"David S . Miller" <davem@davemloft.net>,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
"Rénich Bon Ćirić" <renich@evalinux.com>
Subject: Re: [PATCH net v2] gve: use gve_schedule_reset() on AdminQ flow rule timeout
Date: Mon, 10 Aug 2026 18:36:11 -0600 [thread overview]
Message-ID: <20260811003611.509920-1-renich@evalinux.com> (raw)
On Mon, 10 Aug 2026 14:13:00 -0700, Harshitha Ramamurthy wrote:
> gve_reset() does not acquire the rtnl_lock(). Also, there is no inner
> driver lock context that is acquired at this point. The inner driver
> lock context that the AI is complaining about is possibly
> priv->adminq_lock but that is already released on error by
> gve_adminq_execute_cmd(). gve_reset() is also written in such a way
> that the onus is on the caller to acquire the appropriate locks -
> either through the ethtool core when calling
> gve_user_reset()/gve_set_rxnfc() or explicitly by gve_handle_reset().
>
> Sashiko has also called out a few issues this change could introduce.
> Considering this issue hasn't actually been encountered in the wild,
> there is no lockdep splat and the commit message is inaccurate, I
> don't think this qualifies for the net tree.
>
> For the net-next tree, a more holistic change is in the works for the
> reset path that also changes this path and removes the synchronous
> reset anyway.
Understood. Thanks for clarifying the gve_reset() lock mechanics and
adminq_lock release behavior.
We will drop this patch from the net tree and look out for Google's
upcoming reset path refactoring in net-next.
next reply other threads:[~2026-08-11 0:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 0:36 Rénich Bon Ćirić [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-08-08 0:21 [PATCH net v2] gve: use gve_schedule_reset() on AdminQ flow rule timeout Rénich Bon Ćirić
2026-08-10 21:13 ` Harshitha Ramamurthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811003611.509920-1-renich@evalinux.com \
--to=renich@evalinux.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hramamurthy@google.com \
--cc=joshwash@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.