From: Jakub Kicinski <kuba@kernel.org>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, horms@kernel.org, andrew@lunn.ch,
Willem de Bruijn <willemb@google.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
Joshua A Hay <joshua.a.hay@intel.com>
Subject: Re: [PATCH net-next v5 3/6] idpf: support pacing offload
Date: Tue, 11 Aug 2026 08:20:28 -0700 [thread overview]
Message-ID: <20260811082028.6223543a@kernel.org> (raw)
In-Reply-To: <willemdebruijn.kernel.2f01b2b7b1be5@gmail.com>
On Mon, 10 Aug 2026 21:38:07 -0400 Willem de Bruijn wrote:
> > > + if (!horizon)
> > > + return;
> > > +
> > > + /* Skip if netpoll: not needed and not safe to call ktime helpers */
> > > + if (netpoll_tx_running(skb->dev))
> >
> > Is this due to Gemini's complaint? netpoll sending packets with
> > timestamp in the future seems unreasonable to me, no?
>
> It is. Makes sense to ignore EDT request when running in netpoll right.
> Do you mean that we should not even check for that in the hot path?
No strong preference but I wouldn't check. netpoll is for emergency
data, and bypasses qdiscs, it can't possibly be paced..
next prev parent reply other threads:[~2026-08-11 15:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-08 15:51 [PATCH net-next v5 0/6] hardware pacing offload Willem de Bruijn
2026-08-08 15:51 ` [PATCH net-next v5 1/6] net: rtnetlink: add pacing_offload_horizon attribute to net_device Willem de Bruijn
2026-08-08 15:51 ` [PATCH net-next v5 2/6] net_sched: sch_fq: clear past skb->tstamp if offloading pacing Willem de Bruijn
2026-08-08 15:51 ` [PATCH net-next v5 3/6] idpf: support pacing offload Willem de Bruijn
2026-08-11 1:12 ` Jakub Kicinski
2026-08-11 1:38 ` Willem de Bruijn
2026-08-11 15:20 ` Jakub Kicinski [this message]
2026-08-08 15:51 ` [PATCH net-next v5 4/6] selftests: drv-net: refactor so_txtime errqueue handling Willem de Bruijn
2026-08-08 15:51 ` [PATCH net-next v5 5/6] selftests: drv-net: in so_txtime tell apart sw from hw pacing Willem de Bruijn
2026-08-08 15:51 ` [PATCH net-next v5 6/6] selftests: drv-net: extend so_txtime with hw offload Willem de Bruijn
2026-08-10 14:34 ` [PATCH net-next v5 0/6] hardware pacing offload Willem de Bruijn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811082028.6223543a@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=joshua.a.hay@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.