All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: devicetree@vger.kernel.org, Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Mailing List <devicetree-spec@vger.kernel.org>,
	"open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/Mediatek SoC support:Keyword:mediatek"
	<linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support:Keyword:mediatek"
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: net: add nvmem-consumer reference to network-class
Date: Tue, 11 Aug 2026 09:05:16 -0500	[thread overview]
Message-ID: <20260811140516.GA2090384-robh@kernel.org> (raw)
In-Reply-To: <20260802214354.490074-1-rosenp@gmail.com>

On Sun, Aug 02, 2026 at 02:43:54PM -0700, Rosen Penev wrote:
> The nvmem-cells and nvmem-cell-names properties are used to supply MAC
> addresses to both wired and wireless network controllers. The wired
> hierarchy already allows them through ethernet-controller.yaml, but the
> wireless hierarchy (wireless-controller.yaml -> network-class.yaml)
> does not. As a result, brcm,bcm4329-fmac nodes using nvmem (e.g.
> bcm4709-linksys-ea9200.dts) failed dtbs_check with:
> 
>     Unevaluated properties are not allowed ('nvmem-cell-names',
>     'nvmem-cells' were unexpected)
> 
> Each wireless driver otherwise has to add the nvmem-consumer reference
> individually (qca,ath9k and mediatek,mt76 already declare their own
> nvmem-cells/nvmem-cell-names).
> 
> Add the nvmem-consumer reference to network-class.yaml so all network
> nodes inherit the properties at once. Wired controllers keep the tighter
> single-cell, mac-address-only constraints via ethernet-controller.yaml,
> which still apply alongside the relaxed class-level properties.
> 
> Assisted-by: opencode:big-pickle
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
>  Documentation/devicetree/bindings/net/network-class.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/net/network-class.yaml b/Documentation/devicetree/bindings/net/network-class.yaml
> index 06461fb92eb8..f7c8e24016f7 100644
> --- a/Documentation/devicetree/bindings/net/network-class.yaml
> +++ b/Documentation/devicetree/bindings/net/network-class.yaml
> @@ -43,4 +43,7 @@ properties:
>        maximum frame size (there\'s contradiction in the Devicetree
>        Specification).
>  
> +allOf:
> +  - $ref: /schemas/nvmem/nvmem-consumer.yaml#

This is not correct as I explained in the prior patch.

Rob


      reply	other threads:[~2026-08-11 14:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-02 21:43 [PATCH] dt-bindings: net: add nvmem-consumer reference to network-class Rosen Penev
2026-08-11 14:05 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260811140516.GA2090384-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree-spec@vger.kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=rosenp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.