From: Jason Gunthorpe <jgg@ziepe.ca>
To: Yili Zhang <zhangyili01@baidu.com>
Cc: leon@kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] RDMA/core: Untrack resources before driver destroy
Date: Tue, 11 Aug 2026 11:18:25 -0300 [thread overview]
Message-ID: <20260811141825.GE544626@ziepe.ca> (raw)
In-Reply-To: <6a7affe3.26268144.122abf.417fSMTPIN_ADDED_BROKEN@mx.google.com>
On Tue, Aug 11, 2026 at 06:56:22PM +0800, Yili Zhang wrote:
> From: Yili Zhang <zhangyili01@baidu.com>
>
> When a userspace RDMA object cannot be destroyed by the driver during
> ib_uverbs_close() (e.g. mlx5 destroy_cq/destroy_qp fails because the
> hardware is in a transient error state),
That's a bug in of itself, if the HW is erroring then the destroy
should wait for the error to progress past flr and then let the
destroy continue.
> Fix it by moving rdma_restrack_del() to *before* the driver's destroy
> callback, so the restrack entry is removed at the moment we commit to
> destroying the object rather than only on success.
No, that messes up legitimate cases where the destroy is allowed to
fail.
AFAICT the issue here is the netlink is not allowed to access the
context without proper locking.
Jason
parent reply other threads:[~2026-08-11 14:18 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <6a7affe3.26268144.122abf.417fSMTPIN_ADDED_BROKEN@mx.google.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811141825.GE544626@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=zhangyili01@baidu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.