All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <elder@riscstar.com>
To: akpm@linux-foundation.org, david@kernel.org, pjw@kernel.org,
	brauner@kernel.org, ljs@kernel.org
Cc: demiobenour@gmail.com, tglx@kernel.org, debug@rivosinc.com,
	oleg@redhat.com, thomas.weissschuh@linutronix.de,
	linux-kernel@vger.kernel.org
Subject: [PATCH] kernel/sys.c: use RCU when accessing task_struct->real_parent
Date: Tue, 11 Aug 2026 14:05:00 -0500	[thread overview]
Message-ID: <20260811190501.1486442-1-elder@riscstar.com> (raw)

In the setpgid() syscall definition, a check is made to determine
whether the target process is in the same thread group as the
current process.  The check accesses the target process's real_parent
pointer directly, however that field is supposed to be accessed via
RCU.  Use rcu_dereference() to avoid this C=1 build warning:

  kernel/sys.c:1144:32: warning: incorrect type in argument 1 (different address spaces)

Signed-off-by: Alex Elder <elder@riscstar.com>
---
 kernel/sys.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/sys.c b/kernel/sys.c
index df69bd71de032..434fe6ad30e13 100644
--- a/kernel/sys.c
+++ b/kernel/sys.c
@@ -1114,6 +1114,7 @@ COMPAT_SYSCALL_DEFINE1(times, struct compat_tms __user *, tbuf)
 SYSCALL_DEFINE2(setpgid, pid_t, pid, pid_t, pgid)
 {
 	struct task_struct *p;
+	struct task_struct *real_parent;
 	struct task_struct *group_leader = current->group_leader;
 	struct pid *pids[PIDTYPE_MAX] = { 0 };
 	struct pid *pgrp;
@@ -1141,7 +1142,8 @@ SYSCALL_DEFINE2(setpgid, pid_t, pid, pid_t, pgid)
 	if (!thread_group_leader(p))
 		goto out;
 
-	if (same_thread_group(p->real_parent, group_leader)) {
+	real_parent = rcu_dereference(p->real_parent);
+	if (same_thread_group(real_parent, group_leader)) {
 		err = -EPERM;
 		if (task_session(p) != task_session(group_leader))
 			goto out;

base-commit: 6b8c8af514d739d0335f5579b585e02babe8a727
-- 
2.53.0


             reply	other threads:[~2026-08-11 19:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11 19:05 Alex Elder [this message]
2026-08-12  1:17 ` [PATCH] kernel/sys.c: use RCU when accessing task_struct->real_parent Andrew Morton
2026-08-12  2:06   ` Alex Elder
2026-08-12  7:55 ` Oleg Nesterov
2026-08-12 12:04   ` Alex Elder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260811190501.1486442-1-elder@riscstar.com \
    --to=elder@riscstar.com \
    --cc=akpm@linux-foundation.org \
    --cc=brauner@kernel.org \
    --cc=david@kernel.org \
    --cc=debug@rivosinc.com \
    --cc=demiobenour@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ljs@kernel.org \
    --cc=oleg@redhat.com \
    --cc=pjw@kernel.org \
    --cc=tglx@kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.