From: sashiko-bot@kernel.org
To: "Rosen Penev" <rosenp@gmail.com>
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org, robh@kernel.org
Subject: Re: [PATCHv2] dt-bindings: net: brcm,bcm4329-fmac: add nvmem-cells for MAC address
Date: Tue, 11 Aug 2026 19:39:58 +0000 [thread overview]
Message-ID: <20260811193958.EF1ED1F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260811192829.123410-1-rosenp@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The patch claims to fix a dtbs_check failure in bcm4709-linksys-ea9200.dts by updating the brcm,bcm4329-fmac wireless binding. However, the bcm4709-linksys-ea9200.dts device tree does not contain any brcm,bcm4329-fmac nodes. The actual nvmem-cells property triggering the validation error in that file is located in a DSA ethernet switch port node (port@4 of &srab). As a result, the patch completely fails to fix the cited validation error and its justification is misattributed.
--
--- Patch [1]: [PATCHv2] dt-bindings: net: brcm,bcm4329-fmac: add nvmem-cells for MAC address ---
commit 9d4080c22265cf928d39764eafdb9bcf9fa9f241
Author: Rosen Penev <rosenp@gmail.com>
dt-bindings: net: brcm,bcm4329-fmac: add nvmem-cells for MAC address
This commit adds constraints for nvmem-cells and nvmem-cell-names to the
brcm,bcm4329-fmac binding. It aims to resolve dtbs_check failures related
to unevaluated properties.
> The nvmem-cells and nvmem-cell-names properties are used to supply a
> MAC address to the brcmfmac wireless controller. Nodes such as
> bcm4709-linksys-ea9200.dts fail dtbs_check with:
>
> Unevaluated properties are not allowed ('nvmem-cell-names',
> 'nvmem-cells' were unexpected)
[Severity: Medium]
The commit message claims this patch fixes a dtbs_check failure in
bcm4709-linksys-ea9200.dts, but is this accurate?
Looking at arch/arm/boot/dts/broadcom/bcm4709-linksys-ea9200.dts, the
nvmem-cells property causing the error is located in a DSA ethernet switch
port node, not a wireless controller:
port@4 {
label = "wan";
nvmem-cells = <&et2macaddr 1>;
nvmem-cell-names = "mac-address";
};
Since the bcm4709-linksys-ea9200.dts device tree does not contain any
brcm,bcm4329-fmac nodes, updating the brcm,bcm4329-fmac wireless binding
will not fix the cited dtbs_check error.
Should the commit message be updated to cite a different device tree, or
should this fix be applied to the DSA switch port binding instead?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260811192829.123410-1-rosenp@gmail.com?part=1
prev parent reply other threads:[~2026-08-11 19:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 19:28 [PATCHv2] dt-bindings: net: brcm,bcm4329-fmac: add nvmem-cells for MAC address Rosen Penev
2026-08-11 19:39 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260811193958.EF1ED1F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rosenp@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.