From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 915E947DFBD for ; Tue, 11 Aug 2026 19:42:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477366; cv=none; b=KIb39rnhLhTOXcNlZfY+s2U/tirvv7jljcLm8+CQSFRhpk9tpmsTolxblSLK0s0sz3G8ixZcVkl4n99dgB3uA4OmpzlnTsUNHHOD91BYCh4jwGlTQyvyMLbNNEXvr/bsmPv36U1a/WWlshBezRVXs1t2C/+/XDIYEN6SgbuWNOc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786477366; c=relaxed/simple; bh=U1vS2hAziy9qUItkEoTyRmbezIqMpTHDIy3iBj2cyM8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QezyzU9xdc6UwoEdCr6vkNcP0chiWQJHXM8C5LibUzUGVIXNk9NSpetA0AgTNuC4ZsEaUFE7xR90NS6GIkPjWCYSbW88hV3txli6SLOR0Nxn9pDu+aPM5quSGML6hX2d4kHq3EHjnAYiWusPjxEklMFO2ymx0JQ/TshJG08Tx8Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=SbSmp27Q; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SbSmp27Q" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-4921eed3fa2so735105e9.0 for ; Tue, 11 Aug 2026 12:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786477363; x=1787082163; darn=lists.linux.dev; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=ThEXNcRr1uXZthkNQc1yyhogFUr1K8iZ1YVWwE63FbE=; b=SbSmp27QwvQ1CB6NzJZEII3Nr5Edd5jgWf7/HTbWS0tWhb5T2NxG4SuLpYDruBouW6 idFfwF6b4WZurDQo4BMGJG8ja1qBowEJObaEFokyXg+Wa048ZDp9VW0DbHxnlazTmhSo SOgUKwaCbsLGyn/YLoTvQE6cwTXR8oeEwq/wQr3tZ2ZYgOW7SCn3rg0iHo0oTKOwPr/A C/yrSgWSs5vHvyU4EZjY4arY4au9Ud24GPb+oFfUKjPjTETqzs2q+oNceN6d9+MvOVbQ +yY1q/xDvkOSH+PvuW25nn6SJ96THpRe7Zq+bWfN6PAnkIwTJFiN8yXLkaoa8rsYSkRC VHjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786477363; x=1787082163; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=ThEXNcRr1uXZthkNQc1yyhogFUr1K8iZ1YVWwE63FbE=; b=mxuakCFNelU4oBUHtj9MN7H2+ErBG0vmgQVy+h3ItpYRwi2wkWfIJZMhn1jZyExzWt 8fKnZ1SAp9+y6jyDUeESLxDsfx9jqb9ACpYoQ+0WH22j5bIJAhLENMasp8HJSHNo323C YunZ4p4V9Q5fm+N5x6J0L9N9y1BeXpA9UlJnYqgUQBS0nzbuZhhjkBzTg9sjRYuRGtdf ol0g0cC6x/HhlkzsYmGYK0iJMshTBxolf7jYBDkTJT0znvMuz0Yim5rL4+tWt0aUvaaX xcSCSb3rDxyi+nJ7ieeK7e+qhd/4Rm87u7GzLPNJsSkNIfkF6jthGVV91wDeNaUVHxLa ivVQ== X-Forwarded-Encrypted: i=1; AHgh+RqdBw9/27qGPB//qDG7qLkGkHPy6u84g2hosuTNb3RS+nivyWiVFTdyeuvFryscc91nJQB3SkcfRVIZRMpVf6FgthpxbQ==@lists.linux.dev X-Gm-Message-State: AOJu0YxsxEXlSigfUw9uRlHcwmXHQt3t8oaeQqX5+ZdlskTzHi3bOKxS 5LWhDMK99CTth2nnkruAD4iqaeOKXRLofPtwjAPuVrzrwjNA9BEdYok0 X-Gm-Gg: AR+sD11gVpq7iZ6mSZWLInlnh7FCQZnXQ0bWNvQtMMBPwjHwI2zvn6Hb6WBxdaC60t/ syGIURjdtPYrzrNbznmdElY/CNOXbWzxqK1pJxCW4/WogoGqicMLbTnZ4zuBbf35FEgL4MgH/YM tk5gczSxzfJ4w/XsvnGvL69dICYQcdKlV9m5ATQoBElN4B6zvi23gz3lYOTMNbVz8qnUbjyFgDu TOGG8I05A4cQFoYVCfV8sMBD6o7s6J+COwaTU44TdH+nCmdMwnza9QX8GYK+s6wXQvbqmLQL7D0 mnxTlPcVAQhYctFq5tCLHbRS+c5JuppLzxJ8lePj3WNSQK+ZCbDQW9VCIlcrp6U8xd+MpXYli2h CN9PYmDrKBtlE57xw13EJzz0FR4q8PR8pAEpSioPz5cAvHcT0sQ9CzIt/eNGDxcJM7mVEYwWMyk 3YlU6EryjxSdwSqjsQ7GF1VGcekRiW+Pr736kbcGS3csrBJ5YHwbURl88kVCu4Hzc4sI6cHTyn9 jqB+/ns530XUpmBNyIQr3Qa4KEta6xLy6AE+LTXOSTZvHBLX1MWB7Wsq+WD3xA= X-Received: by 2002:a05:600c:1f83:b0:499:4e47:eaf2 with SMTP id 5b1f17b1804b1-49978413130mr87241535e9.6.1786477362706; Tue, 11 Aug 2026 12:42:42 -0700 (PDT) Received: from torre-GIGABYTE-B550-AORUS-ELITE-V2 (212.pool95-21-2.static.orange.es. [95.21.2.212]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4997adad05esm3986195e9.3.2026.08.11.12.42.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Aug 2026 12:42:42 -0700 (PDT) From: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= To: Christian Koenig , Huang Rui Cc: =?UTF-8?q?=C3=93scar=20Meg=C3=ADa=20L=C3=B3pez?= , Matthew Auld , Matthew Brost , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linux.dev, stable@vger.kernel.org Subject: [PATCH v5 4/6] ttm_pool_type_init() does not check return value Date: Tue, 11 Aug 2026 21:42:19 +0200 Message-ID: <20260811194224.121597-5-megia.oscar@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260811194224.121597-1-megia.oscar@gmail.com> References: <20260811194224.121597-1-megia.oscar@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel-mentees@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: ttm_pool_mgr_init() does not check ttm_pool_type_init() return value and does not free pool if returns error. Fix: Move up shrinker_alloc(), check ttm_pool_type_init() return and free pool types and shrinker if non-zero and return error. Assisted-by: OpenCode:1.17.18-Big Pickle/DeepSeek V4 Flash Assisted-by: claude.ai:Sonnet 5 Cc: # 7.1.0 Fixes: 444e2a19d7fd ("ttm/pool: port to list_lru. (v2)") Signed-off-by: Óscar Megía López --- drivers/gpu/drm/ttm/ttm_pool.c | 100 ++++++++++++++++++++++++++++++--- 1 file changed, 92 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c index 87c843f52736..74d8770f41d8 100644 --- a/drivers/gpu/drm/ttm/ttm_pool.c +++ b/drivers/gpu/drm/ttm/ttm_pool.c @@ -1421,6 +1421,54 @@ static inline u64 ttm_get_node_memory_size(int nid) return managed_pages * PAGE_SIZE; } +static void ttm_pool_type_fini_and_list_lru_destroy(unsigned int nr) +{ + unsigned int i; + + if (nr == 0) + return; + + for (i = 0; i < nr; ++i) { + ttm_pool_type_fini(&global_write_combined[i]); + ttm_pool_type_fini(&global_uncached[i]); + ttm_pool_type_fini(&global_dma32_write_combined[i]); + ttm_pool_type_fini(&global_dma32_uncached[i]); + } + + /* We removed the pool types from the LRU, but we need to also make sure + * that no shrinker is concurrently freeing pages from the pool. + */ + ttm_pool_synchronize_shrinkers(); + + for (i = 0; i < nr; ++i) { + list_lru_destroy(&global_write_combined[i].pages); + list_lru_destroy(&global_uncached[i].pages); + list_lru_destroy(&global_dma32_write_combined[i].pages); + list_lru_destroy(&global_dma32_uncached[i].pages); + } + +} + +static void ttm_pool_type_fini_and_list_lru_destroy_partial( + struct ttm_pool_type *types[], unsigned int n) +{ + unsigned int k; + + if (n == 0) + return; + + for (k = 0; k < n; ++k) + ttm_pool_type_fini(types[k]); + + /* We removed the pool types from the LRU, but we need to also make sure + * that no shrinker is concurrently freeing pages from the pool. + */ + ttm_pool_synchronize_shrinkers(); + + for (k = 0; k < n; ++k) + list_lru_destroy(&types[k]->pages); +} + /** * ttm_pool_mgr_init - Initialize globals * @@ -1431,6 +1479,8 @@ static inline u64 ttm_get_node_memory_size(int nid) int ttm_pool_mgr_init(unsigned long num_pages) { unsigned int i; + int ret = 0; + struct ttm_pool_type *types_free[3]; int nid; for_each_node(nid) { @@ -1445,15 +1495,53 @@ int ttm_pool_mgr_init(unsigned long num_pages) spin_lock_init(&shrinker_lock); INIT_LIST_HEAD(&shrinker_list); + mm_shrinker = shrinker_alloc(SHRINKER_NUMA_AWARE, "drm-ttm_pool"); + if (!mm_shrinker) + return -ENOMEM; + for (i = 0; i < NR_PAGE_ORDERS; ++i) { - ttm_pool_type_init(&global_write_combined[i], NULL, + ret = ttm_pool_type_init(&global_write_combined[i], NULL, ttm_write_combined, i); - ttm_pool_type_init(&global_uncached[i], NULL, ttm_uncached, i); + if (ret) { + ttm_pool_type_fini_and_list_lru_destroy(i); + shrinker_free(mm_shrinker); + return ret; + } + + ret = ttm_pool_type_init(&global_uncached[i], NULL, ttm_uncached, i); + if (ret) { + types_free[0] = &global_write_combined[i]; + ttm_pool_type_fini_and_list_lru_destroy_partial(types_free, 1); - ttm_pool_type_init(&global_dma32_write_combined[i], NULL, + ttm_pool_type_fini_and_list_lru_destroy(i); + shrinker_free(mm_shrinker); + return ret; + } + + ret = ttm_pool_type_init(&global_dma32_write_combined[i], NULL, ttm_write_combined, i); - ttm_pool_type_init(&global_dma32_uncached[i], NULL, + if (ret) { + types_free[0] = &global_write_combined[i]; + types_free[1] = &global_uncached[i]; + ttm_pool_type_fini_and_list_lru_destroy_partial(types_free, 2); + + ttm_pool_type_fini_and_list_lru_destroy(i); + shrinker_free(mm_shrinker); + return ret; + } + + ret = ttm_pool_type_init(&global_dma32_uncached[i], NULL, ttm_uncached, i); + if (ret) { + types_free[0] = &global_write_combined[i]; + types_free[1] = &global_uncached[i]; + types_free[2] = &global_dma32_write_combined[i]; + ttm_pool_type_fini_and_list_lru_destroy_partial(types_free, 3); + + ttm_pool_type_fini_and_list_lru_destroy(i); + shrinker_free(mm_shrinker); + return ret; + } } #ifdef CONFIG_DEBUG_FS @@ -1467,10 +1555,6 @@ int ttm_pool_mgr_init(unsigned long num_pages) #endif #endif - mm_shrinker = shrinker_alloc(SHRINKER_NUMA_AWARE, "drm-ttm_pool"); - if (!mm_shrinker) - return -ENOMEM; - mm_shrinker->count_objects = ttm_pool_shrinker_count; mm_shrinker->scan_objects = ttm_pool_shrinker_scan; mm_shrinker->batch = TTM_SHRINKER_BATCH; -- 2.55.0