Re: [PATCH v5 11/11] drm/panfrost: Bump driver minor to reflect new DUMP IOCTL req field

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete patch falsely advertises new UAPI feature (hw_reset) by bumping the driver minor version, but omits the actual UAPI and driver implementations.
--

--- Patch [11]: [PATCH v5 11/11] drm/panfrost: Bump driver minor to reflect new DUMP IOCTL req field ---
commit 05a98b7146163b4b69a5fa2ced180f71b22a96f4
Author: Adrián Larumbe <adrian.larumbe@collabora.com>

Expose expanded PERFCNT_DUMP IOCTL interface to user mode.

This commit bumps the panfrost driver minor version to 7 and adds a comment
indicating the addition of a hw_reset field to the PERFCNT_DUMP ioctl.

> diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c
> index ff23b1a979bb..2949ab3ca055 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_drv.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c
> @@ -936,6 +936,7 @@ static void panfrost_debugfs_init(struct drm_minor *minor)
>   * - 1.6 - adds PANFROST_BO_MAP_WB, PANFROST_IOCTL_SYNC_BO,
>   *	   PANFROST_IOCTL_QUERY_BO_INFO and
>   *	   DRM_PANFROST_PARAM_SELECTED_COHERENCY
> + * - 1.7 - adds PERFCNT_DUMP req hw_reset field
>   */
>  static const struct drm_driver panfrost_drm_driver = {
>  	.driver_features	= DRIVER_RENDER | DRIVER_GEM | DRIVER_SYNCOBJ,
> @@ -948,7 +949,7 @@ static const struct drm_driver panfrost_drm_driver = {
>  	.name			= "panfrost",
>  	.desc			= "panfrost DRM",
>  	.major			= 1,
> -	.minor			= 6,
> +	.minor			= 7,

[Severity: Medium]
Is this patch missing the corresponding UAPI and implementation changes?

The comment and version bump explicitly advertise the new hw_reset field to
userspace, but the modifications to struct drm_panfrost_perfcnt_dump in the
UAPI header and the actual driver logic in panfrost_ioctl_perfcnt_dump() 
appear to be omitted.

Userspace checking the minor version might falsely believe the feature is
supported, leading to IOCTL failures or ignored fields. Should the version
bump occur together with the feature implementation in the same patch to
avoid intermediate breakage?

>  
>  	.gem_create_object	= panfrost_gem_create_object,
>  	.gem_prime_import	= panfrost_gem_prime_import,

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260811-claude-fixes-v5-0-3d692c9e98c2@collabora.com?part=11