From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 959ACC5CFC1 for ; Wed, 12 Aug 2026 01:10:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f+9xtiJDdh7rXp0BmF+/oxHy24dX+pWWHgCzXz8jgwc=; b=YoV88G3qMq3RBu KqmmbulaPV/fuPOKJp1qr94hK6yi1b53DkFxqHD61tb3ycIFB859r/Ur1DrCCNV/MVFvvRbJTu4LD 9s6ZDfbIGtzst5rqeyfkqz9z1iWDqjlu3ojaEMy5SNxCyeq3A0wONbjsfufUSDPz7CresxxW60ISK 3kg1/+aNzVKEof6RBcUGTgld+x8bCIEf3Ko/iMfB+vhCrMitBEu25t+EDlDYZqZWLZ60izkkbniT+ 6hMhm7ID3V/DjfmAVqDr+ZCmkJbCWy8LwUMFxNQ0VP8Imk30MN5pM9ELj3YPUsfvrAJvWaBnSopdk 0XOgHutpj11mhuPb+ULQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtxUd-0000000FBkA-1IQd; Wed, 12 Aug 2026 01:10:55 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wtxUc-0000000FBk3-0bLp for linux-phy@lists.infradead.org; Wed, 12 Aug 2026 01:10:54 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id D6EC44396D; Wed, 12 Aug 2026 01:10:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7259F1F000E9; Wed, 12 Aug 2026 01:10:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786497053; bh=ra0t7egHfjaRM3h7bxPvs/uNuD6LIUc6DQWFIVlgVto=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=KUM3dLH6kFO/HmVNpOXM3bZchQtpiKp/R4G1VTqNS4rAoehKVumpLA22SkfudTcg+ mvytZiV3Fcb+GEHj7hDf2xwvezhHLrcn+kh3KUF4vr+yQafospqrla+31j3V1SqIDO tCTuRdqTkH/Q9ondPMoGaMwbPvl1M7M081tRWTrP/KeMHPjHE+eYzAzsjW6H1YB8c4 /8w5A9Yh0pR/5ufsUp8A65byscD6WtO1kn03ke9DLIgKcSJ/uGK1eQ3+vNJqUzhdV0 Imb+GOrhq6Kj/3DA+kAlKJBCVKQTsY+DRdznt1GvbgrDWzdTCw54cWVa9oottZ4aK+ 6/QMfe5wHuMWA== From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/8] dt-bindings: usb: generic-ehci: Document access-controllers property To: "Marek Vasut" Cc: vkoul@kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org, robh@kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260812010157.1772849-4-marex@nabladev.com> References: <20260812010157.1772849-1-marex@nabladev.com> <20260812010157.1772849-4-marex@nabladev.com> Date: Wed, 12 Aug 2026 01:10:53 +0000 Message-Id: <20260812011053.7259F1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0xvd10gSW5jb21wbGV0ZSBzY2hl bWEgdXBkYXRlOiBgYWNjZXNzLWNvbnRyb2xsZXJzYCBpcyBhZGRlZCB0byBFSENJIGJ1dCBvbWl0 dGVkIGZyb20gdGhlIGNvbXBhbmlvbiBPSENJIGJpbmRpbmcuCi0tCgotLS0gUGF0Y2ggWzNdOiBb UEFUQ0ggMy84XSBkdC1iaW5kaW5nczogdXNiOiBnZW5lcmljLWVoY2k6IERvY3VtZW50IGFjY2Vz cy1jb250cm9sbGVycyBwcm9wZXJ0eSAtLS0KY29tbWl0IDVhNGE2M2FkOTZmMDVhYjgyOTY2Zjcy M2JiYjE2OThiY2ZiNDM1NmEKQXV0aG9yOiBNYXJlayBWYXN1dCA8bWFyZXhAbmFibGFkZXYuY29t PgoKZHQtYmluZGluZ3M6IHVzYjogZ2VuZXJpYy1laGNpOiBEb2N1bWVudCBhY2Nlc3MtY29udHJv bGxlcnMgcHJvcGVydHkKClRoaXMgY29tbWl0IGFkZHMgdGhlIGFjY2Vzcy1jb250cm9sbGVycyBw cm9wZXJ0eSB0byB0aGUgZ2VuZXJpYyBFSENJIFVTQgpjb250cm9sbGVyIGRldmljZSB0cmVlIGJp bmRpbmcgc2NoZW1hLiBUaGlzIGFsbG93cyBhY2Nlc3MgY2hlY2tzIHRvIGJlCmRvY3VtZW50ZWQg Zm9yIHRoZXNlIGNvbnRyb2xsZXJzLgoKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZp Y2V0cmVlL2JpbmRpbmdzL3VzYi9nZW5lcmljLWVoY2kueWFtbCBiL0RvY3VtZW50YXRpb24vZGV2 aWNldHJlZS9iaW5kaW5ncy91c2IvZ2VuZXJpYy1laGNpLnlhbWwKPiBpbmRleCA1NWE1YWE3ZDdh NTRlLi42MDIyNDE4ODdkOTk1IDEwMDY0NAo+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJl ZS9iaW5kaW5ncy91c2IvZ2VuZXJpYy1laGNpLnlhbWwKPiArKysgYi9Eb2N1bWVudGF0aW9uL2Rl dmljZXRyZWUvYmluZGluZ3MvdXNiL2dlbmVyaWMtZWhjaS55YW1sCj4gQEAgLTgwLDYgKzgwLDkg QEAgcHJvcGVydGllczoKPiAgICAgIG1pbkl0ZW1zOiAxCj4gICAgICBtYXhJdGVtczogMgo+ICAK PiArICBhY2Nlc3MtY29udHJvbGxlcnM6Cj4gKyAgICBtYXhJdGVtczogMQo+ICsKCltTZXZlcml0 eTogTG93XQpEb2VzIHRoaXMgcHJvcGVydHkgYWxzbyBuZWVkIHRvIGJlIGFkZGVkIHRvIHRoZSBn ZW5lcmljIE9IQ0kgYmluZGluZwooZ2VuZXJpYy1vaGNpLnlhbWwpIG9yIGEgY29tbW9uIHNjaGVt YSBsaWtlIHVzYi1oY2QueWFtbD8KCklmIGEgZGV2aWNlIHRyZWUgY29uZmlndXJlcyBib3RoIGFu IEVIQ0kgY29udHJvbGxlciBhbmQgaXRzIGNvbXBhbmlvbiBPSENJCmNvbnRyb2xsZXIgYmVoaW5k IGFuIGFjY2VzcyBjb250cm9sbGVyLCB0aGUgT0hDSSBub2RlIG1pZ2h0IGZhaWwKZHRfYmluZGlu Z19jaGVjayB2YWxpZGF0aW9uIGJlY2F1c2UgZ2VuZXJpYy1vaGNpLnlhbWwgZW5mb3JjZXMKdW5l dmFsdWF0ZWRQcm9wZXJ0aWVzOiBmYWxzZS4KCj4gICAgZG1hLWNvaGVyZW50OiB0cnVlCgotLSAK U2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIwMjYw ODEyMDEwMTU3LjE3NzI4NDktMS1tYXJleEBuYWJsYWRldi5jb20/cGFydD0zCgotLSAKbGludXgt cGh5IG1haWxpbmcgbGlzdApsaW51eC1waHlAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwczovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1waHkK From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 93CA03624C9 for ; Wed, 12 Aug 2026 01:10:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786497055; cv=none; b=Q6utRyo97TzXoMyUYPrHeKjUOPkfgzULcguLz91+CUf7U5Et6vxYG18/+uVtT//7d/GvSzD0rVO9fftpGXrURArHNBxrkDiWLQSN7Q1rECXBTjqVhQxQ2GGUKC159ZGxZRGZwiaUDrn0DC57LZZRVkC9wdk5po0SGERR4XrRqag= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786497055; c=relaxed/simple; bh=DBSFXZV1NnfDOqmpFuE4PsquU8uwaOy2G1EU3yfUZxI=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=kVZhhkbczPiePj9YdADiO2etjQPx3nFrhEH++EO3L0lhj8ziEsIf0eaFe2yPcCG7a+VWoH+9kbNlvFHNe/xmtxXcy+lzQc3LzH2wrOl8jOIRu7koWPf/u1GjKy1ZQH/1ZChaEzIm1e+Da7EjTZEoKZbDGnZajyceShg29FRvNwU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=KUM3dLH6; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="KUM3dLH6" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7259F1F000E9; Wed, 12 Aug 2026 01:10:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786497053; bh=ra0t7egHfjaRM3h7bxPvs/uNuD6LIUc6DQWFIVlgVto=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=KUM3dLH6kFO/HmVNpOXM3bZchQtpiKp/R4G1VTqNS4rAoehKVumpLA22SkfudTcg+ mvytZiV3Fcb+GEHj7hDf2xwvezhHLrcn+kh3KUF4vr+yQafospqrla+31j3V1SqIDO tCTuRdqTkH/Q9ondPMoGaMwbPvl1M7M081tRWTrP/KeMHPjHE+eYzAzsjW6H1YB8c4 /8w5A9Yh0pR/5ufsUp8A65byscD6WtO1kn03ke9DLIgKcSJ/uGK1eQ3+vNJqUzhdV0 Imb+GOrhq6Kj/3DA+kAlKJBCVKQTsY+DRdznt1GvbgrDWzdTCw54cWVa9oottZ4aK+ 6/QMfe5wHuMWA== From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/8] dt-bindings: usb: generic-ehci: Document access-controllers property Reply-To: sashiko-reviews@lists.linux.dev To: "Marek Vasut" Cc: vkoul@kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org, robh@kernel.org, neil.armstrong@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260812010157.1772849-4-marex@nabladev.com> References: <20260812010157.1772849-1-marex@nabladev.com> <20260812010157.1772849-4-marex@nabladev.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 12 Aug 2026 01:10:53 +0000 Message-Id: <20260812011053.7259F1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [Low] Incomplete schema update: `access-controllers` is added to EHCI but= omitted from the companion OHCI binding. -- --- Patch [3]: [PATCH 3/8] dt-bindings: usb: generic-ehci: Document access-= controllers property --- commit 5a4a63ad96f05ab82966f723bbb1698bcfb4356a Author: Marek Vasut dt-bindings: usb: generic-ehci: Document access-controllers property This commit adds the access-controllers property to the generic EHCI USB controller device tree binding schema. This allows access checks to be documented for these controllers. > diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Do= cumentation/devicetree/bindings/usb/generic-ehci.yaml > index 55a5aa7d7a54e..602241887d995 100644 > --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml > +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml > @@ -80,6 +80,9 @@ properties: > minItems: 1 > maxItems: 2 > =20 > + access-controllers: > + maxItems: 1 > + [Severity: Low] Does this property also need to be added to the generic OHCI binding (generic-ohci.yaml) or a common schema like usb-hcd.yaml? If a device tree configures both an EHCI controller and its companion OHCI controller behind an access controller, the OHCI node might fail dt_binding_check validation because generic-ohci.yaml enforces unevaluatedProperties: false. > dma-coherent: true --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260812010157.1772= 849-1-marex@nabladev.com?part=3D3