Re: [PATCH v3 3/6] dt-bindings: usb: add Altera Agilex5 DWC3 controller

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing generic fallback compatible string in DWC3 devicetree binding
--

--- Patch [3]: [PATCH v3 3/6] dt-bindings: usb: add Altera Agilex5 DWC3 controller ---
commit 1039f7f38ac48bd8193ef808b132fbeb99505e18
Author: Adrian Ng Ho Yin <adrian.ho.yin.ng@altera.com>

dt-bindings: usb: add Altera Agilex5 DWC3 controller

This commit adds a devicetree binding for the Altera Agilex5 SoC integration
of the Synopsys DWC3 USB controller.

> diff --git a/Documentation/devicetree/bindings/usb/altr,agilex5-dwc3.yaml b/Documentation/devicetree/bindings/usb/altr,agilex5-dwc3.yaml
> new file mode 100644
> index 0000000000000..8a815e8a3b7d1
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/usb/altr,agilex5-dwc3.yaml
> @@ -0,0 +1,102 @@

[ ... ]

> +properties:
> +  compatible:
> +    const: altr,agilex5-dwc3

[Severity: Medium]
Does the compatible property definition need to include the generic
fallback string "snps,dwc3"?

Since this is rigidly constrained as a const, providing the generic fallback
string in a devicetree node will cause schema validation to fail. 

If a device tree node only uses "altr,agilex5-dwc3" to satisfy this schema,
the generic DWC3 driver (drivers/usb/dwc3/core.c) will ignore the device
because it requires "snps,dwc3" or "synopsys,dwc3".

Should this be structured to allow an array of items including the fallback?

> +
> +  reg:
> +    description: DWC3 USB3 controller register region.
> +    maxItems: 1

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1786518803.git.adrian.ho.yin.ng@altera.com?part=3