From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: "Masami Hiramatsu (Google)" <mhiramat@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Shuah Khan <skhan@linuxfoundation.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org
Subject: Re: [PATCH v2 1/4] selftests/ftrace: Add generic boot tracing test framework
Date: Wed, 12 Aug 2026 09:05:05 +0900 [thread overview]
Message-ID: <20260812090505.4ceb89ac14a93c56c352ad8f@kernel.org> (raw)
In-Reply-To: <178646246740.428104.1537952219449559438.stgit@devnote2>
On Wed, 12 Aug 2026 00:34:27 +0900
"Masami Hiramatsu (Google)" <mhiramat@kernel.org> wrote:
> From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
> +# Verify busybox architecture compatibility
> +if command -v file >/dev/null 2>&1; then
> + BUSYBOX_INFO="$(file -b "$BUSYBOX" 2>/dev/null || true)"
Sashiko pointed:
>
> Will this check skip the tests incorrectly if the busybox binary is a symbolic
> link?
> The file command is invoked without the -L (dereference) flag. If the provided
> busybox path is a symbolic link, the file command will output "symbolic link
> to..." rather than the actual executable architecture. This causes it to fall
> through the case statement below and incorrectly skip the test suite on
> supported architectures.
> Could this use file -bL instead?
Yeah, I forgot that case. Let me fix it.
Thanks,
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2026-08-12 0:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 15:34 [PATCH v2 0/4] selftests/ftrace: Add a boottime tracing test framework Masami Hiramatsu (Google)
2026-08-11 15:34 ` [PATCH v2 1/4] selftests/ftrace: Add generic boot " Masami Hiramatsu (Google)
2026-08-12 0:05 ` Masami Hiramatsu [this message]
2026-08-11 15:34 ` [PATCH v2 2/4] selftests/ftrace: Add boot-time tracing testcases Masami Hiramatsu (Google)
2026-08-11 15:34 ` [PATCH v2 3/4] selftests/ftrace: Add kernel cmdline " Masami Hiramatsu (Google)
2026-08-11 23:39 ` Masami Hiramatsu
2026-08-11 15:34 ` [PATCH v2 4/4] selftests/ftrace: Add persistent ring buffer testcases Masami Hiramatsu (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812090505.4ceb89ac14a93c56c352ad8f@kernel.org \
--to=mhiramat@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=rostedt@goodmis.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.