From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5594641B37D for ; Wed, 12 Aug 2026 09:51:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786528279; cv=none; b=G6JqyYOOQ2+qX5DRwDMVXJSoUvRLDHX04B+sXqOsUo1IdBJQMOwvQqHpFFUVFUYd9fxcpmcm0l5IBc/6tVxmjiIrJAY8ZutJGlmFeJ3Ie1HmSlf4bZe9ELeVePRO8g4Q/hW1edfcvlAfrbSGo9DLK6AtMkSDVkHUr8cOnnEci9o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786528279; c=relaxed/simple; bh=3WSdP+d4/UJzoHWkDojZ12Lv9qdHyBoVLGbCmKY/Cc4=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=NwZp19GH6aAl+axia/wQCKJMvfgjA6lO5CbZz/RFmFehg1UJX9eaOGzHuf9Pd64LVriQ64dTTaVTqcItIAlSWwaLVUsD1p5yiFVVa8rI9dNDiuIgzxtkB3Pw8WLWc/toYBlbecThpXcoYfXBaQ6d/iH+GBT3LjN7zjKDDH8y16g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=VN3+mus5; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VN3+mus5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50DFF1F000E9; Wed, 12 Aug 2026 09:51:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786528277; bh=if0Csk/A9EcSIrsPRD2aB9x/Gl9MgImspW6Oz99kkVA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VN3+mus54DvmqRwFNmi5e+6EB4tukUNkrFMGMJU8Lj+D0C+uK5TP354mj+a1B+dkN gCsgTFvGs6Lqs+9d1cJ71xcubdfFURt24Jn32Fw17KkJS1kbkKfmw7NL7PIoKwos3Y hWMGNTXmHU6AM/4OUBtnVjNui0lVTpps4RRcu/ic4KY+487W1lbbN858CC8SYw/5SD EkAqMM7hNjk8B7azASHUrFAEAqRew7eB/yHmhWQLrawZzHLgU8Mm5asdVIGKPWFz4U 7TQ6dXHY5rv3LdupggZD15euBSnx+x/VyClMKoBhQyLyw8ULLfmxgQ0LlEGCp92lhV B3d237hguigJA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 03/14] arm64: dts: qcom: ipq5018: Add USB Super-Speed PHY node Reply-To: sashiko-reviews@lists.linux.dev To: "George Moussalem" Cc: linux-phy@lists.infradead.org, vkoul@kernel.org, olteanv@gmail.com, neil.armstrong@linaro.org, robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260812-ipq5018-usb3-v2-3-8f355d7ff0ef@outlook.com> References: <20260812-ipq5018-usb3-v2-0-8f355d7ff0ef@outlook.com> <20260812-ipq5018-usb3-v2-3-8f355d7ff0ef@outlook.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 12 Aug 2026 09:51:16 +0000 Message-Id: <20260812095117.50DFF1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: - [High] Missing `platform_set_drvdata()` in the PHY driver probe function = leads to a NULL pointer dereference on driver removal. -- --- Patch [3]: [PATCH v2 03/14] arm64: dts: qcom: ipq5018: Add USB Super-Sp= eed PHY node --- commit 97eadd80983348dbdd8dbea710c772858c61ccf6 Author: George Moussalem arm64: dts: qcom: ipq5018: Add USB Super-Speed PHY node Add USB Super-Speed UNIPHY node and populate the USB DT clock on the GCC node for the GCC to gate the PIPE clock supplied by the USB3 PHY. > diff --git a/arch/arm64/boot/dts/qcom/ipq5018.dtsi b/arch/arm64/boot/dts/= qcom/ipq5018.dtsi > --- a/arch/arm64/boot/dts/qcom/ipq5018.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5018.dtsi > @@ -179,6 +179,23 @@ usbphy0: phy@5b000 { > status =3D "disabled"; > }; > =20 > + usbphy1: phy@5d000 { > + compatible =3D "qcom,ipq5018-uniphy-usb-ss-phy"; [Severity: High] Does enabling this PHY expose a NULL pointer dereference in the driver upon removal? Looking at the driver for this PHY in drivers/phy/qualcomm/phy-qcom-uniphy-usb-ss-22ull.c, the qcom_uniphy_usb_probe() function allocates the uniphy state but fails to sa= ve it to the platform device: drivers/phy/qualcomm/phy-qcom-uniphy-usb-ss-22ull.c:qcom_uniphy_usb_probe()= { ... phy_set_drvdata(uniphy->phy, uniphy); phy_provider =3D devm_of_phy_provider_register(dev, of_phy_simple_xlate); ... } When the driver is unbound, qcom_uniphy_usb_remove() retrieves a NULL point= er: drivers/phy/qualcomm/phy-qcom-uniphy-usb-ss-22ull.c:qcom_uniphy_usb_remove(= ) { struct uniphy_usb *uniphy =3D platform_get_drvdata(pdev); qcom_uniphy_usb_mux_select(uniphy, false); } This NULL pointer is then passed to qcom_uniphy_usb_mux_select(), causing a crash. Should a fix adding platform_set_drvdata(pdev, uniphy) be included to preve= nt unbinding this device from causing a kernel oops? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260812-ipq5018-us= b3-v2-0-8f355d7ff0ef@outlook.com?part=3D3 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 549DFC5AD5A for ; Wed, 12 Aug 2026 09:51:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LwrS/v/ZcZwd0uWlctJkx2dk5TtiRZztlrd/obFGiqY=; b=tEmlEAp2N9c7qf PPY3UDJB6ZGXUVYX2iCE5fQVcs5W3KtkxNqU5H+02MrllQCgeDqpO9t75NTEcwS6KJ68KtGqVDGXf a0Jj5Bi9iWqLzXpjT3QoK2L9WJ4tiNCLEtmjtFfE3Y4RbgA2482l23UE99nHTVT5M4hwFQmlSVUH6 bAxb5v24JQLUImb+SREZtTqTv3j2B/Ox9vghoqj8PBDm79yddMrmgx8suUQ3K52XB2OX8a7Y9DJa7 AfAe7wKpV3p+pgH5iUSj/yOeKLmP2aMEexGTeFzkJ88XFDk4+zGl7+gWSyhpoMQVuaDCzS4W3PkKJ wOxuvNpwR6BQu7rQMZIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wu5cH-0000000Focq-48Cr; Wed, 12 Aug 2026 09:51:22 +0000 Received: from sea.source.kernel.org ([172.234.252.31]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wu5cE-0000000FocS-2MN1 for linux-phy@lists.infradead.org; Wed, 12 Aug 2026 09:51:19 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 0F678405C3; Wed, 12 Aug 2026 09:51:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 50DFF1F000E9; Wed, 12 Aug 2026 09:51:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786528277; bh=if0Csk/A9EcSIrsPRD2aB9x/Gl9MgImspW6Oz99kkVA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=VN3+mus54DvmqRwFNmi5e+6EB4tukUNkrFMGMJU8Lj+D0C+uK5TP354mj+a1B+dkN gCsgTFvGs6Lqs+9d1cJ71xcubdfFURt24Jn32Fw17KkJS1kbkKfmw7NL7PIoKwos3Y hWMGNTXmHU6AM/4OUBtnVjNui0lVTpps4RRcu/ic4KY+487W1lbbN858CC8SYw/5SD EkAqMM7hNjk8B7azASHUrFAEAqRew7eB/yHmhWQLrawZzHLgU8Mm5asdVIGKPWFz4U 7TQ6dXHY5rv3LdupggZD15euBSnx+x/VyClMKoBhQyLyw8ULLfmxgQ0LlEGCp92lhV B3d237hguigJA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v2 03/14] arm64: dts: qcom: ipq5018: Add USB Super-Speed PHY node To: "George Moussalem" Cc: linux-phy@lists.infradead.org, vkoul@kernel.org, olteanv@gmail.com, neil.armstrong@linaro.org, robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20260812-ipq5018-usb3-v2-3-8f355d7ff0ef@outlook.com> References: <20260812-ipq5018-usb3-v2-0-8f355d7ff0ef@outlook.com> <20260812-ipq5018-usb3-v2-3-8f355d7ff0ef@outlook.com> Date: Wed, 12 Aug 2026 09:51:16 +0000 Message-Id: <20260812095117.50DFF1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6Ci0gW0hpZ2hdIE1pc3NpbmcgYHBsYXRm b3JtX3NldF9kcnZkYXRhKClgIGluIHRoZSBQSFkgZHJpdmVyIHByb2JlIGZ1bmN0aW9uIGxlYWRz IHRvIGEgTlVMTCBwb2ludGVyIGRlcmVmZXJlbmNlIG9uIGRyaXZlciByZW1vdmFsLgotLQoKLS0t IFBhdGNoIFszXTogW1BBVENIIHYyIDAzLzE0XSBhcm02NDogZHRzOiBxY29tOiBpcHE1MDE4OiBB ZGQgVVNCIFN1cGVyLVNwZWVkIFBIWSBub2RlIC0tLQpjb21taXQgOTdlYWRkODA5ODMzNDhkYmRk OGRiZWE3MTBjNzcyODU4YzYxY2NmNgpBdXRob3I6IEdlb3JnZSBNb3Vzc2FsZW0gPGdlb3JnZS5t b3Vzc2FsZW1Ab3V0bG9vay5jb20+Cgphcm02NDogZHRzOiBxY29tOiBpcHE1MDE4OiBBZGQgVVNC IFN1cGVyLVNwZWVkIFBIWSBub2RlCgpBZGQgVVNCIFN1cGVyLVNwZWVkIFVOSVBIWSBub2RlIGFu ZCBwb3B1bGF0ZSB0aGUgVVNCIERUIGNsb2NrIG9uIHRoZSBHQ0MKbm9kZSBmb3IgdGhlIEdDQyB0 byBnYXRlIHRoZSBQSVBFIGNsb2NrIHN1cHBsaWVkIGJ5IHRoZSBVU0IzIFBIWS4KCj4gZGlmZiAt LWdpdCBhL2FyY2gvYXJtNjQvYm9vdC9kdHMvcWNvbS9pcHE1MDE4LmR0c2kgYi9hcmNoL2FybTY0 L2Jvb3QvZHRzL3Fjb20vaXBxNTAxOC5kdHNpCj4gLS0tIGEvYXJjaC9hcm02NC9ib290L2R0cy9x Y29tL2lwcTUwMTguZHRzaQo+ICsrKyBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcWNvbS9pcHE1MDE4 LmR0c2kKPiBAQCAtMTc5LDYgKzE3OSwyMyBAQCB1c2JwaHkwOiBwaHlANWIwMDAgewo+ICAJCQlz dGF0dXMgPSAiZGlzYWJsZWQiOwo+ICAJCX07Cj4gIAo+ICsJCXVzYnBoeTE6IHBoeUA1ZDAwMCB7 Cj4gKwkJCWNvbXBhdGlibGUgPSAicWNvbSxpcHE1MDE4LXVuaXBoeS11c2Itc3MtcGh5IjsKCltT ZXZlcml0eTogSGlnaF0KRG9lcyBlbmFibGluZyB0aGlzIFBIWSBleHBvc2UgYSBOVUxMIHBvaW50 ZXIgZGVyZWZlcmVuY2UgaW4gdGhlIGRyaXZlciB1cG9uCnJlbW92YWw/CgpMb29raW5nIGF0IHRo ZSBkcml2ZXIgZm9yIHRoaXMgUEhZIGluCmRyaXZlcnMvcGh5L3F1YWxjb21tL3BoeS1xY29tLXVu aXBoeS11c2Itc3MtMjJ1bGwuYywgdGhlCnFjb21fdW5pcGh5X3VzYl9wcm9iZSgpIGZ1bmN0aW9u IGFsbG9jYXRlcyB0aGUgdW5pcGh5IHN0YXRlIGJ1dCBmYWlscyB0byBzYXZlCml0IHRvIHRoZSBw bGF0Zm9ybSBkZXZpY2U6Cgpkcml2ZXJzL3BoeS9xdWFsY29tbS9waHktcWNvbS11bmlwaHktdXNi LXNzLTIydWxsLmM6cWNvbV91bmlwaHlfdXNiX3Byb2JlKCkgewogICAgLi4uCglwaHlfc2V0X2Ry dmRhdGEodW5pcGh5LT5waHksIHVuaXBoeSk7CgoJcGh5X3Byb3ZpZGVyID0gZGV2bV9vZl9waHlf cHJvdmlkZXJfcmVnaXN0ZXIoZGV2LCBvZl9waHlfc2ltcGxlX3hsYXRlKTsKICAgIC4uLgp9CgpX aGVuIHRoZSBkcml2ZXIgaXMgdW5ib3VuZCwgcWNvbV91bmlwaHlfdXNiX3JlbW92ZSgpIHJldHJp ZXZlcyBhIE5VTEwgcG9pbnRlcjoKCmRyaXZlcnMvcGh5L3F1YWxjb21tL3BoeS1xY29tLXVuaXBo eS11c2Itc3MtMjJ1bGwuYzpxY29tX3VuaXBoeV91c2JfcmVtb3ZlKCkgewoJc3RydWN0IHVuaXBo eV91c2IgKnVuaXBoeSA9IHBsYXRmb3JtX2dldF9kcnZkYXRhKHBkZXYpOwoKCXFjb21fdW5pcGh5 X3VzYl9tdXhfc2VsZWN0KHVuaXBoeSwgZmFsc2UpOwp9CgpUaGlzIE5VTEwgcG9pbnRlciBpcyB0 aGVuIHBhc3NlZCB0byBxY29tX3VuaXBoeV91c2JfbXV4X3NlbGVjdCgpLCBjYXVzaW5nIGEKY3Jh c2guCgpTaG91bGQgYSBmaXggYWRkaW5nIHBsYXRmb3JtX3NldF9kcnZkYXRhKHBkZXYsIHVuaXBo eSkgYmUgaW5jbHVkZWQgdG8gcHJldmVudAp1bmJpbmRpbmcgdGhpcyBkZXZpY2UgZnJvbSBjYXVz aW5nIGEga2VybmVsIG9vcHM/CgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNo aWtvLmRldi8jL3BhdGNoc2V0LzIwMjYwODEyLWlwcTUwMTgtdXNiMy12Mi0wLThmMzU1ZDdmZjBl ZkBvdXRsb29rLmNvbT9wYXJ0PTMKCi0tIApsaW51eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBo eUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LXBoeQo=