Re: [PATCH] cachefiles,netfs: sunset ondemand mode

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Complete removal of the UAPI header include/uapi/linux/cachefiles.h breaks userspace compilation.
--

--- Patch [1]: [PATCH] cachefiles,netfs: sunset ondemand mode ---
commit e5845e932fdde67ddaf43301939e4efa8d4c2a07
Author: Gao Xiang <xiang@kernel.org>

cachefiles,netfs: sunset ondemand mode

This commit removes the ondemand read mode from cachefiles. Since EROFS over
fscache is now removed and netfs has evolved, the ondemand mode is no longer
needed and is being cleaned up.

Link: https://lore.kernel.org/r/CAOQ4uxi4dzxArY24YO=+kBCK2gGoq3Ptb8WkzCqSogPgU_R3dQ@mail.gmail.com
Link: https://sashiko.dev/#/patchset/20260716103030.3065561-1-dhowells%40redhat.com
Link: https://sashiko.dev/#/patchset/20260722130218.78958-1-dhowells%40redhat.com

[ ... ]

> diff --git a/include/uapi/linux/cachefiles.h b/include/uapi/linux/cachefiles.h
> deleted file mode 100644
> index 78caa73e53434..0000000000000
> --- a/include/uapi/linux/cachefiles.h
> +++ /dev/null
> @@ -1,68 +0,0 @@
> -/* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
> -#ifndef _LINUX_CACHEFILES_H
> -#define _LINUX_CACHEFILES_H

[Severity: High]
Does this complete removal of the UAPI header break userspace compilation?

Even when a kernel feature is sunset and its runtime support is removed,
standard Linux kernel policy is to retain the UAPI headers (or leave them
as stubs) to avoid breaking userspace source compilation. Any existing
userspace applications (such as ondemand cachefiles daemons) that include
linux/cachefiles.h will fail to build against the updated kernel headers.

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/1046393.1786544127@warthog.procyon.org.uk?part=1