From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AC76A372B2B for ; Wed, 12 Aug 2026 15:07:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786547267; cv=none; b=ZNuOWRMAVyXJHayUXC3LFEzIdU6oCLHq3Xy4eTGUyr02emD79vxJ77uabCnMaDQUSc7bdm5WRK04f3c+wnPRnqH2OpF+kLxOW/Ci/6gwOz1LHShfSMKKDZJMJUw3AI5mSKqKjXaIWEW2YGf6dzZyfS/ldibfuVeK3tJVNIspBks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786547267; c=relaxed/simple; bh=cX2wDQYv6mT7BAjeKb9lsL+UDEuyxmXrUrfkbFSInRs=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=EmdBTT8yIyHxKpiaNDYKj2vmRollE220XawLnlL8ETMjtHT6EEn4txjqlJhIlApFj7PNBCcrKYIPn/j5P7BxMBBpZFDg7SWDdyayRYvfE+CPigIVA9izTk2NFMK8FHITyODMxIM2Bpy3QN3WmOhM/Lcru+flyHS9jLD79wvIj9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Ch9dJ1eB; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Ch9dJ1eB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1786547252; bh=cX2wDQYv6mT7BAjeKb9lsL+UDEuyxmXrUrfkbFSInRs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Ch9dJ1eBnSRYQCF791REJhtbEOgpwElyF087klIxYLZFj+YWGxraW97VahK+FvKdv C0pDQ5G9dPQZkJMScnDXfpBa5+KmfgXYzu6nrgRTss8EPhoPEsCcH5y4P3ss5aIupj l9DQJ400m2CauBvsHL1ikBFdFrJKn6jJZnQTfY+/kH2f1YS9AX29AL27usRJovmJXb Yu+CltXb2/CrwGOFvJAIBCDFOmBKxZNinmMJdAfNsCqGsOUkYuedYBzYMjewyCButO Iffmo2CbMgFuC2lcYZb1jTa2SUXWsbH5Ty//fXN5PL1a/TQEgB9SduF2bbFq0DCq4J FL6P9ceTvHEhg== Received: from fedora-21.home (unknown [100.64.0.11]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange secp256r1 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: bbrezillon) by bali.collaboradmins.com (Postfix) with ESMTPSA id 295A317E0D7E; Wed, 12 Aug 2026 17:07:32 +0200 (CEST) Date: Wed, 12 Aug 2026 17:07:26 +0200 From: Boris Brezillon To: Nicolas Frattaroli Cc: Steven Price , Liviu Dudau , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Grant Likely , Heiko Stuebner , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, kernel@collabora.com Subject: Re: [PATCH v4 1/3] drm/panthor: Add tracepoint for cache flushing Message-ID: <20260812170726.15d46854@fedora-21.home> In-Reply-To: <20260812-panthor-cache-flush-fix-v4-1-751e32901898@collabora.com> References: <20260812-panthor-cache-flush-fix-v4-0-751e32901898@collabora.com> <20260812-panthor-cache-flush-fix-v4-1-751e32901898@collabora.com> Organization: Collabora X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 12 Aug 2026 16:07:18 +0200 Nicolas Frattaroli wrote: > Add a new event tracepoint: gpu_cache_flush to be emitted after a GPU > cache flush completes, with duration and return status arguments. > > This allows debugging the duration a flush takes irrespective of initial > function entry lock contention, and communicates information about > whether the flush timed out or errored out in other ways, and which > caches were flushed. > > Signed-off-by: Nicolas Frattaroli Reviewed-by: Boris Brezillon > --- > drivers/gpu/drm/panthor/panthor_gpu.c | 26 +++++++++++++++++++++- > drivers/gpu/drm/panthor/panthor_trace.h | 38 +++++++++++++++++++++++++++++++++ > 2 files changed, 63 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panthor/panthor_gpu.c b/drivers/gpu/drm/panthor/panthor_gpu.c > index c013d6bf9a59..7088371c6d64 100644 > --- a/drivers/gpu/drm/panthor/panthor_gpu.c > +++ b/drivers/gpu/drm/panthor/panthor_gpu.c > @@ -317,6 +317,21 @@ int panthor_gpu_l2_power_on(struct panthor_device *ptdev) > return panthor_gpu_power_on(ptdev, L2, 1, 20000); > } > > +static inline void panthor_gpu_emit_flush_caches_tp(struct panthor_device *ptdev, > + u64 start, u32 l2, u32 lsc, > + u32 other, int ret) > +{ > + u32 duration; > + > + if (!tracepoint_enabled(gpu_cache_flush) || !start) > + return; > + > + if (check_sub_overflow(ktime_get_ns(), start, &duration)) > + duration = U32_MAX; > + > + trace_gpu_cache_flush(ptdev->base.dev, l2, lsc, other, duration, ret); > +} > + > /** > * panthor_gpu_flush_caches() - Flush caches > * @ptdev: Device. > @@ -331,12 +346,17 @@ int panthor_gpu_flush_caches(struct panthor_device *ptdev, > { > struct panthor_gpu *gpu = ptdev->gpu; > unsigned long flags; > + u64 start = 0; > int ret = 0; > > /* Serialize cache flush operations. */ > guard(mutex)(&ptdev->gpu->cache_flush_lock); > > spin_lock_irqsave(&ptdev->gpu->reqs_lock, flags); > + > + if (tracepoint_enabled(gpu_cache_flush)) > + start = ktime_get_ns(); > + > if (!(ptdev->gpu->pending_reqs & GPU_IRQ_CLEAN_CACHES_COMPLETED)) { > ptdev->gpu->pending_reqs |= GPU_IRQ_CLEAN_CACHES_COMPLETED; > gpu_write(gpu->iomem, GPU_CMD, GPU_FLUSH_CACHES(l2, lsc, other)); > @@ -345,8 +365,10 @@ int panthor_gpu_flush_caches(struct panthor_device *ptdev, > } > spin_unlock_irqrestore(&ptdev->gpu->reqs_lock, flags); > > - if (ret) > + if (ret) { > + panthor_gpu_emit_flush_caches_tp(ptdev, start, l2, lsc, other, ret); > return ret; > + } > > if (!wait_event_timeout(ptdev->gpu->reqs_acked, > !(ptdev->gpu->pending_reqs & GPU_IRQ_CLEAN_CACHES_COMPLETED), > @@ -360,6 +382,8 @@ int panthor_gpu_flush_caches(struct panthor_device *ptdev, > spin_unlock_irqrestore(&ptdev->gpu->reqs_lock, flags); > } > > + panthor_gpu_emit_flush_caches_tp(ptdev, start, l2, lsc, other, ret); > + > if (ret) { > panthor_device_schedule_reset(ptdev); > drm_err(&ptdev->base, "Flush caches timeout"); > diff --git a/drivers/gpu/drm/panthor/panthor_trace.h b/drivers/gpu/drm/panthor/panthor_trace.h > index 6ffeb4fe6599..bd8652549ab4 100644 > --- a/drivers/gpu/drm/panthor/panthor_trace.h > +++ b/drivers/gpu/drm/panthor/panthor_trace.h > @@ -76,6 +76,44 @@ TRACE_EVENT(gpu_job_irq, > __entry->events, __entry->duration_ns) > ); > > +/** > + * gpu_cache_flush - emitted after cache flush completes > + * @dev: pointer to the &struct device, for printing the device name > + * @l2: "l2" flush flags > + * @lsc: "lsc" flush flags > + * @other: "other" flush flags > + * @duration_ns: how long the cache flush operation took, in nanoseconds > + * @ret: return status, 0 == success, negative errno on error > + * > + * Begins measuring after any initial lock contention around the locks needed > + * for flushing caches, but before the actual cache flush is requested. Stops > + * measuring and is emitted after flush operation is over. > + */ > +TRACE_EVENT(gpu_cache_flush, > + TP_PROTO(const struct device *dev, u32 l2, u32 lsc, u32 other, > + u32 duration_ns, int ret), > + TP_ARGS(dev, l2, lsc, other, duration_ns, ret), > + TP_STRUCT__entry( > + __string(dev_name, dev_name(dev)) > + __field(u32, l2) > + __field(u32, lsc) > + __field(u32, other) > + __field(u32, duration_ns) > + __field(int, ret) > + ), > + TP_fast_assign( > + __assign_str(dev_name); > + __entry->l2 = l2; > + __entry->lsc = lsc; > + __entry->other = other; > + __entry->duration_ns = duration_ns; > + __entry->ret = ret; > + ), > + TP_printk("%s: l2=0x%x lsc=0x%x other=0x%x duration_ns=%u ret=%d", > + __get_str(dev_name), __entry->l2, __entry->lsc, > + __entry->other, __entry->duration_ns, __entry->ret) > +); > + > #endif /* __PANTHOR_TRACE_H__ */ > > #undef TRACE_INCLUDE_PATH >