From: sashiko-bot@kernel.org
To: "Alex Elder" <elder@riscstar.com>
Cc: conor+dt@kernel.org, linux-pci@vger.kernel.org, robh@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/4] PCI: of: don't zero flags in of_pci_get_addr_flags()
Date: Wed, 12 Aug 2026 17:27:49 +0000 [thread overview]
Message-ID: <20260812172749.90C521F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260812172247.276554-3-elder@riscstar.com>
> The flags variable whose address is passed to of_pci_get_addr_flags()
> is zeroed before assigning a value to it. Skip the zeroing and just
> assign it instead.
>
> Reviewed-by: Herve Codina <herve.codina@bootlin.com>
> Signed-off-by: Alex Elder <elder@riscstar.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260812172247.276554-1-elder@riscstar.com?part=2
next prev parent reply other threads:[~2026-08-12 17:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 17:22 [PATCH v2 0/4] PCI: of: warn on bogus device_type property Alex Elder
2026-08-12 17:22 ` [PATCH v2 1/4] PCI: of: drop the reg_num argument to of_pci_set_address() Alex Elder
2026-08-12 17:28 ` sashiko-bot
2026-08-12 17:22 ` [PATCH v2 2/4] PCI: of: don't zero flags in of_pci_get_addr_flags() Alex Elder
2026-08-12 17:27 ` sashiko-bot [this message]
2026-08-12 17:22 ` [PATCH v2 3/4] PCI: of: make a flags argument optional Alex Elder
2026-08-12 17:29 ` sashiko-bot
2026-08-12 17:22 ` [PATCH v2 4/4] PCI: of: introduce of_pci_verify_node() Alex Elder
2026-08-12 17:28 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812172749.90C521F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@riscstar.com \
--cc=linux-pci@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.