Re: [PATCH v5 05/13] s390: Use the common syscall table

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Truncation of the s390 syscall table breaks perf tooling synchronization and `perf trace` syscall resolution.
--

--- Patch [5]: [PATCH v5 05/13] s390: Use the common syscall table ---
commit 14ffb6f547173922da170d7387b0125457d5de1c
Author: André Almeida <andrealmeid@igalia.com>

s390: Use the common syscall table

This commit removes duplicated syscall entries from the s390 syscall table by
falling back to the common syscall number table.

> diff --git a/arch/s390/kernel/syscalls/syscall.tbl b/arch/s390/kernel/syscalls/syscall.tbl
> index 09a7ef04d9791..ce6d15260dd1b 100644
> --- a/arch/s390/kernel/syscalls/syscall.tbl
> +++ b/arch/s390/kernel/syscalls/syscall.tbl
[ ... ]
> @@ -350,51 +350,3 @@
>  400	common	msgsnd				sys_msgsnd
>  401	common	msgrcv				sys_msgrcv
>  402	common	msgctl				sys_msgctl
> -424	common	pidfd_send_signal		sys_pidfd_send_signal
> -425	common	io_uring_setup			sys_io_uring_setup

[Severity: Medium]
Will truncating these syscalls from the s390 table break perf tooling when
the tables are synchronized?

Currently, tools/perf/trace/beauty/syscalltbl.sh relies on the arch-specific
table to generate its syscall resolution. Because that script hasn't been
updated to parse scripts/syscall_common.tbl, it looks like a subsequent sync
of this file into the tools/perf tree will cause perf trace to silently lose
the ability to resolve syscalls 424 and above on s390.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260812-tonyk-syscall_table-v5-0-3d383927c609@igalia.com?part=5