From: sashiko-bot@kernel.org
To: "Bhargav Joshi" <j.bhargav.u@gmail.com>
Cc: devicetree@vger.kernel.org, conor+dt@kernel.org, robh@kernel.org,
media-ci@linuxtv.org
Subject: Re: [PATCH] media: dt-bindings: ti,da850-vpif: Convert to dt-schema
Date: Wed, 12 Aug 2026 23:23:35 +0000 [thread overview]
Message-ID: <20260812232335.DF0A11F000E9@smtp.kernel.org> (raw)
In-Reply-To: <20260813-ti-da850-vpif-v1-1-7779b1e4d6af@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] Incomplete device tree binding conversion: the old text binding file was not removed.
--
--- Patch [1]: [PATCH] media: dt-bindings: ti,da850-vpif: Convert to dt-schema ---
commit 74502dfb55363f0cb7f1ff05a7d4febcf64ff608
Author: Bhargav Joshi <j.bhargav.u@gmail.com>
media: dt-bindings: ti,da850-vpif: Convert to dt-schema
This commit introduces a new YAML device tree schema for the TI DA850/AM18x
VPIF, intended to replace the legacy text binding. It also adds a missing
power-domains property to the schema.
> Convert the Texas Instruments DA850/AM18x Video Port Interface (VPIF)
> device tree binding from text format to YAML dt-schema.
[Severity: Low]
Does this patch miss removing the original text binding file?
The commit message indicates a conversion from text format to YAML schema, but
the patch only adds the new ti,da850-vpif.yaml file and does not remove
Documentation/devicetree/bindings/media/ti,da850-vpif.txt.
Should the legacy text file be deleted in this patch to prevent duplicate
documentation in the tree?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260813-ti-da850-vpif-v1-1-7779b1e4d6af@gmail.com?part=1
prev parent reply other threads:[~2026-08-12 23:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-12 23:15 [PATCH] media: dt-bindings: ti,da850-vpif: Convert to dt-schema Bhargav Joshi
2026-08-12 23:23 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260812232335.DF0A11F000E9@smtp.kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j.bhargav.u@gmail.com \
--cc=media-ci@linuxtv.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.