Re: [PATCH] dt-bindings: power: reset: ti,keystone-reset: Convert to DT schema

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The 'reg' property is newly marked as strictly required in the schema, which breaks backward compatibility with existing out-of-tree device trees.
--

--- Patch [1]: [PATCH] dt-bindings: power: reset: ti,keystone-reset: Convert to DT schema ---
commit 63d9431256b9847ef3ca6d5aacac09610df2a267
Author: Bhargav Joshi <j.bhargav.u@gmail.com>

dt-bindings: power: reset: ti,keystone-reset: Convert to DT schema

This commit converts the Texas Instruments Keystone SoC Reset Controller
binding from a text document to a DT schema. The commit message notes
there are no new functional changes.

> diff --git a/Documentation/devicetree/bindings/power/reset/ti,keystone-reset.yaml b/Documentation/devicetree/bindings/power/reset/ti,keystone-reset.yaml
> new file mode 100644
> index 0000000000000..ecc68d37f07e0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/reset/ti,keystone-reset.yaml

[ ... ]

> +required:
> +  - compatible
> +  - reg

[Severity: Medium]
Does adding 'reg' to the required list break backward compatibility with
existing device trees?

The old text binding did not document or include a 'reg' property in its
examples, meaning existing device trees following the old binding will now
fail validation during `make dtbs_check` with this new schema. Since the
kernel driver does not parse or map the 'reg' property and relies on syscon
offsets instead, is it necessary to mark 'reg' as strictly required here?

> +  - ti,syscon-pll
> +  - ti,syscon-dev
> +
> +additionalProperties: false

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260813-ti-keystone-reset-v1-1-189389503324@gmail.com?part=1