All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Conor Dooley <conor+lkp@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [conor:tvs 3/5] drivers/hwmon/tvs-mpfs.c:266:2-3: Unneeded semicolon
Date: Thu, 13 Aug 2026 01:03:16 +0800	[thread overview]
Message-ID: <202608130032.EGmlagz3-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/conor/linux.git tvs
head:   89556bbdc65141c9062cd1bfe255b48c96fb9e8b
commit: 691d6378025fb2fcf003b98e2094c97ba617272b [3/5] hwmon: (mpfs) add workaround for interrupt erratum
config: arm-randconfig-r052-20260812 (https://download.01.org/0day-ci/archive/20260813/202608130032.EGmlagz3-lkp@intel.com/config)
compiler: clang version 21.1.8 (https://github.com/llvm/llvm-project 2078da43e25a4623cab2d0d60decddf709aaea28)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608130032.EGmlagz3-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/hwmon/tvs-mpfs.c:266:2-3: Unneeded semicolon

vim +266 drivers/hwmon/tvs-mpfs.c

   219	
   220	static int mpfs_tvs_temp_write(struct mpfs_tvs *data, u32 attr, long val)
   221	{
   222		u32 tmp;
   223		int temp;
   224	
   225		switch(attr) {
   226		case hwmon_temp_enable:
   227			if (val > 1 || val < 0)
   228				return -EINVAL;
   229	
   230			tmp = FIELD_PREP(MPFS_TVS_CTRL_TEMP_ENABLE, val);
   231			regmap_update_bits(data->regmap, MPFS_TVS_CTRL,
   232					   MPFS_TVS_CTRL_TEMP_ENABLE, tmp);
   233			break;
   234		case hwmon_temp_max:
   235			if (val < -273)
   236				return -EINVAL;
   237	
   238			temp = val << 4;
   239			temp /= 1000;
   240			temp += MPFS_TVS_K_TO_C;
   241	
   242			if (temp > GENMASK(14, 0))
   243				return -EINVAL;
   244	
   245			tmp = FIELD_PREP(MPFS_TRIGGER_MAX_MASK, temp);
   246			regmap_update_bits(data->regmap, MPFS_TVS_TRIGGER,
   247					   MPFS_TRIGGER_MAX_MASK, tmp);
   248			break;
   249		case hwmon_temp_min:
   250			if (val < -273)
   251				return -EINVAL;
   252	
   253			temp = val << 4;
   254			temp /= 1000;
   255			temp += MPFS_TVS_K_TO_C;
   256	
   257			if (temp > GENMASK(14, 0))
   258				return -EINVAL;
   259	
   260			tmp = FIELD_PREP(MPFS_TRIGGER_MIN_MASK, temp);
   261			regmap_update_bits(data->regmap, MPFS_TVS_TRIGGER,
   262					   MPFS_TRIGGER_MIN_MASK, tmp);
   263			break;
   264		default:
   265			return EOPNOTSUPP;
 > 266		};
   267	
   268		return 0;
   269	}
   270	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-08-12 17:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202608130032.EGmlagz3-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=conor+lkp@kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.