Re: [LTP] pmc_core: add test for pkgc_blocker_residency_show

[linuxtestproject.agent@gmail.com]

Hi Piotr,

On Thu, 13 Aug 2026, Piotr Kubaj wrote:
> pmc_core: add test for pkgc_blocker_residency_show

> +static void setup(void)
> +{
> +	if (access(DEBUGFS, F_OK))
> +		tst_brk(TCONF | TERRNO, "debugfs not mounted at " DEBUGFS);
> +
> +	if (access(PATH, R_OK))
> +		tst_brk(TCONF | TERRNO, "%s not available", PATH);
> +}

Could the test mount debugfs when it is not already mounted, and unmount only
a test-created mount in cleanup?

On a supported Nova Lake system with debugfs unmounted,
/sys/kernel/debug still exists as the mount-point directory. The first
check therefore succeeds, and the missing counter path makes the test report
TCONF without testing the supported interface.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp