From: Simon Horman <horms@kernel.org>
To: Emil Tantilov <emil.s.tantilov@intel.com>
Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,
andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, joshua.a.hay@intel.com
Subject: Re: [Intel-wired-lan] [PATCH iwl-net] idpf: fix possible race on remove during a reset
Date: Thu, 13 Aug 2026 14:41:08 +0100 [thread overview]
Message-ID: <20260813134108.GC265046@horms.kernel.org> (raw)
In-Reply-To: <20260811171751.22165-1-emil.s.tantilov@intel.com>
On Tue, Aug 11, 2026 at 10:17:51AM -0700, Emil Tantilov wrote:
> Reset and remove can race, leaving NAPI registered and enabled:
>
> modprobe idpf& sleep 1; ip link set eth0 up& rmmod idpf
>
> [145561.805104] WARNING: net/core/dev.c:7699 at __netif_napi_del_locked+0x11a/0x130, CPU#30: rmmod/22393
> ...
> [145561.810238] RIP: 0010:__netif_napi_del_locked+0x11a/0x130
> ...
> [145561.817678] Call Trace:
> [145561.818125] <TASK>
> [145561.818653] free_netdev+0x110/0x2a0
> [145561.819109] idpf_vport_dealloc+0x452/0x460 [idpf]
> [145561.819668] ? enable_work+0x9f/0x100
> [145561.820133] idpf_deinit_task+0x51/0x70 [idpf]
> [145561.820694] idpf_vc_core_deinit+0x32/0x170 [idpf]
> [145561.821193] idpf_remove+0x40/0x200 [idpf]
> [145561.821667] pci_device_remove+0x40/0xa0
> [145561.822132] device_release_driver_internal+0x1a9/0x210
> [145561.822691] driver_detach+0x4b/0x90
> [145561.823161] bus_remove_driver+0x70/0x100
> [145561.823721] pci_unregister_driver+0x2e/0xb0
> [145561.824207] __do_sys_delete_module.constprop.0+0x190/0x2e0
> [145561.824715] ? kmem_cache_free+0x312/0x550
> [145561.825213] do_syscall_64+0xc8/0x6b0
> [145561.825709] ? clear_bhb_loop+0x30/0x80
> [145561.826216] entry_SYSCALL_64_after_hwframe+0x76/0x7e
> [145561.826602] RIP: 0033:0x7fe628130beb
>
> Make sure to call idpf_vport_stop() in idpf_stop(), irrespective of the
> IDPF_REMOVE_IN_PROG state, to allow a reset racing with remove to tear
> down NAPI in idpf_detach_and_close(), which runs under RTNL lock.
>
> Fixes: 2e281e1155fc ("idpf: detach and close netdevs while handling a reset")
> Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
> Reviewed-by: Joshua Hay <joshua.a.hay@intel.com>
Reviewed-by: Simon Horman <horms@kernel.org>
prev parent reply other threads:[~2026-08-13 13:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-11 17:17 [Intel-wired-lan] [PATCH iwl-net] idpf: fix possible race on remove during a reset Emil Tantilov
2026-08-11 17:17 ` Emil Tantilov
2026-08-13 13:41 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813134108.GC265046@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=emil.s.tantilov@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=joshua.a.hay@intel.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.