From: Melissa Wen <mwen@igalia.com>
To: airlied@gmail.com, alexander.deucher@amd.com,
christian.koenig@amd.com, daniels@collabora.com,
harry.wentland@amd.com, leandro.ribeiro@collabora.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
pekka.paalanen@collabora.com, simona@ffwll.ch,
siqueira@igalia.com, sunpeng.li@amd.com, tzimmermann@suse.de
Cc: Alex Hung <alex.hung@amd.com>,
Daniel Wheeler <Daniel.Wheeler@amd.com>,
kernel-dev@igalia.com, Lyude Paul <lyude@redhat.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: [PATCH v3 1/3] drm/atomic-state-helper: set pixel_blend_mode to prop default on reset
Date: Thu, 13 Aug 2026 16:30:20 +0200 [thread overview]
Message-ID: <20260813143605.106104-2-mwen@igalia.com> (raw)
In-Reply-To: <20260813143605.106104-1-mwen@igalia.com>
In __drm_atomic_helper_plane_state_init(), pixel_blend_mode is always
reset to DRM_MODE_BLEND_PREMULTI. That was consistent while
drm_plane_create_blend_mode_property() required PREMULTI in the
supported modes, but it now falls back to COVERAGE or PIXEL_NONE when
the driver doesn't support PREMULTI. The hardcoded default may therefore
not be a blend mode the hardware can do, nor one the property
advertises.
Initialize pixel_blend_mode from the blend mode property default
instead, keeping DRM_MODE_BLEND_PREMULTI for planes without the
property.
Fixes: 9813e158d13d ("drm/drm_blend: allow blend mode property without PREMULTI")
Reviewed-by: Leandro Ribeiro <leandro.ribeiro@collabora.com>
Signed-off-by: Melissa Wen <mwen@igalia.com>
---
drivers/gpu/drm/drm_atomic_state_helper.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/drm_atomic_state_helper.c b/drivers/gpu/drm/drm_atomic_state_helper.c
index d90d1d7c9cf9..a2ef272e9f27 100644
--- a/drivers/gpu/drm/drm_atomic_state_helper.c
+++ b/drivers/gpu/drm/drm_atomic_state_helper.c
@@ -278,7 +278,14 @@ void __drm_atomic_helper_plane_state_init(struct drm_plane_state *plane_state,
plane_state->rotation = DRM_MODE_ROTATE_0;
plane_state->alpha = DRM_BLEND_ALPHA_OPAQUE;
+
plane_state->pixel_blend_mode = DRM_MODE_BLEND_PREMULTI;
+ if (plane->blend_mode_property) {
+ if (!drm_object_property_get_default_value(&plane->base,
+ plane->blend_mode_property,
+ &val))
+ plane_state->pixel_blend_mode = val;
+ }
if (plane->color_encoding_property) {
if (!drm_object_property_get_default_value(&plane->base,
--
2.53.0
next prev parent reply other threads:[~2026-08-13 14:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-13 14:30 [PATCH v3 0/3] drm/atomic-state-helper: fixes for blend-mode-prop warning Melissa Wen
2026-08-13 14:30 ` Melissa Wen [this message]
2026-08-13 14:30 ` [PATCH v3 2/3] drm/amd/display: fix missing blend-mode-prop warning for DCN Melissa Wen
2026-08-13 17:49 ` Alex Hung
2026-08-21 21:47 ` Alex Hung
2026-08-13 14:30 ` [PATCH v3 3/3] drm/amd/display: advertise PIXEL_NONE as blend mode for DCE generations Melissa Wen
2026-08-13 14:44 ` sashiko-bot
2026-08-13 15:04 ` Melissa Wen
2026-08-21 21:48 ` Alex Hung
2026-08-24 20:38 ` Viktor Jägersküpper
2026-08-24 21:02 ` Viktor Jägersküpper
2026-08-25 8:06 ` Melissa Wen
2026-08-25 11:25 ` Xaver Hugl
2026-08-25 18:56 ` Viktor Jägersküpper
2026-08-13 17:58 ` [PATCH v3 0/3] drm/atomic-state-helper: fixes for blend-mode-prop warning Wheeler, Daniel
2026-08-18 10:28 ` Melissa Wen
2026-08-21 13:49 ` Wheeler, Daniel
2026-08-25 21:24 ` Mikhail Gavrilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813143605.106104-2-mwen@igalia.com \
--to=mwen@igalia.com \
--cc=Daniel.Wheeler@amd.com \
--cc=airlied@gmail.com \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=kernel-dev@igalia.com \
--cc=leandro.ribeiro@collabora.com \
--cc=lyude@redhat.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=pekka.paalanen@collabora.com \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=sunpeng.li@amd.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.