All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: oe-kbuild-all@lists.linux.dev
Subject: [ardb:arm64-bti-veneers 15/18] drivers/firmware/efi/fdtparams.c:140:9: error: implicit declaration of function 'early_memremap_ro'; did you mean 'arch_memremap_wb'?
Date: Thu, 13 Aug 2026 14:13:15 +0800	[thread overview]
Message-ID: <202608131437.YZdXNyK7-lkp@intel.com> (raw)

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git arm64-bti-veneers
head:   82615c616e8cf0642701dd7adc233e43f761d580
commit: f973919abbc0179c7121f903d7b5d9495f2714a4 [15/18] efi: Pass EFI boot memmap struct address to core kernel
config: arm-randconfig-001-20260813 (https://download.01.org/0day-ci/archive/20260813/202608131437.YZdXNyK7-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 8.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260813/202608131437.YZdXNyK7-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202608131437.YZdXNyK7-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

   drivers/firmware/efi/fdtparams.c: In function 'efi_get_fdt_params':
>> drivers/firmware/efi/fdtparams.c:140:9: error: implicit declaration of function 'early_memremap_ro'; did you mean 'arch_memremap_wb'? [-Werror=implicit-function-declaration]
       bm = early_memremap_ro(memmap, sizeof(*bm));
            ^~~~~~~~~~~~~~~~~
            arch_memremap_wb
>> drivers/firmware/efi/fdtparams.c:140:7: warning: assignment to 'struct efi_boot_memmap *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
       bm = early_memremap_ro(memmap, sizeof(*bm));
          ^
>> drivers/firmware/efi/fdtparams.c:151:4: error: implicit declaration of function 'early_memunmap'; did you mean 'devm_memunmap'? [-Werror=implicit-function-declaration]
       early_memunmap(bm, sizeof(*bm));
       ^~~~~~~~~~~~~~
       devm_memunmap
   cc1: some warnings being treated as errors


vim +140 drivers/firmware/efi/fdtparams.c

    86	
    87	u64 __init efi_get_fdt_params(struct efi_memory_map_data *mm)
    88	{
    89		const void *fdt = initial_boot_params;
    90		unsigned long systab, memmap;
    91		int i, j, node;
    92		struct {
    93			void	*var;
    94			int	size;
    95		} target[] = {
    96			[SYSTAB] = { &systab,		sizeof(systab) },
    97			[MEMMAP] = { &memmap,		sizeof(memmap) },
    98	#ifdef CONFIG_XEN
    99			[MMBASE] = { &mm->phys_map,	sizeof(mm->phys_map) },
   100			[MMSIZE] = { &mm->size,		sizeof(mm->size) },
   101			[DCSIZE] = { &mm->desc_size,	sizeof(mm->desc_size) },
   102			[DCVERS] = { &mm->desc_version,	sizeof(mm->desc_version) },
   103	#endif
   104		};
   105	
   106		BUILD_BUG_ON(ARRAY_SIZE(target) != ARRAY_SIZE(name));
   107		BUILD_BUG_ON(ARRAY_SIZE(target) != ARRAY_SIZE(dt_params[0].params));
   108	
   109		if (!fdt)
   110			return 0;
   111	
   112		for (i = 0; i < ARRAY_SIZE(dt_params); i++) {
   113			node = fdt_path_offset(fdt, dt_params[i].path);
   114			if (node < 0)
   115				continue;
   116	
   117			if (efi_enabled(EFI_DBG))
   118				pr_info("Getting UEFI parameters from %s in DT:\n",
   119					dt_params[i].path);
   120	
   121			for (j = 0; j < ARRAY_SIZE(target); j++) {
   122				const char *pname = dt_params[i].params[j];
   123	
   124				if (pname[0] == '\0')
   125					continue;
   126	
   127				if (!efi_get_fdt_prop(fdt, node, pname, name[j],
   128						      target[j].var, target[j].size))
   129					continue;
   130				if (!j)
   131					goto notfound;
   132				pr_err("Can't find property '%s' in DT!\n", pname);
   133				return 0;
   134			}
   135			if (IS_ENABLED(CONFIG_XEN) && dt_params[i].paravirt) {
   136				set_bit(EFI_PARAVIRT, &efi.flags);
   137			} else {
   138				struct efi_boot_memmap *bm;
   139	
 > 140				bm = early_memremap_ro(memmap, sizeof(*bm));
   141				if (!bm) {
   142					pr_err("Cannot remap EFI boot memory map\n");
   143					return 0;
   144				}
   145	
   146				mm->phys_map		= memmap + sizeof(*bm);
   147				mm->size		= bm->map_size;
   148				mm->desc_size		= bm->desc_size;
   149				mm->desc_version	= bm->desc_ver;
   150	
 > 151				early_memunmap(bm, sizeof(*bm));

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2026-08-13  6:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202608131437.YZdXNyK7-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=ardb@kernel.org \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.