All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marco Chen <marcochen.dev@gmail.com>
To: dan@dlrobertson.com, jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	jagathjog1996@gmail.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org, skhan@linuxfoundation.org,
	linux-kernel-mentees@lists.linux.dev
Subject: [PATCH v1] iio: accel: bma400: remove completed tasks from TODO list
Date: Thu, 13 Aug 2026 11:01:03 -0400	[thread overview]
Message-ID: <20260813150103.56350-1-marcochen.dev@gmail.com> (raw)

Two of the four tasks in the TODO comment have been implemented.

Interrupts were added by commit ffe0ab6a9698 ("iio: accel:
bma400: Add triggered buffer support"). Support for events was added by
commit 961db2da159d ("iio: accel: bma400: Add support for single and
double tap events"), among others. The driver now has an interrupt
handler pushing IIO events, and event configuration from
read_event_config(), write_event_config(), read_event_value(), and
write_event_value().

A step count channel was also added by commit d221de60eee3 ("iio: accel:
bma400: Add separate channel for step counter").

The power management and sensor time channel TODOs remain unimplemented.

Signed-off-by: Marco Chen <marcochen.dev@gmail.com>
---
I would like to take on the remaining power management TODO. The driver
has bma400_set_power_mode() but neither bus assigns a dev_pm_ops
struct. POWER_MODE_LOW is also never entered. I don't have a BMA400 but
I would definitely buy one to develop and test on. I also have access to
a logic analyzer for testing. Is this a patch that is desirable?

 drivers/iio/accel/bma400_core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/accel/bma400_core.c b/drivers/iio/accel/bma400_core.c
index 7e3cff4cca91..6bc64ca87f4b 100644
--- a/drivers/iio/accel/bma400_core.c
+++ b/drivers/iio/accel/bma400_core.c
@@ -6,8 +6,6 @@
  *
  * TODO:
  *  - Support for power management
- *  - Support events and interrupts
- *  - Create channel for step count
  *  - Create channel for sensor time
  */
 
-- 
2.55.0


             reply	other threads:[~2026-08-13 15:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 15:01 Marco Chen [this message]
2026-08-17 14:15 ` [PATCH v1] iio: accel: bma400: remove completed tasks from TODO list Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260813150103.56350-1-marcochen.dev@gmail.com \
    --to=marcochen.dev@gmail.com \
    --cc=andy@kernel.org \
    --cc=dan@dlrobertson.com \
    --cc=dlechner@baylibre.com \
    --cc=jagathjog1996@gmail.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.