All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bin Meng <bin.meng@processmission.com>
To: QEMU <qemu-devel@nongnu.org>
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-arm@nongnu.org
Subject: [PATCH 04/20] hw/arm: collie: Store boot info in the machine state
Date: Thu, 13 Aug 2026 23:48:52 +0800	[thread overview]
Message-ID: <20260813154918.996812-5-bin.meng@processmission.com> (raw)
In-Reply-To: <20260813154918.996812-1-bin.meng@processmission.com>

arm_load_kernel() keeps a pointer to the boot info struct for the
lifetime of the VM, so the struct logically belongs to the machine
rather than to a file scoped static object.

Move the boot info into the existing CollieMachineState.

As in the xlnx-zcu102 and raspi machines, the boot info belongs to
the machine rather than to a static object:

4d1ac883a7 ("hw/arm: xlnx-zcu102: Move arm_boot_info into XlnxZCU102")
0f15c6e338 ("hw/arm/raspi: Move arm_boot_info structure to RaspiMachineState")

Signed-off-by: Bin Meng <bin.meng@processmission.com>
---

 hw/arm/collie.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/hw/arm/collie.c b/hw/arm/collie.c
index 91f0a94b6f..2deca04fd0 100644
--- a/hw/arm/collie.c
+++ b/hw/arm/collie.c
@@ -30,16 +30,12 @@ struct CollieMachineState {
     MachineState parent;
 
     StrongARMState *sa1110;
+    struct arm_boot_info bootinfo;
 };
 
 #define TYPE_COLLIE_MACHINE MACHINE_TYPE_NAME("collie")
 OBJECT_DECLARE_SIMPLE_TYPE(CollieMachineState, COLLIE_MACHINE)
 
-static struct arm_boot_info collie_binfo = {
-    .loader_start = SA_SDCS0,
-    .ram_size = RAM_SIZE,
-};
-
 static void collie_init(MachineState *machine)
 {
     MachineClass *mc = MACHINE_GET_CLASS(machine);
@@ -66,8 +62,12 @@ static void collie_init(MachineState *machine)
 
     sysbus_create_simple("scoop", 0x40800000, NULL);
 
-    collie_binfo.board_id = 0x208;
-    arm_load_kernel(cms->sa1110->cpu, machine, &collie_binfo);
+    cms->bootinfo = (struct arm_boot_info) {
+        .loader_start = SA_SDCS0,
+        .ram_size = RAM_SIZE,
+        .board_id = 0x208,
+    };
+    arm_load_kernel(cms->sa1110->cpu, machine, &cms->bootinfo);
 }
 
 static void collie_machine_class_init(ObjectClass *oc, const void *data)
-- 
2.53.0



  parent reply	other threads:[~2026-08-13 15:51 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-13 15:48 [PATCH 00/20] hw/arm: Store the ARM boot info in the machine state Bin Meng
2026-08-13 15:48 ` [PATCH 01/20] hw/arm: aspeed: Store " Bin Meng
2026-08-13 15:48 ` [PATCH 02/20] hw/arm: aspeed_ast27x0-fc: " Bin Meng
2026-08-13 15:48 ` [PATCH 03/20] hw/arm: bananapi_m2u: " Bin Meng
2026-08-13 15:48 ` Bin Meng [this message]
2026-08-13 15:48 ` [PATCH 05/20] hw/arm: cubieboard: " Bin Meng
2026-08-13 15:48 ` [PATCH 06/20] hw/arm: exynos4_boards: Store boot info in the board state Bin Meng
2026-08-13 15:48 ` [PATCH 07/20] hw/arm: imx25_pdk: " Bin Meng
2026-08-13 15:48 ` [PATCH 08/20] hw/arm: imx8mm-evk: Store boot info in the machine state Bin Meng
2026-08-13 15:48 ` [PATCH 09/20] hw/arm: integratorcp: " Bin Meng
2026-08-13 15:48 ` [PATCH 10/20] hw/arm: kzm: Store boot info in the board state Bin Meng
2026-08-13 15:48 ` [PATCH 11/20] hw/arm: mcimx7d-sabre: Store boot info in the machine state Bin Meng
2026-08-13 15:49 ` [PATCH 12/20] hw/arm: musicpal: " Bin Meng
2026-08-13 15:49 ` [PATCH 13/20] hw/arm: npcm7xx: " Bin Meng
2026-08-13 15:49 ` [PATCH 14/20] hw/arm: npcm8xx: " Bin Meng
2026-08-13 15:49 ` [PATCH 15/20] hw/arm: omap_sx1: " Bin Meng
2026-08-13 15:49 ` [PATCH 16/20] hw/arm: orangepi: " Bin Meng
2026-08-13 21:10   ` Niek Linnenbank
2026-08-13 15:49 ` [PATCH 17/20] hw/arm: realview: " Bin Meng
2026-08-13 15:49 ` [PATCH 18/20] hw/arm: sabrelite: " Bin Meng
2026-08-13 15:49 ` [PATCH 19/20] hw/arm: versatilepb: " Bin Meng
2026-08-13 15:49 ` [PATCH 20/20] hw/arm: xilinx_zynq: " Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260813154918.996812-5-bin.meng@processmission.com \
    --to=bin.meng@processmission.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.