Re: [PATCH 13/13] xtensa: pass all six syscall args to audit_syscall_entry()

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The core API patch in this series ('audit: log all six syscall arguments in the SYSCALL record') changed the signature of `audit_syscall_entry()` from 5 to 7 arguments, but the PowerPC architecture was missed. This leaves PowerPC passing 5 arguments, resulting in a build failure.
--

--- Patch [13]: [PATCH 13/13] xtensa: pass all six syscall args to audit_syscall_entry() ---
commit 7f8e4937464dcba7a1012a4d48470ce510d233d3
Author: Ricardo Robaina <rrobaina@redhat.com>

xtensa: pass all six syscall args to audit_syscall_entry()

Update the audit_syscall_entry() call to forward the 5th and 6th
syscall arguments (areg[8], areg[9]) now that the audit core logs
all six.

> diff --git a/arch/xtensa/kernel/ptrace.c b/arch/xtensa/kernel/ptrace.c
> index b80d54b2ea34e..122a6ffc0757e 100644
> --- a/arch/xtensa/kernel/ptrace.c
> +++ b/arch/xtensa/kernel/ptrace.c
> @@ -564,7 +564,8 @@ int do_syscall_trace_enter(struct pt_regs *regs)
>  
>  	audit_syscall_entry(regs->syscall, regs->areg[6],
>  			    regs->areg[3], regs->areg[4],
> -			    regs->areg[5]);
> +			    regs->areg[5], regs->areg[8],
> +			    regs->areg[9]);

[Severity: Low]
Is it possible that the powerpc architecture was missed in this series?

While xtensa is correctly updated here, it looks like do_syscall_trace_enter()
in arch/powerpc/kernel/ptrace/ptrace.c still passes 5 arguments:

arch/powerpc/kernel/ptrace/ptrace.c:do_syscall_trace_enter() {
    ...
		audit_syscall_entry(regs->gpr[0], regs->gpr[3], regs->gpr[4],
				    regs->gpr[5], regs->gpr[6]);
    ...
}

Will this cause a build regression on powerpc since the new signature requires
7 arguments?

>  	return 1;
>  }

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1786626275.git.rrobaina@redhat.com?part=13