From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from picard.linux.it (picard.linux.it [213.254.12.146]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A743C5B572 for ; Thu, 13 Aug 2026 18:43:28 +0000 (UTC) Received: from picard.linux.it (localhost [IPv6:::1]) by picard.linux.it (Postfix) with ESMTP id 038273C6EE3 for ; Thu, 13 Aug 2026 20:43:27 +0200 (CEST) Received: from in-2.smtp.seeweb.it (in-2.smtp.seeweb.it [217.194.8.2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (secp384r1)) (No client certificate requested) by picard.linux.it (Postfix) with ESMTPS id D68E83C5E18 for ; Thu, 13 Aug 2026 20:43:09 +0200 (CEST) Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by in-2.smtp.seeweb.it (Postfix) with ESMTPS id CDB0C60080C for ; Thu, 13 Aug 2026 20:43:08 +0200 (CEST) Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67DFXUlg2642465 for ; Thu, 13 Aug 2026 18:43:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:date:from:message-id:mime-version :subject:to; s=pp1; bh=Tn7rx0aMU4Kq/vX+iYGh1oGfFXeRA1Z2cKLVI6WH2 nw=; b=bwh4Pw51zFwT895jnfNdCeHCuXEezMn12IlaFCt9P4xoR3b/SaKZeTmOe PpOLwb6saV+9BjtLeJwWk0TuYtrcLAC23weOkSx9ihfc97O+nZm7LaCY9y+P0tlq Q+sO8FuAf8CPdzvT2wFULu/nWEI6vWJGzFIWuatgsE468yYqBr8kRG0FXaoD4IoE tli8E3nGmLc2Gqdks2ejLhK/5hBAbmkOTB8UlU1bJVZ1xajnh6m2t8nnXpLopkGM ukcH5HqN6RODRJxujVkNbgmuRRWfzEPGCU4APERxFvwSbffhCPegVOf2n5YtCthH A1eU38DGdYziceQoaApLdc0dWPvNA== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fwvp38cyv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 13 Aug 2026 18:43:06 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 67DIQMYl000677 for ; Thu, 13 Aug 2026 18:43:06 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4fxf5wcbha-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 13 Aug 2026 18:43:06 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 67DIh1Yi38011310 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 13 Aug 2026 18:43:01 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C371620043; Thu, 13 Aug 2026 18:43:01 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9370020040; Thu, 13 Aug 2026 18:43:00 +0000 (GMT) Received: from li-49acbccc-2994-11b2-a85c-d51b89e344f1.ibm.com.com (unknown [9.39.16.223]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Thu, 13 Aug 2026 18:43:00 +0000 (GMT) From: Pavithra To: ltp@lists.linux.it Date: Fri, 14 Aug 2026 00:12:57 +0530 Message-ID: <20260813184257.3061600-1-pavrampu@linux.ibm.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Authority-Analysis: v=2.4 cv=AMtp2X5w c=1 sm=1 tr=0 ts=6a7e103a cx=c_pps a=5BHTudwdYE3Te8bg5FgnPg==:117 a=5BHTudwdYE3Te8bg5FgnPg==:17 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=Y2IxJ9c9Rs8Kov3niI8_:22 a=VwQbUJbxAAAA:8 a=VnNF1IyMAAAA:8 a=Vc8gVf-lD3psx9Duk34A:9 X-Proofpoint-GUID: J2d7oPVPv987c9XnUD29mbR0UEuOmhMf X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODEzMDEzNCBTYWx0ZWRfX5ErCSmNirs0b voUBkPJ2kuWAcWVyNO56K0xNorjCkwgtVLqZ2oobEiMzkNMoSSVHHLnI7E4kkknnp5V9lffXeuB ThlnGqILSqVaNkGEaBJOlen9RkgEpbCMDoVy5IW6sZYchBopnhvplucxm/uNmMoh+wi39MS2Ccx DoRvI2HwTdJiebNIu0UNCFYqyspqhVG2Xx6D/TwK4tdmxQ5AWfvdCOlNjs7JIFGQchKWqNGElxp 3pNy/AJ0WzhBTUBal2Aib7kEaQANg8Qi3XvPssv5ndak6OF8CeprPL6sDXZ03mhmUCPY5stFzek RHT/KvXH0ZZ3Ma4t7YGgk98UMOw5rqBPIj04m1Z2+wDqf05KJcu9a0iYHpNJmiwcTko2Ze4xwRP 0Ckt6Pnn2sg33FsWzrfAqOuT3G+wXciJVOrj9VZ7iDdeBCbQiDF2ZFRvp7ievVBSTgbs8eRnqu0 PF02sWxADGGUcrzyNsQ== X-Proofpoint-ORIG-GUID: J2d7oPVPv987c9XnUD29mbR0UEuOmhMf X-Proofpoint-Spam-Info: AW1haW4tMjYwODEzMDEzNCBTYWx0ZWRfX5VyRue+my3bm /YDA0HgFAmskH8kqw6BmRiMHi13efe4OfozCbU11MkAvrefcfovTYyC52l1QCPydUtqf6g5JFbO zRlkaq9FDXZZY+KXb7FYd44OS8UI/NU= X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-13_05,2026-08-12_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 adultscore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 phishscore=0 spamscore=0 bulkscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608130134 X-Virus-Scanned: clamav-milter 1.0.9 at in-2.smtp.seeweb.it X-Virus-Status: Clean Subject: [LTP] [PATCH v4] memcg/memcontrol05: add cgroup v2 task migration charge accounting test X-BeenThere: ltp@lists.linux.it X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Test Project List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: pavrampu@linux.ibm.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ltp-bounces+ltp=archiver.kernel.org@lists.linux.it Sender: "ltp" Verify that in cgroup v2, memory charges remain pinned to the cgroup that allocated them when a task migrates, and that new allocations after migration are charged to the destination cgroup. Signed-off-by: Pavithra --- v3 -> v4: - disable swap on group_a and group_b to prevent false failures from memory.current drops under pressure Link to v3: https://lore.kernel.org/ltp/20260813162337.3012813-1-pavrampu@linux.ibm.com/ --- runtest/controllers | 1 + testcases/kernel/controllers/memcg/.gitignore | 1 + .../kernel/controllers/memcg/memcontrol05.c | 184 ++++++++++++++++++ 3 files changed, 186 insertions(+) create mode 100644 testcases/kernel/controllers/memcg/memcontrol05.c diff --git a/runtest/controllers b/runtest/controllers index 93c52c439..a9050ef0e 100644 --- a/runtest/controllers +++ b/runtest/controllers @@ -24,6 +24,7 @@ memcontrol01 memcontrol01 memcontrol02 memcontrol02 memcontrol03 memcontrol03 memcontrol04 memcontrol04 +memcontrol05 memcontrol05 cgroup_fj_function_debug cgroup_fj_function.sh debug cgroup_fj_function_cpuset cgroup_fj_function.sh cpuset diff --git a/testcases/kernel/controllers/memcg/.gitignore b/testcases/kernel/controllers/memcg/.gitignore index 3883cede6..8b9f6005c 100644 --- a/testcases/kernel/controllers/memcg/.gitignore +++ b/testcases/kernel/controllers/memcg/.gitignore @@ -9,3 +9,4 @@ memcontrol01 memcontrol02 memcontrol03 memcontrol04 +memcontrol05 diff --git a/testcases/kernel/controllers/memcg/memcontrol05.c b/testcases/kernel/controllers/memcg/memcontrol05.c new file mode 100644 index 000000000..d856c3680 --- /dev/null +++ b/testcases/kernel/controllers/memcg/memcontrol05.c @@ -0,0 +1,184 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2026 IBM + * Author : Pavithra + */ + +/*\ + * Origin: ``testcases/kernel/controllers/memctl/memctl_testplan.txt`` + * Verify memory controller charge accounting during task migration. + * + * Two child cgroups (``group_a``, ``group_b``) are created under the test cgroup. + * A worker process is placed in ``group_a`` and allocates a known amount of + * anonymous memory, touching every page to ensure physical allocation. + * Root is required to create cgroup subdirectories and to write a PID + * into ``cgroup.procs`` to migrate the worker between cgroups. + * + * Test 1 - No charge transfer on migration: + * The worker is migrated to ``group_b`` by writing its PID to + * ``group_b/cgroup.procs``. In cgroup v2 memory charges are never + * transferred on task migration; they remain pinned to the cgroup + * that allocated them. ``group_b/memory.current`` must not increase + * beyond its baseline after the migration. + * + * Test 2 - New allocations charged to destination cgroup: + * After migration the worker allocates an additional chunk of memory. + * This new allocation must be charged to ``group_b``, so + * ``group_b/memory.current`` must increase from the post-migration + * baseline. + */ + +#define _GNU_SOURCE + +#include +#include +#include +#include +#include "tst_test.h" +#include "memcontrol_common.h" + +#define ALLOC_SIZE MB(60) +#define ALLOC_SIZE2 MB(20) +#define MIN_MEM_AVAIL 128 + +enum checkpoints { + WORKER_ALLOC_DONE, + WORKER_RESUME, + WORKER_ALLOC2_DONE, + WORKER_EXIT, +}; + +static struct tst_cg_group *group_a; +static struct tst_cg_group *group_b; +static bool worker_resumed; + +static void touch_pages(char *buf, size_t size) +{ + size_t i; + + for (i = 0; i < size; i += getpagesize()) + buf[i] = 1; +} + +static void worker(void) +{ + char *buf1, *buf2; + + SAFE_CG_PRINTF(group_a, "cgroup.procs", "%d", getpid()); + + buf1 = SAFE_MMAP(NULL, ALLOC_SIZE, PROT_READ | PROT_WRITE, + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); + touch_pages(buf1, ALLOC_SIZE); + + TST_CHECKPOINT_WAKE(WORKER_ALLOC_DONE); + + TST_CHECKPOINT_WAIT(WORKER_RESUME); + + buf2 = SAFE_MMAP(NULL, ALLOC_SIZE2, PROT_READ | PROT_WRITE, + MAP_PRIVATE | MAP_ANONYMOUS, -1, 0); + touch_pages(buf2, ALLOC_SIZE2); + + TST_CHECKPOINT_WAKE(WORKER_ALLOC2_DONE); + + TST_CHECKPOINT_WAIT(WORKER_EXIT); + + SAFE_MUNMAP(buf1, ALLOC_SIZE); + SAFE_MUNMAP(buf2, ALLOC_SIZE2); +} + +static void test_memcg_task_migration(void) +{ + pid_t pid; + long baseline_b, after_migrate, after_migrate_a, after_alloc2, current_a; + + worker_resumed = false; + + group_a = tst_cg_group_mk(tst_cg, "group_a"); + group_b = tst_cg_group_mk(tst_cg, "group_b"); + + SAFE_CG_PRINT(group_a, "memory.swap.max", "0"); + SAFE_CG_PRINT(group_b, "memory.swap.max", "0"); + + SAFE_CG_SCANF(group_b, "memory.current", "%ld", &baseline_b); + tst_res(TINFO, "group_b baseline memory.current=%ld", baseline_b); + + pid = SAFE_FORK(); + if (!pid) { + worker(); + exit(0); + } + + TST_CHECKPOINT_WAIT(WORKER_ALLOC_DONE); + + SAFE_CG_SCANF(group_a, "memory.current", "%ld", ¤t_a); + tst_res(TINFO, "group_a memory.current=%ld after alloc", current_a); + if (current_a < (long)ALLOC_SIZE) { + tst_res(TFAIL, + "group_a memory.current (%ld) < ALLOC_SIZE (%ld)", + current_a, (long)ALLOC_SIZE); + goto done; + } + tst_res(TPASS, + "group_a memory.current (%ld) >= ALLOC_SIZE (%ld)", + current_a, (long)ALLOC_SIZE); + + SAFE_CG_PRINTF(group_b, "cgroup.procs", "%d", pid); + tst_res(TINFO, "Migrated worker PID %d to group_b", pid); + + SAFE_CG_SCANF(group_b, "memory.current", "%ld", &after_migrate); + tst_res(TINFO, + "group_b memory.current=%ld after migration (baseline=%ld)", + after_migrate, baseline_b); + + TST_EXP_EXPR(after_migrate <= baseline_b + (long)MB(4), + "group_b memory.current (%ld) not increased after migration (baseline=%ld)", + after_migrate, baseline_b); + + SAFE_CG_SCANF(group_a, "memory.current", "%ld", &after_migrate_a); + tst_res(TINFO, "group_a memory.current=%ld after migration", after_migrate_a); + TST_EXP_EXPR(after_migrate_a >= (long)ALLOC_SIZE, + "group_a memory.current (%ld) still holds pre-migration charges (>= ALLOC_SIZE %ld)", + after_migrate_a, (long)ALLOC_SIZE); + + TST_CHECKPOINT_WAKE(WORKER_RESUME); + worker_resumed = true; + TST_CHECKPOINT_WAIT(WORKER_ALLOC2_DONE); + + SAFE_CG_SCANF(group_b, "memory.current", "%ld", &after_alloc2); + tst_res(TINFO, "group_b memory.current=%ld after second alloc (baseline=%ld)", + after_alloc2, after_migrate); + + TST_EXP_EXPR(after_alloc2 >= after_migrate + (long)ALLOC_SIZE2, + "group_b memory.current (%ld) increased by >= ALLOC_SIZE2 (%ld)", + after_alloc2, (long)ALLOC_SIZE2); + +done: + if (!worker_resumed) { + TST_CHECKPOINT_WAKE(WORKER_RESUME); + TST_CHECKPOINT_WAIT(WORKER_ALLOC2_DONE); + } + TST_CHECKPOINT_WAKE(WORKER_EXIT); + tst_reap_children(); + + group_a = tst_cg_group_rm(group_a); + group_b = tst_cg_group_rm(group_b); +} + +static void cleanup(void) +{ + if (group_a) + group_a = tst_cg_group_rm(group_a); + if (group_b) + group_b = tst_cg_group_rm(group_b); +} + +static struct tst_test test = { + .test_all = test_memcg_task_migration, + .cleanup = cleanup, + .forks_child = 1, + .needs_root = 1, + .needs_checkpoints = 1, + .needs_cgroup_ver = TST_CG_V2, + .needs_cgroup_ctrls = (const char *const []){ "memory", NULL }, + .min_mem_avail = MIN_MEM_AVAIL, +}; -- 2.55.0 -- Mailing list info: https://lists.linux.it/listinfo/ltp