From: Jakub Kicinski <kuba@kernel.org>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: Zhan Xusheng <zhanxusheng1024@gmail.com>,
netdev@vger.kernel.org, Zhan Xusheng <zhanxusheng@xiaomi.com>,
stable@vger.kernel.org, vega@nebusec.ai,
Victor Nogueira <victor@mojatatu.com>,
David Ward <david.ward@ll.mit.edu>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net] net: sched: gred: fix 32-bit backlog wrap in gred_enqueue
Date: Thu, 13 Aug 2026 18:45:15 -0700 [thread overview]
Message-ID: <20260813184515.16a874d9@kernel.org> (raw)
In-Reply-To: <CAM0EoM=6zZVucSOUDi7pJiGhkoeTJ-PN9M18DnPWSpfH4GP6=A@mail.gmail.com>
On Sun, 9 Aug 2026 05:56:01 -0400 Jamal Hadi Salim wrote:
> > The gred check is the newer of the two: it came in with a3eb95f891d6,
> > the commit in your Fixes tag, while the bfifo one goes back to the
> > initial git import, so there is no useful Fixes: tag for it.
> >
> > bfifo also has more ways in than gred. sch_red.c and sch_tbf.c install a
> > bfifo child through fifo_create_dflt() -> fifo_set_limit(), passing
> > ctl->limit and qopt->limit straight from userspace; tc_red_qopt.limit is
> > likewise documented as bytes. Since this is heading to stable, fixing
> > gred alone leaves those paths unchanged.
> >
>
> I should have paid closer attention instead of focussing on the bug report.
> Since i already submitted, we can wait to see sashiko says - if
> requires an update i can include the others; otherwise it will have to
> be a followup patch.
I _think_ the Medium severity issue Clashiko called pre-existing is
in fact a corner case missed by the fix? Please shout if you disagree..
https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260809091657.879929-1-jhs@mojatatu.com
--
pw-bot: cr
prev parent reply other threads:[~2026-08-14 1:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-09 9:16 [PATCH net] net: sched: gred: fix 32-bit backlog wrap in gred_enqueue Jamal Hadi Salim
2026-08-09 9:43 ` Zhan Xusheng
2026-08-09 9:56 ` Jamal Hadi Salim
2026-08-14 1:45 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260813184515.16a874d9@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=david.ward@ll.mit.edu \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=vega@nebusec.ai \
--cc=victor@mojatatu.com \
--cc=zhanxusheng1024@gmail.com \
--cc=zhanxusheng@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.