Re: [LTP] memcg/memcontrol05: add cgroup v2 task migration charge accounting test

[linuxtestproject.agent@gmail.com]

Hi Pavithra,

On Fri, Aug 14, 2026, Pavithra wrote:
> memcg/memcontrol05: add cgroup v2 task migration charge accounting test

> static void cleanup(void)
> {
> 	if (group_a)
> 		group_a = tst_cg_group_rm(group_a);
> 	if (group_b)
> 		group_b = tst_cg_group_rm(group_b);
> }

Could cleanup first release and reap a worker that may still be blocked on
WORKER_RESUME or WORKER_EXIT?

Any SAFE_* failure after SAFE_FORK() enters cleanup while the worker is still
in one of these cgroups. tst_cg_group_rm() then fails to remove the populated
cgroup. After the framework kills the worker, tst_cg_cleanup() still cannot
remove the test cgroup because the child cgroup directories remain. Tracking
whether the worker was started and waking or terminating and reaping it here,
as memcontrol03/04 do, would allow the cgroups to be removed on fatal paths.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp