From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.andi.de1.cc (mail.andi.de1.cc [178.238.236.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B214542BC38 for ; Thu, 13 Aug 2026 20:44:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.238.236.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786653884; cv=none; b=bc89R+cBD+OZPpouAcUoGrAlfxKUtgT21ccGp0FYpE5fPb3Rt30D9JHGgjKHiZBHS43URrbVW47NVeV3lWdrT85WjojEaOZKvPi7Rltpt88RWc6lAn/l8kW/OnSYVBIorVubiaEG9neGXLfXRgbto+8MMu3MWWYs7mAbMBAs4xs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786653884; c=relaxed/simple; bh=Ks+OEH9vS0E0Gmb1owdfeJDBHWiZR0kwcy1sf3iQj5k=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=GOJBoR+sqYk+XEem8U8j08P2IwZ30X7kL1cZFLYErps2ke8xKn0mIFw+c70uSXvQIYM7lSetsW9WJjjYpMi4rEIFAR+HUiygGrM2fYMVxQ/kn0NBhuY0RdlzT5ktGlMJJ3p18YD3GE+OcinwvBzMufNlEr0bsMLNJ/Gr3wMkvH4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info; spf=pass smtp.mailfrom=kemnade.info; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b=P07mYIKq; arc=none smtp.client-ip=178.238.236.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=kemnade.info Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kemnade.info Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="P07mYIKq" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20220719; h=References:In-Reply-To:Subject:Cc:To:From: Reply-To:Content-ID:Content-Description; bh=tdCGDPvlMZz660YdIMU4re8nHrkLh2ruA/zi3XeAtl8=; t=1786653882; x=1787863482; b=P07mYIKqq+aarpb9m1NknVJfTMZKt0IRSyQpSYNFsWQKO3M6dhUcB5VwfDCN1bHLjVCU4r8aYBi h65sf/JSMySxJ/NDj1yQqSNZ4zvDnrDz0QpPgnpQjYe1EB0NbLwYLQZgAqaRkVlbJI/aHJJjluAYT OtLl6UTbsHVKF+xOq8YyctuIR6RZPGbjjl+GPho0eauBB/g9i7M8oQrtgxzzmy2k8cvbwDnAurQQn spIGwANWrbgp17R7SA45CwGFqd7vwg5StBkfWQZD9KZtBDwdpKbMXdyjeqG4jqT/qcDnB0KeyLsYr K5/VFlZylTlF7SHMmOh1v5twUilpNsnQknOw==; Date: Thu, 13 Aug 2026 22:44:30 +0200 From: Andreas Kemnade To: Lee Jones Cc: sashiko-bot@kernel.org, sashiko-reviews@lists.linux.dev, linux-leds@vger.kernel.org, "H. Nikolaus Schaller" Subject: Re: [PATCH v3] leds: is31fl319x: modernize registration Message-ID: <20260813224430.467cb79b@kemnade.info> In-Reply-To: <20260812132941.GU1072730@google.com> References: <20260804-led-modern-v3-1-297720eec19f@kemnade.info> <20260804135515.5DBFC1F000E9@smtp.kernel.org> <20260804164101.43753f1b@kemnade.info> <20260806104525.GC10716@google.com> <20260806135550.2d57682c@kemnade.info> <20260811185127.GW2869284@google.com> <20260812084320.21a7341a@kemnade.info> <20260812132941.GU1072730@google.com> X-Mailer: Claws Mail 4.3.1 (GTK 3.24.49; aarch64-unknown-linux-gnu) Precedence: bulk X-Mailing-List: linux-leds@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 12 Aug 2026 14:29:41 +0100 Lee Jones wrote: > On Wed, 12 Aug 2026, Andreas Kemnade wrote: > > > On Tue, 11 Aug 2026 19:51:27 +0100 > > Lee Jones wrote: > > > > > On Thu, 06 Aug 2026, Andreas Kemnade wrote: > > > > > > > On Thu, 6 Aug 2026 11:45:25 +0100 > > > > Lee Jones wrote: > > > > > > > > > On Tue, 04 Aug 2026, Andreas Kemnade wrote: > > > > > > > > > > > On Tue, 04 Aug 2026 13:55:14 +0000 > > > > > > sashiko-bot@kernel.org wrote: > > > > > > > > > > > > > > leds: is31fl319x: modernize registration > > > > > > > > > > > > > > [Severity: Low] > > > > > > > This isn't a bug, but should the description after the subsystem prefix be > > > > > > > capitalized? The LED subsystem guidelines recommend formatting commit messages > > > > > > > as "leds: : ". > > > > > > > > > > > > > > > > > > ~/linux$ grep -R 'leds: : "' Documentation/ > > > > > > ~/linux$ ls Documentation/leds/ > > > > > > index.rst leds-lp5521.rst leds-sc27xx.rst > > > > > > leds-blinkm.rst leds-lp5523.rst leds-st1202.rst > > > > > > leds-cht-wcove.rst leds-lp5562.rst ledtrig-oneshot.rst > > > > > > leds-class-flash.rst leds-lp55xx.rst ledtrig-transient.rst > > > > > > leds-class-multicolor.rst leds-lp5812.rst ledtrig-usbport.rst > > > > > > leds-class.rst leds-mlxcpld.rst uleds.rst > > > > > > leds-el15203000.rst leds-mt6370-rgb.rst well-known-leds.txt > > > > > > leds-lm3556.rst leds-qcom-lpg.rst > > > > > > leds-lp3944.rst leds-s2m-rgb.rst > > > > > > > > > > > > nothing look like special guidelines for the system. I do not want to > > > > > > see such comments without a reference. > > > > > > Also MAINTAINERS does not show any additional policy for the LED subsystem. > > > > > > > > > > `git log --oneline -- ` is your friend. > > > > > > > > > That is looking at common practice, not guidelines, which is of course > > > > often a good idea. > > > > > > > > So Sahiko is hallucinating about non-existant guidelines which > > > > cannot be referenced of course. Well, at least it gives quite an amount of > > > > useful hintse. > > > > > > It's not hallucinating, I put it there. =:-) > > > > > > https://github.com/sashiko-dev/sashiko/blob/main/third_party/prompts/kernel/subsystem/leds.md > > > > > > Specifically: > > > > > > https://github.com/sashiko-dev/sashiko/blob/main/third_party/prompts/kernel/subsystem/leds.md?plain=1#L8 > > > > > So, that is another repository of another project. That is not an > > intuitive place to look at. So I would expect to see at least some pointer > > in that direction in the first place. > > It's not common for maintainers to document all of their idiosyncrasies > and preferences. You've asked if the review comment is legitimate and > I've told you that it is. > It is not common to document everything. That is correct. I think you got me a bit wrong here. I have not questioned the legitimacy of the review comment, I am questioning the style of this Sashiko review which is basically: "there is documentation but I do not tell you where it is, even if it is in unusual place (I consider anything not in the Documentation folder of the kernel git as unusal)." Regards, Andreas