From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f179.google.com (mail-qk1-f179.google.com [209.85.222.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDFB53806D0 for ; Thu, 13 Aug 2026 22:46:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786661192; cv=none; b=Z/RSm608sbpa9k0o4lpb23Tr5TTEvLyXGSbs8XiWc0T73pKVcm7XhFJwThw0rACKtwS0xRS1Wh1tS+J7vM3iUcABvuRsFepedc/Zg5Cjg94vuHuLIZSmzVgt9uxKUkB3Y/ViT1xiSfGHqKPDn4TGs+ssc4QcVNmWKTPcusqVMVU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786661192; c=relaxed/simple; bh=i/6Jol0HBp5RRTvGHc5apFk8jhMg7iNWk5RSz52dbzY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ONHfCf0X68/7P7gEqWcVVYVc7YWzjISzouCOLXxh3Fr4hWCF1881BCYJbkwHolzpil1Vw1uQmdFsWZ1LKJ1gBU5hqJ6vl5AZhUEX/p9m2cOWVMFBJU0oxTr6/6ehsPDfLhA5VW82HTA6EaVd2Q3hGaemZQyx33zXgkrNP9pTN8U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca; spf=pass smtp.mailfrom=ziepe.ca; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b=GyRDrHzM; arc=none smtp.client-ip=209.85.222.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ziepe.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="GyRDrHzM" Received: by mail-qk1-f179.google.com with SMTP id af79cd13be357-936c02e58dfso27261085a.3 for ; Thu, 13 Aug 2026 15:46:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1786661190; x=1787265990; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=o5MtttmxZUrUNaLZLU+CiS25EBYvth90JdQ9xwh2RPo=; b=GyRDrHzMJ7bZyxuYZiASbi/fS/57YYoi2CZ7A9Z5GilQcrSSP3X4wNczxRQuqgfgAX bjvJ26TknklFhb/B8EES7F0pwa1ygSXvcSCJ1qZCASGQ63G3Ewr7Bma/3yLsur/laeko L+LCOJ57ncnnseSY65cXCGkXTYMf2MM8Shd6eQ9mVRxDYGC1SFBMXzsyq3P3up44E2P3 gLhDE8KmU86bIkcNdrO7qyID9o10viZ30EV+Hp2GcWmIIl00KHMD7+W+UWTu2Y5L4PT7 Nvv1X8tRBMgNgv1/2lxLsvdxV/5IHiRlyXMYBQqlT1e+atfxZYIgRlz/DKcsqMaxUVzS 9JlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786661190; x=1787265990; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=o5MtttmxZUrUNaLZLU+CiS25EBYvth90JdQ9xwh2RPo=; b=QZFlyTshTLtGg6be51TIZP2RXjab4MSh9viqiG8rPX7bLB4BOnXuV+wKHaetw3LBJp 5gfdaZVQfGNtDi1y8LZMcHskRB7dEP4mwr8+2OGLgjFs8nww4UpiQEaZcGXfsRVgis/6 muDkQFIzBIKOvUdAtzT6du0bEI0NESz84qOuBPkGQBllEGAoX/b7odHxczpsD+kCZNGE UIKcWLLOu9PoX7gGlGm6Z6tVp4yyKcjNjopqF1992Jbje906ZnWiVeFJG/0yIIAOL1D5 WOskFvtZxWNe7LauLOohLWcv+Df3cOUcAmswEpBIgV9raMkUMdHw41B1tnaBy34w7hBG ep7Q== X-Forwarded-Encrypted: i=1; AHgh+Rpx8VbN57UZKoFyMYS27fUTMs9VcCY5pF2C9j8+s+6Q0cvci16mqceDT07Pvdu1Cp7fF+I/MS+cYMA=@vger.kernel.org X-Gm-Message-State: AOJu0YwC5mLklY94Mx7ceBG7LSRn6RGbgKpzic/eWjytrt+qU8RoQ0F0 TBEdad53zN/K86QUpLsb9cUy8Bn/pEolZSvfMev8cyPpg7K7nPnUE3Tju8557IAIUic= X-Gm-Gg: AR+sD11Sd8u5JD67uOV9hKLuQGq6Jkwc/z4ez3FCZS+4xpzSUQ9Tv4LlcVjZNHM9dIi qtzEGzwFHDKwo0/CMiAQvyBuTacESnm9awb4FQTzR24qVdJ7I8plXaOOFS83mTFZ2oA/QgdjDDG rYKHB59uC/YRWXh1JKSSbfRzMUtQdQ1YaqK+5E4AomepJoMTnrGD4u82Uqs0sQ/KOn7COkJoEmV B3bj/uQm7SC5r6iTaRrAlB4DqDXxfgXVbsax5rQv7w34QaIE7EOT+kJ6TEJiUezDJxDe2bU+ifP eOlvxpOHiCWg8OhIoIexUVz/cgJEwT7Bb4V/w2fsnldthdJYFFZT7XqqVuf6aNXvmKW8RQn2PYr cwtwPlo+RsHSSyHIGDbZUBl5yCUcL9mOGRGvvCWBIhx+3/PQxc//WUI+/OpxdQ7ZvguUTve7H13 evIEpN+KO0dryaM4myyGFn/IbyE1waR7i+J5IoUA== X-Received: by 2002:a05:620a:408c:b0:933:ada:c3b2 with SMTP id af79cd13be357-936d2382749mr132987985a.34.1786661189637; Thu, 13 Aug 2026 15:46:29 -0700 (PDT) Received: from ziepe.ca ([142.166.156.215]) by smtp.gmail.com with ESMTPSA id af79cd13be357-936ce245787sm96424985a.41.2026.08.13.15.46.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2026 15:46:28 -0700 (PDT) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1wueBv-000000042QP-14bA; Thu, 13 Aug 2026 19:46:27 -0300 Date: Thu, 13 Aug 2026 19:46:27 -0300 From: Jason Gunthorpe To: Jacob Pan Cc: Yu Zhang , linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, iommu@lists.linux.dev, linux-pci@vger.kernel.org, linux-arch@vger.kernel.org, x86@kernel.org, wei.liu@kernel.org, kys@microsoft.com, haiyangz@microsoft.com, decui@microsoft.com, longli@microsoft.com, joro@8bytes.org, will@kernel.org, robin.murphy@arm.com, bhelgaas@google.com, kwilczynski@kernel.org, lpieralisi@kernel.org, mani@kernel.org, robh@kernel.org, arnd@arndb.de, mhklinux@outlook.com, tgopinath@linux.microsoft.com, easwar.hariharan@linux.microsoft.com, mrathor@linux.microsoft.com, baolu.lu@linux.intel.com, suravee.suthikulpanit@amd.com, vasant.hegde@amd.com Subject: Re: [PATCH v3 4/5] iommu/hyperv: Add para-virtualized IOMMU support for Hyper-V guest Message-ID: <20260813224627.GA933791@ziepe.ca> References: <20260811155022.108148-1-zhangyu1@linux.microsoft.com> <20260811155022.108148-5-zhangyu1@linux.microsoft.com> <20260813152913.00003d8a@linux.microsoft.com> Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260813152913.00003d8a@linux.microsoft.com> On Thu, Aug 13, 2026 at 03:29:13PM -0700, Jacob Pan wrote: > > +static int hv_iommu_blocking_attach_dev(struct iommu_domain *domain, > > + struct device *dev, > > + struct iommu_domain *old) > > +{ > > + struct hv_iommu_endpoint *vdev = dev_iommu_priv_get(dev); > > + struct hv_iommu_domain *hv_domain = > > to_hv_iommu_domain(domain); > > + struct pci_dev *pdev = to_pci_dev(dev); > > + int ret; > > + > > + if (pdev->ats_enabled) > > + pci_disable_ats(pdev); > > + > > + if (vdev->hv_domain == hv_domain) > > + return 0; > It may not be needed since the core code will check this. If you keep > this as extra precaution, should this be moved up before ats? since ats > must be disabled already if blocking domain is attached. Why check it at all? Is there an issue with attaching the same thing twice? Will it blip the DMA or something? Jason