From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EAFAEC5CFCF for ; Fri, 14 Aug 2026 02:41:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/G8VewqeC+u9BYCZ1gBo1k/hL+pZW3JrRVacHQ7jjL0=; b=1X59otLV6upSz5 mMfqwe/b1wxiEenCYngfefBOZKQy8JlaoRSkujQXwCkappG7j0Nz3mV3H+NhMjO7k/rDKX0twssem TV9yWiCqbNgkNm/V0/6BZaGnCLMU08tjoVYlhmSDReeYdvFqtEuRHsX/vjE8c9iQa20osah0iEMKR M5bIYLpWyoBC8BVSCiY/CUltzsPc1OTnb4Uf0RQB7vdDE3XwKiFD+Gl2Vcd6bM/LCQ5+769m0gjSC LZvOFP45vdEfoDw/CRbbWCakUNHYnam+Ks/kGJq9CYWjYS7vl5c+Sy8jDM/XwCnc0LDBeSfgodf0R L5CoTX4x2dMGHdFHTeRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wuhrm-00000001sOH-250R; Fri, 14 Aug 2026 02:41:54 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wuhrk-00000001sOB-40vj for linux-phy@lists.infradead.org; Fri, 14 Aug 2026 02:41:53 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id E3FAD600AD; Fri, 14 Aug 2026 02:41:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31F801F000E9; Fri, 14 Aug 2026 02:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786675311; bh=WqTd6hTvZP+7jr4CnwgT2uItwEHTmJCWS0N2lOJVzwQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=NxttqOd3EAC4rRwNzQFauADKHZyKwAoZmPVJUKdsv69f1sc53/Ryt22QSl4pZ1tgh uoRUV2vvpp4ORqZ/r38+mcfqNaZFJPpMVAKQ6/oP7VwcLiCAn7CPD4ftgAokgjmLel /DsRVD7njV0CzB4x5uR3OXRcmf+PXikL/k1fWyDm65EAVkJLdFaLsgfr7/+SxP2wt/ o7jdVct2d0eLes/9BhUWzVx7rxiADfC4rVdx1UBVkJNaaZOeqJ1OdBNGgJRDAHZAAw yvFJMDY0V/kjM0vbpHrqVDM5mKRmECD53EcP8VyrYT2QEk8Kv9VJHiDU9T+7uCoDus GXjp6GSsXr0Og== From: sashiko-bot@kernel.org Subject: Re: [PATCH v14 10/38] phy: rockchip: usbdp: Add missing mode_change update To: "Sebastian Reichel" Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org, neil.armstrong@linaro.org In-Reply-To: <20260813-rockchip-usbdp-cleanup-v14-10-b5ad9c68fa11@collabora.com> References: <20260813-rockchip-usbdp-cleanup-v14-0-b5ad9c68fa11@collabora.com> <20260813-rockchip-usbdp-cleanup-v14-10-b5ad9c68fa11@collabora.com> Date: Fri, 14 Aug 2026 02:41:50 +0000 Message-Id: <20260814024151.31F801F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBUeXBlLUMgc3RhdGUgZmFsbGJhY2sgdG8gVVNCL1NhZmUgbW9kZXMgc2tpcHMgdGhl IFBIWSBtb2RlIHVwZGF0ZSBhbmQgSFBEIHJlc2V0LCBwZXJtYW5lbnRseSBicmVha2luZyBVU0Ig My4wIGFuZCBsZWF2aW5nIGEgZ2hvc3QgRGlzcGxheVBvcnQgY29ubmVjdGlvbi4KLSBbSGlnaF0g VGhlIFBIWSBkcml2ZXIgaW5kZWZpbml0ZWx5IGxlYWtzIGFjdGl2ZSBwb3dlciBzdGF0ZXMgKGNs b2NrcyBhbmQgcmVzZXRzKSBpZiB0aGUgVHlwZS1DIG11eCBtb2RlIGNoYW5nZXMgYmVmb3JlIHRo ZSBVU0Igb3IgRFAgY29udHJvbGxlcnMgZXhlY3V0ZSB0aGVpciB0ZWFyZG93biByb3V0aW5lcy4K LS0KCi0tLSBQYXRjaCBbMTBdOiBbUEFUQ0ggdjE0IDEwLzM4XSBwaHk6IHJvY2tjaGlwOiB1c2Jk cDogQWRkIG1pc3NpbmcgbW9kZV9jaGFuZ2UgdXBkYXRlIC0tLQpjb21taXQgOWJlZDRmYTA4ZGQx MTY3MTZhMzlmMjI4YmRkOTYxYzY2YThmOGI2NApBdXRob3I6IFNlYmFzdGlhbiBSZWljaGVsIDxz ZWJhc3RpYW4ucmVpY2hlbEBjb2xsYWJvcmEuY29tPgoKcGh5OiByb2NrY2hpcDogdXNiZHA6IEFk ZCBtaXNzaW5nIG1vZGVfY2hhbmdlIHVwZGF0ZQoKcmtfdWRwaHlfc2V0X3R5cGVjX2RlZmF1bHRf bWFwcGluZygpIHVwZGF0ZXMgdGhlIGF2YWlsYWJsZSBtb2RlcywKYnV0IGRvZXMgbm90IHNldCB0 aGUgbW9kZV9jaGFuZ2UgYXMgcmVxdWlyZWQuIFRoaXMgcmVzdWx0cyBpbgptaXNzaW5nIHJlLWlu aXRpYWxpemF0aW9uIGFuZCB0aHVzIG5vbi13b3JraW5nIERpc3BsYXlQb3J0LgoKPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tjaGlwLXVzYmRwLmMgYi9kcml2ZXJz L3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtdXNiZHAuYwo+IGluZGV4IDk4MjMxNTUzNWNhZjcu Ljc1NDBjODk3ZGRlMTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJv Y2tjaGlwLXVzYmRwLmMKPiArKysgYi9kcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAt dXNiZHAuYwo+IEBAIC02MTcsNiArNjE3LDE1IEBAIHN0YXRpYyB2b2lkIHJrX3VkcGh5X2RwX2hw ZF9ldmVudF90cmlnZ2VyKHN0cnVjdCBya191ZHBoeSAqdWRwaHksIGJvb2wgaHBkKQo+ICAJcmtf dWRwaHlfZ3JmcmVnX3dyaXRlKHVkcGh5LT52b2dyZiwgJmNmZy0+dm9ncmZjZmdbdWRwaHktPmlk XS5ocGRfdHJpZ2dlciwgaHBkKTsKPiAgfQo+ICAKPiArc3RhdGljIHZvaWQgcmtfdWRwaHlfbW9k ZV9zZXQoc3RydWN0IHJrX3VkcGh5ICp1ZHBoeSwgdTggbW9kZSkKPiArewo+ICsJaWYgKHVkcGh5 LT5tb2RlID09IG1vZGUpCj4gKwkJcmV0dXJuOwo+ICsKPiArCXVkcGh5LT5tb2RlX2NoYW5nZSA9 IHRydWU7Cj4gKwl1ZHBoeS0+bW9kZSA9IG1vZGU7Cj4gK30KCltTZXZlcml0eTogSGlnaF0KVGhp cyBpc24ndCBhIGJ1ZyBpbnRyb2R1Y2VkIGJ5IHRoaXMgcGF0Y2gsIGJ1dCBzaW5jZSB3ZSBhcmUg dXBkYXRpbmcgaG93IHRoZQptb2RlIGlzIHNldCwgY2FuIHRoaXMgYXN5bmNocm9ub3VzIHVwZGF0 ZSB0byB1ZHBoeS0+bW9kZSBsZWFkIHRvIGEgcG93ZXIgc3RhdGUKbGVhaz8KCklmIHRoZSBUeXBl LUMgc3Vic3lzdGVtIGFzeW5jaHJvbm91c2x5IHVwZGF0ZXMgdGhlIHJlcXVlc3RlZCBtb2RlIHZp YQpya191ZHBoeV90eXBlY19tdXhfc2V0KCkgKGUuZy4sIGNoYW5naW5nIGZyb20gVURQSFlfTU9E RV9EUF9VU0IgdG8KVURQSFlfTU9ERV9EUCksIGRvZXMgdGhpcyBjYXVzZSBsYXRlciB0ZWFyZG93 biByb3V0aW5lcyB0byBmYWlsPwoKRm9yIGV4YW1wbGUsIHdoZW4gdGhlIFVTQiBjb250cm9sbGVy IHN1c3BlbmRzIGFuZCBjYWxscyBwaHlfZXhpdCgpIG9yCnBoeV9wb3dlcl9vZmYoKSwgcm91dGlu ZXMgbGlrZSBya191ZHBoeV91c2IzX3BoeV9leGl0KCkgY2hlY2sgdGhlIG1vZGU6Cgpkcml2ZXJz L3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtdXNiZHAuYzpya191ZHBoeV91c2IzX3BoeV9leGl0 KCkgewogICAgLi4uCgkvKiBEUCBvbmx5IG9yIGhpZ2gtc3BlZWQgKi8KCWlmICghKHVkcGh5LT5t b2RlICYgVURQSFlfTU9ERV9VU0IpIHx8IHVkcGh5LT5ocykKCQlnb3RvIHVubG9jazsKICAgIC4u Lgp9CgpTaW1pbGFybHkgaW4gcmtfdWRwaHlfcG93ZXJfb2ZmKCk6Cgpkcml2ZXJzL3BoeS9yb2Nr Y2hpcC9waHktcm9ja2NoaXAtdXNiZHAuYzpya191ZHBoeV9wb3dlcl9vZmYoKSB7CiAgICAuLi4K CWlmICghKHVkcGh5LT5tb2RlICYgbW9kZSkpIHsKCQlkZXZfaW5mbyh1ZHBoeS0+ZGV2LCAibW9k ZSAweCUwMnggaXMgbm90IHN1cHBvcnRcbiIsIG1vZGUpOwoJCXJldHVybjsKCX0KICAgIC4uLgp9 CgpCZWNhdXNlIHVkcGh5LT5tb2RlIGhhcyBhbHJlYWR5IGNoYW5nZWQsIGRvIHRoZXNlIGZ1bmN0 aW9ucyByZXR1cm4gZWFybHkKd2l0aG91dCBjbGVhcmluZyB0aGUgVVNCIGJpdCBmcm9tIHVkcGh5 LT5zdGF0dXMsIGxlYXZpbmcgYWN0aXZlIGhhcmR3YXJlCmNsb2NrcyBhbmQgcmVzZXRzIGxlYWtl ZCBpbmRlZmluaXRlbHk/CgpbIC4uLiBdCgo+IEBAIC0xMzYxLDEwICsxMzcwLDcgQEAgc3RhdGlj IGludCBya191ZHBoeV90eXBlY19tdXhfc2V0KHN0cnVjdCB0eXBlY19tdXhfZGV2ICptdXgsCj4g IAkJCXVzbGVlcF9yYW5nZSg3NTAsIDgwMCk7Cj4gIAkJCXJrX3VkcGh5X2RwX2hwZF9ldmVudF90 cmlnZ2VyKHVkcGh5LCB0cnVlKTsKPiAgCQl9IGVsc2UgaWYgKGRhdGEtPnN0YXR1cyAmIERQX1NU QVRVU19IUERfU1RBVEUpIHsKPiAtCQkJaWYgKHVkcGh5LT5tb2RlICE9IG1vZGUpIHsKPiAtCQkJ CXVkcGh5LT5tb2RlID0gbW9kZTsKPiAtCQkJCXVkcGh5LT5tb2RlX2NoYW5nZSA9IHRydWU7Cj4g LQkJCX0KPiArCQkJcmtfdWRwaHlfbW9kZV9zZXQodWRwaHksIG1vZGUpOwo+ICAJCQlya191ZHBo eV9kcF9ocGRfZXZlbnRfdHJpZ2dlcih1ZHBoeSwgdHJ1ZSk7Cj4gIAkJfSBlbHNlIHsKPiAgCQkJ cmtfdWRwaHlfZHBfaHBkX2V2ZW50X3RyaWdnZXIodWRwaHksIGZhbHNlKTsKCltTZXZlcml0eTog SGlnaF0KVGhpcyBpcyBhIHByZS1leGlzdGluZyBpc3N1ZSwgYnV0IEkgaGF2ZSBhIHF1ZXN0aW9u IGFib3V0IHRoZSBicm9hZGVyIGxvZ2ljCmluIHJrX3VkcGh5X3R5cGVjX211eF9zZXQoKSB3aGVu IHRoZSBtb2RlIGNoYW5nZXMuCgpXaGVuIHRoZSBUeXBlLUMgcG9ydCBleGl0cyBBbHQgTW9kZSB0 byBhIHNhZmUgb3IgVVNCLW9ubHkgc3RhdGUsIGRvZXMgdGhpcwpza2lwIHRoZSBQSFkgbW9kZSB1 cGRhdGUgYW5kIEhQRCByZXNldCBlbnRpcmVseT8KCkl0IGxvb2tzIGxpa2UgdGhlIHZpdGFsIHN0 YXRlIHVwZGF0ZXMgKGluY2x1ZGluZyB0aGUgbmV3IHJrX3VkcGh5X21vZGVfc2V0KCkKY2FsbCkg YXJlIGdhdGVkIGJlaGluZCBhbiBlYXJsaWVyIGNoZWNrIGluIHJrX3VkcGh5X3R5cGVjX211eF9z ZXQoKToKCmRyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC11c2JkcC5jOnJrX3VkcGh5 X3R5cGVjX211eF9zZXQoKSB7CiAgICAuLi4KCWlmIChzdGF0ZS0+YWx0ICYmIHN0YXRlLT5hbHQt PnN2aWQgPT0gVVNCX1RZUEVDX0RQX1NJRCkgewoJCXN0cnVjdCB0eXBlY19kaXNwbGF5cG9ydF9k YXRhICpkYXRhID0gc3RhdGUtPmRhdGE7CiAgICAuLi4KfQoKQmVjYXVzZSBzdGF0ZS0+YWx0IGlz IE5VTEwgd2hlbiBleGl0aW5nIERpc3BsYXlQb3J0IEFsdCBNb2RlLCB0aGlzIGJsb2NrIGlzCmJ5 cGFzc2VkLiBDYW4gdGhpcyBsZWF2ZSB1ZHBoeS0+bW9kZSBzdHVjayBpbiBVRFBIWV9NT0RFX0RQ LCBwb3RlbnRpYWxseQpicmVha2luZyBVU0IgMy4wIGZ1bmN0aW9uYWxpdHkgYW5kIGxlYXZpbmcg YSBnaG9zdCBEaXNwbGF5UG9ydCBjb25uZWN0aW9uPwoKLS0gClNhc2hpa28gQUkgcmV2aWV3IMK3 IGh0dHBzOi8vc2FzaGlrby5kZXYvIy9wYXRjaHNldC8yMDI2MDgxMy1yb2NrY2hpcC11c2JkcC1j bGVhbnVwLXYxNC0wLWI1YWQ5YzY4ZmExMUBjb2xsYWJvcmEuY29tP3BhcnQ9MTAKCi0tIApsaW51 eC1waHkgbWFpbGluZyBsaXN0CmxpbnV4LXBoeUBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHBzOi8v bGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LXBoeQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B6519336881 for ; Fri, 14 Aug 2026 02:41:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786675312; cv=none; b=uBrEhkILqufKBYy5k8umqxkqRE3HDvOc/Ulb/wHbiwGBlcxPRvWMJay4vGkhL3fqbRjMxdgQhgBOxa79VADgx21FeXrEEgZ+kOZXMWCppSk3SoZEmM2bDaUAo2blqfrgv9a03X66frBs5Ao0mw5UQKpdr7JpUe0sv0ZkuYruJFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786675312; c=relaxed/simple; bh=xdWcD+HPDEB9bSukuWDb7jz+ZbC/tJBtzFDqHHWiKz0=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=N8lywqZ2DiQ7WIiVFST/rL+pF4U+7dBrVQ1LDMh8hli0R3HeXUlr7OQQ+5VHPHYVMb+5qvl3nbXJDZR8jjxLb+TYhUllcqDhLI0zJmkFuTUdBpCS4tAnok+eBhFnmHa7AL6xee9VM48/X82651k8LRoJKCjnkNpN1V1vmS92aN4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NxttqOd3; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NxttqOd3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 31F801F000E9; Fri, 14 Aug 2026 02:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786675311; bh=WqTd6hTvZP+7jr4CnwgT2uItwEHTmJCWS0N2lOJVzwQ=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=NxttqOd3EAC4rRwNzQFauADKHZyKwAoZmPVJUKdsv69f1sc53/Ryt22QSl4pZ1tgh uoRUV2vvpp4ORqZ/r38+mcfqNaZFJPpMVAKQ6/oP7VwcLiCAn7CPD4ftgAokgjmLel /DsRVD7njV0CzB4x5uR3OXRcmf+PXikL/k1fWyDm65EAVkJLdFaLsgfr7/+SxP2wt/ o7jdVct2d0eLes/9BhUWzVx7rxiADfC4rVdx1UBVkJNaaZOeqJ1OdBNGgJRDAHZAAw yvFJMDY0V/kjM0vbpHrqVDM5mKRmECD53EcP8VyrYT2QEk8Kv9VJHiDU9T+7uCoDus GXjp6GSsXr0Og== From: sashiko-bot@kernel.org Subject: Re: [PATCH v14 10/38] phy: rockchip: usbdp: Add missing mode_change update Reply-To: sashiko-reviews@lists.linux.dev To: "Sebastian Reichel" Cc: robh@kernel.org, conor+dt@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org, olteanv@gmail.com, linux-phy@lists.infradead.org, neil.armstrong@linaro.org In-Reply-To: <20260813-rockchip-usbdp-cleanup-v14-10-b5ad9c68fa11@collabora.com> References: <20260813-rockchip-usbdp-cleanup-v14-0-b5ad9c68fa11@collabora.com> <20260813-rockchip-usbdp-cleanup-v14-10-b5ad9c68fa11@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 14 Aug 2026 02:41:50 +0000 Message-Id: <20260814024151.31F801F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 2 potential issue(= s) to consider: Pre-existing issues: - [High] Type-C state fallback to USB/Safe modes skips the PHY mode update = and HPD reset, permanently breaking USB 3.0 and leaving a ghost DisplayPort= connection. - [High] The PHY driver indefinitely leaks active power states (clocks and = resets) if the Type-C mux mode changes before the USB or DP controllers exe= cute their teardown routines. -- --- Patch [10]: [PATCH v14 10/38] phy: rockchip: usbdp: Add missing mode_ch= ange update --- commit 9bed4fa08dd116716a39f228bdd961c66a8f8b64 Author: Sebastian Reichel phy: rockchip: usbdp: Add missing mode_change update rk_udphy_set_typec_default_mapping() updates the available modes, but does not set the mode_change as required. This results in missing re-initialization and thus non-working DisplayPort. > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rock= chip/phy-rockchip-usbdp.c > index 982315535caf7..7540c897dde13 100644 > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -617,6 +617,15 @@ static void rk_udphy_dp_hpd_event_trigger(struct rk_= udphy *udphy, bool hpd) > rk_udphy_grfreg_write(udphy->vogrf, &cfg->vogrfcfg[udphy->id].hpd_trigg= er, hpd); > } > =20 > +static void rk_udphy_mode_set(struct rk_udphy *udphy, u8 mode) > +{ > + if (udphy->mode =3D=3D mode) > + return; > + > + udphy->mode_change =3D true; > + udphy->mode =3D mode; > +} [Severity: High] This isn't a bug introduced by this patch, but since we are updating how the mode is set, can this asynchronous update to udphy->mode lead to a power st= ate leak? If the Type-C subsystem asynchronously updates the requested mode via rk_udphy_typec_mux_set() (e.g., changing from UDPHY_MODE_DP_USB to UDPHY_MODE_DP), does this cause later teardown routines to fail? For example, when the USB controller suspends and calls phy_exit() or phy_power_off(), routines like rk_udphy_usb3_phy_exit() check the mode: drivers/phy/rockchip/phy-rockchip-usbdp.c:rk_udphy_usb3_phy_exit() { ... /* DP only or high-speed */ if (!(udphy->mode & UDPHY_MODE_USB) || udphy->hs) goto unlock; ... } Similarly in rk_udphy_power_off(): drivers/phy/rockchip/phy-rockchip-usbdp.c:rk_udphy_power_off() { ... if (!(udphy->mode & mode)) { dev_info(udphy->dev, "mode 0x%02x is not support\n", mode); return; } ... } Because udphy->mode has already changed, do these functions return early without clearing the USB bit from udphy->status, leaving active hardware clocks and resets leaked indefinitely? [ ... ] > @@ -1361,10 +1370,7 @@ static int rk_udphy_typec_mux_set(struct typec_mux= _dev *mux, > usleep_range(750, 800); > rk_udphy_dp_hpd_event_trigger(udphy, true); > } else if (data->status & DP_STATUS_HPD_STATE) { > - if (udphy->mode !=3D mode) { > - udphy->mode =3D mode; > - udphy->mode_change =3D true; > - } > + rk_udphy_mode_set(udphy, mode); > rk_udphy_dp_hpd_event_trigger(udphy, true); > } else { > rk_udphy_dp_hpd_event_trigger(udphy, false); [Severity: High] This is a pre-existing issue, but I have a question about the broader logic in rk_udphy_typec_mux_set() when the mode changes. When the Type-C port exits Alt Mode to a safe or USB-only state, does this skip the PHY mode update and HPD reset entirely? It looks like the vital state updates (including the new rk_udphy_mode_set() call) are gated behind an earlier check in rk_udphy_typec_mux_set(): drivers/phy/rockchip/phy-rockchip-usbdp.c:rk_udphy_typec_mux_set() { ... if (state->alt && state->alt->svid =3D=3D USB_TYPEC_DP_SID) { struct typec_displayport_data *data =3D state->data; ... } Because state->alt is NULL when exiting DisplayPort Alt Mode, this block is bypassed. Can this leave udphy->mode stuck in UDPHY_MODE_DP, potentially breaking USB 3.0 functionality and leaving a ghost DisplayPort connection? --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260813-rockchip-u= sbdp-cleanup-v14-0-b5ad9c68fa11@collabora.com?part=3D10