From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6F453515D6 for ; Fri, 14 Aug 2026 04:10:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786680659; cv=none; b=Jt1J8D4xXplVRbMig0ao3l9xSTTxThdMVUs8hVnp/81XR+U28aLyeBx27cTUj2Oz0JNCW4JaqIE8H4WZGKEDntPQd/flh2ZhQpogPaz3r+oJdGVbiKcn99OnTfsAuCiP6s97rG1DnpAKTXz3J8jjaVIUwkB7nlQuOgu4HAZZZCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786680659; c=relaxed/simple; bh=iIdwkWqkwhLUG/JN9f/lXgtwn35m3Pfg5ECEGv1TRPI=; h=From:Subject:To:Cc:In-Reply-To:References:Content-Type:Date: Message-Id; b=WAOedGd6JWeZWrRwMw+xSe8kdY5j3vIIfDHCIa1ZfEvnFpL9y+okYjRa/5OVGIhI456TPKAhm3i/XwJlnaDx30A1+Yn+clHq8dajBeSPTPEBgLzWmzw/9br2SHDIhaQEqDKtCrsRIwJPUU0BPqZ+5Y20mgxR7L9mo3gImlQdiC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NTMFrCgo; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NTMFrCgo" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A912D1F000E9; Fri, 14 Aug 2026 04:10:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786680658; bh=wsMbl8FoGh7KTn3Z4KEFN7fT7UmCwOxo9NPY6ckr9Xc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=NTMFrCgoGKYZXnCxrL862aJYndwcUpWhjyoGHILd5g9hd807s6o0mF2l2WKsHC4e/ jWtcTFL7M9ratISdzkPH1EA60TTU/xwjP/5RXzaE1Cncm1lVCt5C1/ziqF7xDjUq+k uaUFzjgaqi7g8lQOeYAGycRWWvR4OZZUguWbiGVBjlRH7hnQsBK5FosZOP81i9qhYX KHnkYm+AlsMrQ7bkeQiKnzbzbS8lLZYpSKQX/M0meOsM2HCq67rqSFhRr++f1ggI+E YbcsFl4epgBDH+8wm3LNZGF3XNugHUZVVizUjwgKFSS5sRhSvYUtr18Gt3+nsNsoZB 8xBb4WpamgHAA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v14 20/38] phy: rockchip: usbdp: Factor out lane_mux_sel setup Reply-To: sashiko-reviews@lists.linux.dev To: "Sebastian Reichel" Cc: conor+dt@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, robh@kernel.org, vkoul@kernel.org, devicetree@vger.kernel.org, olteanv@gmail.com In-Reply-To: <20260813-rockchip-usbdp-cleanup-v14-20-b5ad9c68fa11@collabora.com> References: <20260813-rockchip-usbdp-cleanup-v14-0-b5ad9c68fa11@collabora.com> <20260813-rockchip-usbdp-cleanup-v14-20-b5ad9c68fa11@collabora.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Fri, 14 Aug 2026 04:10:49 +0000 Message-Id: <20260814041052.A912D1F000E9@smtp.kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Thank you for your contribution! Sashiko AI review found 1 potential issue(= s) to consider: Pre-existing issues: - [High] Data race in `rk_udphy_dp_phy_configure` allows DP link training t= o corrupt USB PHY lanes. -- --- Patch [20]: [PATCH v14 20/38] phy: rockchip: usbdp: Factor out lane_mux= _sel setup --- commit 312855a280db1af8a51a65d7c305801cd55a506d Author: Sebastian Reichel phy: rockchip: usbdp: Factor out lane_mux_sel setup Avoid describing the USB+DP lane_mux_sel logic twice by introducing a helper function to reduce code duplication. > diff --git a/drivers/phy/rockchip/phy-rockchip-usbdp.c b/drivers/phy/rock= chip/phy-rockchip-usbdp.c > index 4b454798c4ed4..4e54020d17551 100644 > --- a/drivers/phy/rockchip/phy-rockchip-usbdp.c > +++ b/drivers/phy/rockchip/phy-rockchip-usbdp.c > @@ -582,6 +582,42 @@ static void rk_udphy_mode_set(struct rk_udphy *udphy= , u8 mode) > udphy->mode =3D mode; > } > =20 > +static void rk_udphy_set_typec_state(struct rk_udphy *udphy, unsigned lo= ng state) > +{ > + u8 mode; > + > + switch (state) { > + case TYPEC_DP_STATE_C: > + case TYPEC_DP_STATE_E: > + udphy->lane_mux_sel[0] =3D PHY_LANE_MUX_DP; > + udphy->lane_mux_sel[1] =3D PHY_LANE_MUX_DP; > + udphy->lane_mux_sel[2] =3D PHY_LANE_MUX_DP; > + udphy->lane_mux_sel[3] =3D PHY_LANE_MUX_DP; > + mode =3D UDPHY_MODE_DP; > + udphy->dp_lanes =3D 4; > + break; [Severity: High] This is a pre-existing issue, but can this code race with DisplayPort link training? If a user rapidly unplugs or rotates the Type-C cable while a display is attached and undergoing link training, the Type-C subsystem could asynchronously call rk_udphy_typec_mux_set(). This modifies lane_mux_sel and dp_lanes here in rk_udphy_set_typec_state() while holding udphy->mutex. Meanwhile, the DP MAC driver might be calling phy_configure() to perform link training, which invokes rk_udphy_dp_phy_configure(): drivers/phy/rockchip/phy-rockchip-usbdp.c:rk_udphy_dp_phy_configure() { ... for (i =3D 0; i < udphy->lanes; i++) { lane =3D udphy->dp_lane_sel[i]; switch (udphy->link_rate) { case 1620: case 2700: regmap_update_bits(udphy->pma_regmap, TRSV_ANA_TX_CLK_OFFSET_N(lane), LN_ANA_TX_SER_TXCLK_INV, FIELD_PREP(LN_ANA_TX_SER_TXCLK_INV, udphy->lane_mux_sel[lane])); ... } If rk_udphy_dp_phy_configure() locklessly verifies dp->lanes <=3D udphy->dp= _lanes and loops over udphy->lanes, could it read a torn lane_mux_sel array or a s= tale dp_lanes value? This might result in applying DisplayPort voltages to PHY l= anes that have just been reassigned to USB, potentially corrupting the USB link = and leaving the PHY in an inconsistent state. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260813-rockchip-u= sbdp-cleanup-v14-0-b5ad9c68fa11@collabora.com?part=3D20 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41E42C5CFCF for ; Fri, 14 Aug 2026 04:11:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: References:In-Reply-To:Cc:To:Subject:From:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+wGv3UC+MUzw2HdUEJffIN9GMmdnb7ESGGyMYmie6Xg=; b=a7hqJPb/gK6D4c Gzka1krYRD4N88zLGpp48gyvWKQaK0mirFeId8Yva36Y5a2glqN4REJddVbx5E9uNzGM3BJejEweL tOR46B49/SrkA2wheACUGXhbnDtEZQNm7koITGX9pamFB5DxxDPZFJ18EqMxhDY0DKVcrNOJtdx4m nJ0v+1Nmqry/fPloQ2OCH0K9t/isLuzFUMHHIENG+PPJzjKya67Q964T68/zN8Rp7P2Gy26YQ3K89 9VwJoCJbkMNK8rKOA2iL0jnMw+Ls4rCf2VI4SzdjyeJLZ4V+P3GMokhjGUaNpK+dQYpwYw2GkND/m tpucXrZ3ftHWW/Ta3JUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wujG2-00000001vSN-0tMc; Fri, 14 Aug 2026 04:11:02 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wujG1-00000001vSH-0vG3 for linux-phy@lists.infradead.org; Fri, 14 Aug 2026 04:11:01 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 6A2EF43A57; Fri, 14 Aug 2026 04:10:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A912D1F000E9; Fri, 14 Aug 2026 04:10:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786680658; bh=wsMbl8FoGh7KTn3Z4KEFN7fT7UmCwOxo9NPY6ckr9Xc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=NTMFrCgoGKYZXnCxrL862aJYndwcUpWhjyoGHILd5g9hd807s6o0mF2l2WKsHC4e/ jWtcTFL7M9ratISdzkPH1EA60TTU/xwjP/5RXzaE1Cncm1lVCt5C1/ziqF7xDjUq+k uaUFzjgaqi7g8lQOeYAGycRWWvR4OZZUguWbiGVBjlRH7hnQsBK5FosZOP81i9qhYX KHnkYm+AlsMrQ7bkeQiKnzbzbS8lLZYpSKQX/M0meOsM2HCq67rqSFhRr++f1ggI+E YbcsFl4epgBDH+8wm3LNZGF3XNugHUZVVizUjwgKFSS5sRhSvYUtr18Gt3+nsNsoZB 8xBb4WpamgHAA== From: sashiko-bot@kernel.org Subject: Re: [PATCH v14 20/38] phy: rockchip: usbdp: Factor out lane_mux_sel setup To: "Sebastian Reichel" Cc: conor+dt@kernel.org, neil.armstrong@linaro.org, linux-phy@lists.infradead.org, robh@kernel.org, vkoul@kernel.org, devicetree@vger.kernel.org, olteanv@gmail.com In-Reply-To: <20260813-rockchip-usbdp-cleanup-v14-20-b5ad9c68fa11@collabora.com> References: <20260813-rockchip-usbdp-cleanup-v14-0-b5ad9c68fa11@collabora.com> <20260813-rockchip-usbdp-cleanup-v14-20-b5ad9c68fa11@collabora.com> Date: Fri, 14 Aug 2026 04:10:49 +0000 Message-Id: <20260814041052.A912D1F000E9@smtp.kernel.org> X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwgaXNzdWUocykgdG8gY29uc2lkZXI6CgpQcmUtZXhpc3RpbmcgaXNzdWVzOgot IFtIaWdoXSBEYXRhIHJhY2UgaW4gYHJrX3VkcGh5X2RwX3BoeV9jb25maWd1cmVgIGFsbG93cyBE UCBsaW5rIHRyYWluaW5nIHRvIGNvcnJ1cHQgVVNCIFBIWSBsYW5lcy4KLS0KCi0tLSBQYXRjaCBb MjBdOiBbUEFUQ0ggdjE0IDIwLzM4XSBwaHk6IHJvY2tjaGlwOiB1c2JkcDogRmFjdG9yIG91dCBs YW5lX211eF9zZWwgc2V0dXAgLS0tCmNvbW1pdCAzMTI4NTVhMjgwZGIxYWY4YTUxYTY1ZDdjMzA1 ODAxY2Q1NWE1MDZkCkF1dGhvcjogU2ViYXN0aWFuIFJlaWNoZWwgPHNlYmFzdGlhbi5yZWljaGVs QGNvbGxhYm9yYS5jb20+CgpwaHk6IHJvY2tjaGlwOiB1c2JkcDogRmFjdG9yIG91dCBsYW5lX211 eF9zZWwgc2V0dXAKCkF2b2lkIGRlc2NyaWJpbmcgdGhlIFVTQitEUCBsYW5lX211eF9zZWwgbG9n aWMgdHdpY2UgYnkgaW50cm9kdWNpbmcKYSBoZWxwZXIgZnVuY3Rpb24gdG8gcmVkdWNlIGNvZGUg ZHVwbGljYXRpb24uCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9j a2NoaXAtdXNiZHAuYyBiL2RyaXZlcnMvcGh5L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC11c2JkcC5j Cj4gaW5kZXggNGI0NTQ3OThjNGVkNC4uNGU1NDAyMGQxNzU1MSAxMDA2NDQKPiAtLS0gYS9kcml2 ZXJzL3BoeS9yb2NrY2hpcC9waHktcm9ja2NoaXAtdXNiZHAuYwo+ICsrKyBiL2RyaXZlcnMvcGh5 L3JvY2tjaGlwL3BoeS1yb2NrY2hpcC11c2JkcC5jCj4gQEAgLTU4Miw2ICs1ODIsNDIgQEAgc3Rh dGljIHZvaWQgcmtfdWRwaHlfbW9kZV9zZXQoc3RydWN0IHJrX3VkcGh5ICp1ZHBoeSwgdTggbW9k ZSkKPiAgCXVkcGh5LT5tb2RlID0gbW9kZTsKPiAgfQo+ICAKPiArc3RhdGljIHZvaWQgcmtfdWRw aHlfc2V0X3R5cGVjX3N0YXRlKHN0cnVjdCBya191ZHBoeSAqdWRwaHksIHVuc2lnbmVkIGxvbmcg c3RhdGUpCj4gK3sKPiArCXU4IG1vZGU7Cj4gKwo+ICsJc3dpdGNoIChzdGF0ZSkgewo+ICsJY2Fz ZSBUWVBFQ19EUF9TVEFURV9DOgo+ICsJY2FzZSBUWVBFQ19EUF9TVEFURV9FOgo+ICsJCXVkcGh5 LT5sYW5lX211eF9zZWxbMF0gPSBQSFlfTEFORV9NVVhfRFA7Cj4gKwkJdWRwaHktPmxhbmVfbXV4 X3NlbFsxXSA9IFBIWV9MQU5FX01VWF9EUDsKPiArCQl1ZHBoeS0+bGFuZV9tdXhfc2VsWzJdID0g UEhZX0xBTkVfTVVYX0RQOwo+ICsJCXVkcGh5LT5sYW5lX211eF9zZWxbM10gPSBQSFlfTEFORV9N VVhfRFA7Cj4gKwkJbW9kZSA9IFVEUEhZX01PREVfRFA7Cj4gKwkJdWRwaHktPmRwX2xhbmVzID0g NDsKPiArCQlicmVhazsKCltTZXZlcml0eTogSGlnaF0KVGhpcyBpcyBhIHByZS1leGlzdGluZyBp c3N1ZSwgYnV0IGNhbiB0aGlzIGNvZGUgcmFjZSB3aXRoIERpc3BsYXlQb3J0IGxpbmsKdHJhaW5p bmc/CgpJZiBhIHVzZXIgcmFwaWRseSB1bnBsdWdzIG9yIHJvdGF0ZXMgdGhlIFR5cGUtQyBjYWJs ZSB3aGlsZSBhIGRpc3BsYXkgaXMKYXR0YWNoZWQgYW5kIHVuZGVyZ29pbmcgbGluayB0cmFpbmlu ZywgdGhlIFR5cGUtQyBzdWJzeXN0ZW0gY291bGQKYXN5bmNocm9ub3VzbHkgY2FsbCBya191ZHBo eV90eXBlY19tdXhfc2V0KCkuIFRoaXMgbW9kaWZpZXMgbGFuZV9tdXhfc2VsIGFuZApkcF9sYW5l cyBoZXJlIGluIHJrX3VkcGh5X3NldF90eXBlY19zdGF0ZSgpIHdoaWxlIGhvbGRpbmcgdWRwaHkt Pm11dGV4LgoKTWVhbndoaWxlLCB0aGUgRFAgTUFDIGRyaXZlciBtaWdodCBiZSBjYWxsaW5nIHBo eV9jb25maWd1cmUoKSB0byBwZXJmb3JtCmxpbmsgdHJhaW5pbmcsIHdoaWNoIGludm9rZXMgcmtf dWRwaHlfZHBfcGh5X2NvbmZpZ3VyZSgpOgoKZHJpdmVycy9waHkvcm9ja2NoaXAvcGh5LXJvY2tj aGlwLXVzYmRwLmM6cmtfdWRwaHlfZHBfcGh5X2NvbmZpZ3VyZSgpIHsKLi4uCgkJZm9yIChpID0g MDsgaSA8IHVkcGh5LT5sYW5lczsgaSsrKSB7CgkJCWxhbmUgPSB1ZHBoeS0+ZHBfbGFuZV9zZWxb aV07CgkJCXN3aXRjaCAodWRwaHktPmxpbmtfcmF0ZSkgewoJCQljYXNlIDE2MjA6CgkJCWNhc2Ug MjcwMDoKCQkJCXJlZ21hcF91cGRhdGVfYml0cyh1ZHBoeS0+cG1hX3JlZ21hcCwKCQkJCQkJICAg VFJTVl9BTkFfVFhfQ0xLX09GRlNFVF9OKGxhbmUpLAoJCQkJCQkgICBMTl9BTkFfVFhfU0VSX1RY Q0xLX0lOViwKCQkJCQkJICAgRklFTERfUFJFUChMTl9BTkFfVFhfU0VSX1RYQ0xLX0lOViwKCQkJ CQkJICAgdWRwaHktPmxhbmVfbXV4X3NlbFtsYW5lXSkpOwouLi4KfQoKSWYgcmtfdWRwaHlfZHBf cGh5X2NvbmZpZ3VyZSgpIGxvY2tsZXNzbHkgdmVyaWZpZXMgZHAtPmxhbmVzIDw9IHVkcGh5LT5k cF9sYW5lcwphbmQgbG9vcHMgb3ZlciB1ZHBoeS0+bGFuZXMsIGNvdWxkIGl0IHJlYWQgYSB0b3Ju IGxhbmVfbXV4X3NlbCBhcnJheSBvciBhIHN0YWxlCmRwX2xhbmVzIHZhbHVlPyBUaGlzIG1pZ2h0 IHJlc3VsdCBpbiBhcHBseWluZyBEaXNwbGF5UG9ydCB2b2x0YWdlcyB0byBQSFkgbGFuZXMKdGhh dCBoYXZlIGp1c3QgYmVlbiByZWFzc2lnbmVkIHRvIFVTQiwgcG90ZW50aWFsbHkgY29ycnVwdGlu ZyB0aGUgVVNCIGxpbmsgYW5kCmxlYXZpbmcgdGhlIFBIWSBpbiBhbiBpbmNvbnNpc3RlbnQgc3Rh dGUuCgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNo c2V0LzIwMjYwODEzLXJvY2tjaGlwLXVzYmRwLWNsZWFudXAtdjE0LTAtYjVhZDljNjhmYTExQGNv bGxhYm9yYS5jb20/cGFydD0yMAoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5 QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtcGh5Cg==