From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 96C1C33938B for ; Fri, 14 Aug 2026 06:32:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786689138; cv=none; b=U9yJm/HCs95tVSV8PeWIWKkytkj8VFmwdJ2NMO0Mq4uJB2HSfMsxT2ClBL4WjTtu1KGMwnXT6mqpjMouVRD4K+vdTWNFU2a4v6qsm1ceV7S2ZrhcDMjjt2uDxaEtKg3goPWFbJvH7rtOmsZoRLxKojnKxcREavHTiclvuRYY6QI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786689138; c=relaxed/simple; bh=BiqXUxOAimfUnEO3pizTpA5IhqZqr2LRtgr1VUm4A8g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F7jE60nyP0x+pIwYIVAgh9/JP2H6yQON1LUlG4SoHNFJJNwmZiFOGOtoJjT9brtB8bzCb4aBHuJ2CO0S3DjjLPycI55osIxiIS17c6hy15X6uKGaPbigBDeCrfE/x1nN5mOUyWhGcpHPfpXHzaIvXHgZpRky021YeRRD3wqzuCI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lmvaG7YX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lmvaG7YX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E8DF1F00A3E; Fri, 14 Aug 2026 06:32:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786689136; bh=29yrWh05NMYzdonMP6seb06QiUpdL/Jeq3kYqy8hITA=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lmvaG7YX4xIFxbK3P4Kn0CDaw6C8CL+YhQa2jxbt/TYAHKMgJ1Ls0TsKStfAjrs+o MT6+AFWR2vsupqhG/vNFBby5Ij0+9+/LheLWf1JH+xHCvMrS1Vf1jhDNoOvKze50Td hPId9Yr6EjDcXQqh4teOIdAn77xZGJdnqOtZhiX6PbNGAIT0QogtRgzn9BKDxWEG72 Ts/LorQvKNGOAFzN7GchrIwih40TrzImXWg+LxiLDjiOl31O1M80A4wswSsSG2UdZQ 0kIaqw7rIM65X744F5VUlShNk3JgdW2oXw7owgThxGX/W1Hu4ltvyFuFAYcTa9ZsZb 2fIJkTPUbceTg== From: Damien Le Moal To: Jens Axboe , linux-block@vger.kernel.org Cc: Christoph Hellwig Subject: [PATCH v4 03/13] block: refactor disk_update_zone_resources() Date: Fri, 14 Aug 2026 15:31:51 +0900 Message-ID: <20260814063201.1762743-4-dlemoal@kernel.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260814063201.1762743-1-dlemoal@kernel.org> References: <20260814063201.1762743-1-dlemoal@kernel.org> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Since the function disk_update_zone_resources() does a lot of checks beside updating a zoned disk limits and resources, rename this function to disk_revalidate_zone_resources(). To keep all checks together, move the capacity check in blk_revalidate_disk_zones() to this function and simplify it by moving the check on the number of zones before the call to queue_limits_start_update(). Signed-off-by: Damien Le Moal Reviewed-by: Bart Van Assche Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- block/blk-zoned.c | 46 +++++++++++++++++++--------------------------- 1 file changed, 19 insertions(+), 27 deletions(-) diff --git a/block/blk-zoned.c b/block/blk-zoned.c index 0c298fefecf8..f96953befcb6 100644 --- a/block/blk-zoned.c +++ b/block/blk-zoned.c @@ -2038,11 +2038,11 @@ static int disk_init_revalidate_args(struct gendisk *disk, } /* - * Update the disk zone resources information and device queue limits. - * The disk queue is frozen when this is executed. + * Revalidate and update the disk zone resources information and device queue + * limits. */ -static int disk_update_zone_resources(struct gendisk *disk, - struct blk_revalidate_zone_args *args) +static int disk_revalidate_zone_resources(struct gendisk *disk, + struct blk_revalidate_zone_args *args) { struct request_queue *q = disk->queue; unsigned int nr_seq_zones; @@ -2050,19 +2050,24 @@ static int disk_update_zone_resources(struct gendisk *disk, struct queue_limits lim; int ret = 0; + /* Make sure that the entire disk capacity has been checked. */ + if (args->sector != get_capacity(disk)) { + pr_warn("%s: Missing zones from sector %llu\n", + disk->disk_name, args->sector); + return -ENODEV; + } + + if (args->nr_conv_zones >= args->nr_zones) { + pr_warn("%s: Invalid number of conventional zones %u / %u\n", + disk->disk_name, args->nr_conv_zones, args->nr_zones); + return -ENODEV; + } + lim = queue_limits_start_update(q); memflags = blk_mq_freeze_queue(q); disk->nr_zones = args->nr_zones; - if (args->nr_conv_zones >= disk->nr_zones) { - queue_limits_cancel_update(q); - pr_warn("%s: Invalid number of conventional zones %u / %u\n", - disk->disk_name, args->nr_conv_zones, disk->nr_zones); - ret = -ENODEV; - goto unfreeze; - } - disk->zone_capacity = args->zone_capacity; disk->last_zone_capacity = args->last_zone_capacity; disk_set_zones_cond_array(disk, args->zones_cond); @@ -2106,7 +2111,6 @@ static int disk_update_zone_resources(struct gendisk *disk, commit: ret = queue_limits_commit_update(q, &lim); -unfreeze: blk_mq_unfreeze_queue(q, memflags); return ret; @@ -2301,7 +2305,6 @@ int blk_revalidate_disk_zones(struct gendisk *disk) { struct request_queue *q = disk->queue; sector_t zone_sectors = q->limits.chunk_sectors; - sector_t capacity = get_capacity(disk); struct blk_revalidate_zone_args args = { }; struct blk_report_zones_args rep_args = { .cb = blk_revalidate_zone_cb, @@ -2313,7 +2316,7 @@ int blk_revalidate_disk_zones(struct gendisk *disk) if (WARN_ON_ONCE(!blk_queue_is_zoned(q))) return -EIO; - if (!capacity) + if (!get_capacity(disk)) return -ENODEV; /* @@ -2357,18 +2360,7 @@ int blk_revalidate_disk_zones(struct gendisk *disk) if (ret <= 0) goto free_args; - /* - * If zones where reported, make sure that the entire disk capacity - * has been checked. - */ - if (args.sector != capacity) { - pr_warn("%s: Missing zones from sector %llu\n", - disk->disk_name, args.sector); - ret = -ENODEV; - goto free_args; - } - - ret = disk_update_zone_resources(disk, &args); + ret = disk_revalidate_zone_resources(disk, &args); if (ret) goto free_args; -- 2.55.0