Re: [PATCH v4 1/4] dt-bindings: pinctrl: add Ambarella CV75 pinctrl

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The binding schema prevents configuring bias and drive strength for GPIO pins because 'function' is strictly required (with no 'gpio' option), the 'groups' enum lacks GPIO options, and the 'pins' property is forbidden.
--

--- Patch [1]: [PATCH v4 1/4] dt-bindings: pinctrl: add Ambarella CV75 pinctrl ---
commit a8e38fe4533be470b102e4e747568db3d0143b1a
Author: Long Zhao <longzhao@ambarella.com>

dt-bindings: pinctrl: add Ambarella CV75 pinctrl

Document the CV75 pin controller binding using generic function and
groups properties for pinmux configuration.

> diff --git a/Documentation/devicetree/bindings/pinctrl/ambarella,cv75-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/ambarella,cv75-pinctrl.yaml
> new file mode 100644
> index 0000000000000..9d65da32d3d28
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/pinctrl/ambarella,cv75-pinctrl.yaml
[ ... ]
> +patternProperties:
> +  "^[a-z0-9-]+-pins$":
> +    type: object
> +    allOf:
> +      - $ref: pinmux-node.yaml#
> +      - $ref: pincfg-node.yaml#
> +    additionalProperties: false

[Severity: Medium]
Will this combination of 'additionalProperties: false' and omitting a
definition for 'pins' prevent configuring individual pins?

This appears to reject the standard 'pins' property, meaning users cannot
specify pin-level configurations for GPIOs.

> +
> +    properties:
> +      function:
[ ... ]
> +      drive-strength:
> +        enum: [3, 4, 5, 6, 7, 8, 9, 12]
> +
> +    required:
> +      - function
> +      - groups

[Severity: Medium]
Does requiring both 'function' and 'groups' unconditionally prevent 
config-only nodes, such as configuring bias or drive strength for individual 
GPIO pins?

Since 'gpio' is not an option in the 'function' enum, and 'pins' is blocked 
by the earlier 'additionalProperties: false', it seems impossible to define a 
valid node for GPIO configuration without incorrectly multiplexing the pin to a 
peripheral function.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260814-cv75-v4-b-v4-0-ef2e83ec0eac@ambarella.com?part=1