Re: [PATCH 06/17] arm64: dts: imx93-14x14-evk: Add board muxes to select between FlexCAN1 and MQS1

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Incomplete device tree wiring for board muxes. The newly added pinctrl mux states (`can1_fun`, `mqs1_fun`, `mqs1_amp_en`) are defined but never referenced by any consumer device node (such as `flexcan1`), rendering the board mux configuration functionally dead code.
--

--- Patch [6]: [PATCH 06/17] arm64: dts: imx93-14x14-evk: Add board muxes to select between FlexCAN1 and MQS1 ---
commit adc8546ef31dc705c01516aa1b8dc15eb6eaa575
Author: Chancel Liu <chancel.liu@nxp.com>

arm64: dts: imx93-14x14-evk: Add board muxes to select between FlexCAN1 and MQS1

This commit adds GPIO-controlled board muxes to resolve a pin conflict
between FlexCAN1 and MQS1 on the imx93-14x14-evk board. It defines the
mux controllers and their corresponding pinctrl states.

> diff --git a/arch/arm64/boot/dts/freescale/imx93-14x14-evk.dts b/arch/arm64/boot/dts/freescale/imx93-14x14-evk.dts
> index ec78c03f4788b..502237fab3324 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-14x14-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-14x14-evk.dts
[ ... ]
> +	pinctrl-gpiomux {
> +		compatible = "pinctrl-multiplexer";
> +
> +		can1_fun: can1-grp {
> +			mux-states = <&can1_mqs1_mux 0>;
> +		};
> +
> +		mqs1_amp_en: mqs1-amp-en-grp {
> +			mux-states = <&mqs1_amp_en_mux 1>;
> +		};
> +
> +		mqs1_fun: mqs1-grp {
> +			mux-states = <&can1_mqs1_mux 1>;
> +		};
> +	};

[Severity: Medium]
Are these new pinctrl mux states missing references from their consumer device
nodes?

The can1_fun, mqs1_amp_en, and mqs1_fun states are defined here, but they
don't appear to be referenced by the flexcan1 or mqs1 device nodes.

For example, if the active flexcan1 device node doesn't include <&can1_fun>
in its pinctrl-0 list, won't this configuration remain unapplied and fail to
resolve the hardware routing?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260814072022.4064009-1-chancel.liu@oss.nxp.com?part=6