All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Damien Le Moal <dlemoal@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Subject: Re: [PATCH v4 13/13] block: flag zoned disks with GENHD_FL_NO_PART
Date: Fri, 14 Aug 2026 10:12:05 +0200	[thread overview]
Message-ID: <20260814081205.GH12566@lst.de> (raw)
In-Reply-To: <20260814063201.1762743-14-dlemoal@kernel.org>

On Fri, Aug 14, 2026 at 03:32:01PM +0900, Damien Le Moal wrote:
> Zoned block devices do not support partitions. However, the partition
> table is nevertheless still inspected, and any partition found ignored
> with a warning in add_partition(). While this is generally not a problem,
> and in fact beneficial to the user as it indicates an invalid use of a
> zoned block device, scanning for a partition table on the device may
> result in issuing read operations to offline zones (e.g. after a disk head
> is depopulated for disks that support head management operations).
> 
> Since partitions are ignored anyway, completely disable partition scanning
> for zoned gendisks by setting the flag GENHD_FL_NO_PART in __add_disk().
> The existing check in add_partition() is left as-is to ensure that we
> still get a warning if for whatever reason, despite GENHD_FL_NO_PART, we
> still endup trying to add partitions.
> 
> Flagging zoned disks with GENHD_FL_NO_PART also has the benefit to expose
> through sysfs the ext_range attribute with the value of 1 instead of the
> default DISK_MAX_PARTS, thus correctly advertizing the fact that zoned
> disks do not support partitions.
> 
> Signed-off-by: Damien Le Moal <dlemoal@kernel.org>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> Reviewed-by: Hannes Reinecke <hare@kernel.org>

This really should get a Fixes for my original patch that skipped
partitions and go to -stable (and into 7.3 even if Jens won't take
the whole series) as it causes totally pointless I/O.  I also suspect
the partition scanning and blkid interaction might be related to some
of the weirdo xfstests failure I see where blkid doesn't detect
xfs file systems in synthetic devices.

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2026-08-14  8:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14  6:31 [PATCH v4 00/13] Improve handling of offline and read-only zones Damien Le Moal
2026-08-14  6:31 ` [PATCH v4 01/13] block: remove disk_free_zone_resources() Damien Le Moal
2026-08-14  6:31 ` [PATCH v4 02/13] block: refactor disk_revalidate_zone_resources() Damien Le Moal
2026-08-14  6:31 ` [PATCH v4 03/13] block: refactor disk_update_zone_resources() Damien Le Moal
2026-08-14  6:31 ` [PATCH v4 04/13] block: remember a zone type regardless of its condition Damien Le Moal
2026-08-14  7:30   ` Christoph Hellwig
2026-08-14  6:31 ` [PATCH v4 05/13] block: refactor bdev_zone_is_seq() Damien Le Moal
2026-08-14  7:31   ` Christoph Hellwig
2026-08-14  6:31 ` [PATCH v4 06/13] block: introduce disk_for_all_zone_wplugs() Damien Le Moal
2026-08-14  8:04   ` Christoph Hellwig
2026-08-14  6:31 ` [PATCH v4 07/13] block: drop all zone write plugs on capacity changes Damien Le Moal
2026-08-14  8:05   ` Christoph Hellwig
2026-08-14  6:31 ` [PATCH v4 08/13] block: propagate readonly and offline conditions to zone write plugs Damien Le Moal
2026-08-14  8:05   ` Christoph Hellwig
2026-08-14  6:31 ` [PATCH v4 09/13] block: always treat offline and read-only zones as dead Damien Le Moal
2026-08-14  8:06   ` Christoph Hellwig
2026-08-14  6:31 ` [PATCH v4 10/13] block: fail zone management operations to read-only and offline zones Damien Le Moal
2026-08-14  8:08   ` Christoph Hellwig
2026-08-14  8:25     ` Damien Le Moal
2026-08-14  6:31 ` [PATCH v4 11/13] block: allow read-only and offline conventional zones Damien Le Moal
2026-08-14  8:08   ` Christoph Hellwig
2026-08-14  6:32 ` [PATCH v4 12/13] block: simplify disk_zone_set_cond() Damien Le Moal
2026-08-14  8:10   ` Christoph Hellwig
2026-08-14  6:32 ` [PATCH v4 13/13] block: flag zoned disks with GENHD_FL_NO_PART Damien Le Moal
2026-08-14  8:12   ` Christoph Hellwig [this message]
2026-08-14  8:26     ` Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260814081205.GH12566@lst.de \
    --to=hch@lst.de \
    --cc=axboe@kernel.dk \
    --cc=dlemoal@kernel.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.