From: Ivan Vecera <ivecera@redhat.com>
To: netdev@vger.kernel.org
Cc: Arkadiusz Kubalewski <arkadiusz.kubalewski@intel.com>,
Jakub Kicinski <kuba@kernel.org>, Jiri Pirko <jiri@resnulli.us>,
Min Li <min.li@microchip.com>, Paolo Abeni <pabeni@redhat.com>,
Petr Oros <poros@redhat.com>,
Richard Cochran <richardcochran@gmail.com>,
Vadim Fedorenko <vadim.fedorenko@linux.dev>,
linux-kernel@vger.kernel.org
Subject: [PATCH net-next v8 0/3] dpll: zl3073x: add PTP clock support
Date: Fri, 14 Aug 2026 10:26:53 +0200 [thread overview]
Message-ID: <20260814082656.306534-1-ivecera@redhat.com> (raw)
Add PTP hardware clock support to the zl3073x DPLL driver.
Patch 1 scales the poll sleep interval in zl3073x_poll_zero_u8()
proportionally to the timeout to avoid excessive bus traffic for
the longer PTP-related timeouts.
Patch 2 adds low-level channel operations for ToD read/write/adjust,
output phase step, delta frequency offset write and TIE write as
building blocks for PTP callbacks.
Patch 3 registers a PTP clock device for each DPLL channel with
gettimex64, settime64, adjtime, adjfine, adjphase and getmaxphase
callbacks. Callback availability adapts to the current channel
state - adjfine requires NCO pin connected, adjphase uses TIE write
when tracking a reference, and adjtime selects the appropriate
mechanism automatically. Periodic output support will be added in a
follow-up series.
Link: https://lore.kernel.org/netdev/20260811134700.1211010-1-ivecera@redhat.com/
Link: https://lore.kernel.org/netdev/20260807094430.120683-1-ivecera@redhat.com/
Link: https://lore.kernel.org/netdev/20260803140637.102339-1-ivecera@redhat.com/
Link: https://lore.kernel.org/netdev/20260730132150.371376-1-ivecera@redhat.com/
Link: https://lore.kernel.org/netdev/20260713103739.1553284-1-ivecera@redhat.com/
Link: https://lore.kernel.org/netdev/20260708170527.916035-1-ivecera@redhat.com/
Changes:
v8:
- Drop WARN_ON from tod_ready_wait default case and drop tie_write
range guard entirely (Vadim)
- Use timespec64_valid_settod() in tod_adjust (Vadim)
v7:
- Check SEM bit before CMD in tod_ready_wait so stale CMD bits
from a prior boot stage do not block ToD operations
- Move ptp_info template assignment from alloc to register to
avoid stale getcycles64 pointers on devlink reload
- Update kernel-doc for tod_ready_wait, adjtime, adjtime_phase_step
and tie_write to match actual return semantics
- Update poll interval changelog to mention effect on all callers
v6:
- Fix kernel-doc warning: move ZL_TOD_MAX_RETRIES define inside
the function body to avoid confusing the kernel-doc parser
v5:
- Add prep patch to scale poll interval with timeout
- Enumerate all ToD commands in tod_ready_wait switch, return
-EOPNOTSUPP with WARN_ON in default case (Vadim)
- Handle CMD=0 (power-on default) in tod_ready_wait
- Rewrite tod_adjust rollover guard as a retry loop that re-reads
until the margin is sufficient, replacing manual fixup and fsleep
- Fix "lowest-ID synth" comments to "first enabled synth"
- Include dev_name() in PTP clock name for multi-device systems
- Update kernel-doc for adjfine/adjphase to document zero no-op
v4:
- Move out_step_time_mask to struct zl3073x_dev (device-global)
- Fix tod_adjust rollover guard for tick-crossing case
- Drop trailing tod_ready_wait from tod_adjust
- Fix TOD_CTRL register item count
- Move phase step registers into existing page 9 section in regs.h
- Align ToD command define values
- Update kernel-doc for chan_state_fetch
- Drop perout support (will rework as follow-up)
- Replace abs(delta) with explicit range check to avoid S64_MIN UB
- Add locking context doc to zl3073x_chan_df_offset_set
- Export zl3073x_chan_tod_ready_wait and wait for ToD completion in
adjtime before phase step/TIE write to prevent WR_NEXT_1HZ from
overwriting the sub-second adjustment
v3:
- Use PTP_1588_CLOCK instead of PTP_1588_CLOCK_OPTIONAL (Jakub)
- Factor out output pin frequency helper to a separate commit (Jakub)
- Remove spurious #include <linux/mutex.h> from dpll.h (Jakub)
v2:
- Squash low-level ops patches (1+3) into patch 1.
- Squash PTP callback patches (2+4) into patch 2, register PTP
clock regardless of initial channel state.
Ivan Vecera (3):
dpll: zl3073x: scale poll interval proportionally to timeout
dpll: zl3073x: add channel ToD, phase step and TIE operations
dpll: zl3073x: add PTP clock support
drivers/dpll/zl3073x/Kconfig | 6 +-
drivers/dpll/zl3073x/chan.c | 321 ++++++++++++++++++++++++-
drivers/dpll/zl3073x/chan.h | 32 +++
drivers/dpll/zl3073x/core.c | 17 +-
drivers/dpll/zl3073x/core.h | 23 ++
drivers/dpll/zl3073x/dpll.c | 439 +++++++++++++++++++++++++++++++++--
drivers/dpll/zl3073x/dpll.h | 5 +
drivers/dpll/zl3073x/regs.h | 52 +++++
8 files changed, 863 insertions(+), 32 deletions(-)
base-commit: 4f93b12cf7b25fbf8e73d222722805b049f0a6d3
--
2.54.0
next reply other threads:[~2026-08-14 8:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 8:26 Ivan Vecera [this message]
2026-08-14 8:26 ` [PATCH net-next v8 1/3] dpll: zl3073x: scale poll interval proportionally to timeout Ivan Vecera
2026-08-14 8:26 ` [PATCH net-next v8 2/3] dpll: zl3073x: add channel ToD, phase step and TIE operations Ivan Vecera
2026-08-16 14:47 ` Ivan Vecera
2026-08-18 16:37 ` Jakub Kicinski
2026-08-18 16:51 ` Jakub Kicinski
2026-08-14 8:26 ` [PATCH net-next v8 3/3] dpll: zl3073x: add PTP clock support Ivan Vecera
2026-08-16 14:52 ` Ivan Vecera
2026-08-18 16:37 ` Jakub Kicinski
2026-08-18 17:00 ` [PATCH net-next v8 0/3] " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260814082656.306534-1-ivecera@redhat.com \
--to=ivecera@redhat.com \
--cc=arkadiusz.kubalewski@intel.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=min.li@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=poros@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.