All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Costa Shulyupin <costa.shul@redhat.com>
Cc: "John Kacur" <jkacur@redhat.com>,
	"Ahmed S. Darwish" <darwi@linutronix.de>,
	"Thomas Weißschuh (Schneider Electric)"
	<thomas.weissschuh@linutronix.de>,
	"Lukas Beckmann" <lbckmnn@mailbox.org>,
	"Cheng-Yang Chou" <yphbchou0911@gmail.com>,
	linux-rt-users <linux-rt-users@vger.kernel.org>
Subject: Re: [PATCH v2] cyclictest, cyclicdeadline: Exit with failure when breaktrace threshold is exceeded
Date: Fri, 14 Aug 2026 11:08:01 +0200	[thread overview]
Message-ID: <20260814090801.lZ8dlRaB@linutronix.de> (raw)
In-Reply-To: <20260806120732.1371118-1-costa.shul@redhat.com>

On 2026-08-06 15:07:31 [+0300], Costa Shulyupin wrote:
> cyclictest and cyclicdeadline always exit 0 even when the latency
> threshold set by --breaktrace is exceeded, requiring test harnesses
> to parse output or json to detect a failed test.
> 
> Set ret to EXIT_FAILURE when break_thread_id is set, indicating the

This is misleading because 1 is also returned if you use the wrong
options, are now allowed to use the higher priority. You can't set it to
failure and claim in the docs that the threshold has been reach. This
might have happen, there might be another reason.

Why not pick a dedicated exit code value for this scenario and document
it as such and use it for this purpose only.

> breaktrace threshold was hit.  The exit code enables shell expressions
> like "cyclictest ... && echo PASS" and seamless integration with testing
> frameworks.  Also pass ret to rt_write_json() in cyclicdeadline so the
> JSON output reflects the failure.
> 
> Assisted-by: Claude:claude-opus-4-6
> Signed-off-by: Costa Shulyupin <costa.shul@redhat.com>

Sebastian

      reply	other threads:[~2026-08-14  9:08 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06 12:07 [PATCH v2] cyclictest, cyclicdeadline: Exit with failure when breaktrace threshold is exceeded Costa Shulyupin
2026-08-14  9:08 ` Sebastian Andrzej Siewior [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260814090801.lZ8dlRaB@linutronix.de \
    --to=bigeasy@linutronix.de \
    --cc=costa.shul@redhat.com \
    --cc=darwi@linutronix.de \
    --cc=jkacur@redhat.com \
    --cc=lbckmnn@mailbox.org \
    --cc=linux-rt-users@vger.kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=yphbchou0911@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.