All of lore.kernel.org
 help / color / mirror / Atom feed
From: linuxtestproject.agent@gmail.com
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] struct tst_fs: Add flag for checking filesystem mount support in kernel
Date: Fri, 14 Aug 2026 13:05:28 +0000	[thread overview]
Message-ID: <20260814130528.8519-1-linuxtestproject.agent@gmail.com> (raw)
In-Reply-To: <20260814124943.36853-2-mdoucha@suse.cz>

Hi Martin,

On Fri, 14 Aug 2026, Martin Doucha wrote:
> struct tst_fs: Add flag for checking filesystem mount support in kernel

--- [PATCH 1/3] ---

> -	       const void *data, int *is_fuse);
> +	       const void *data, int *is_fuse, unsigned int check_support);

Could safe_mount() and SAFE_MOUNT2() gain kernel-doc comments that describe
the new check_support argument and the resulting TCONF behavior? These are
modified public APIs in include/ and lib/.

Verdict - Needs revision

---
Note:

The agent can sometimes produce false positives although often its
findings are genuine. If you find issues with the review, please
comment this email or ignore the suggestions.

Regards,
LTP AI Reviewer

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  reply	other threads:[~2026-08-14 13:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 12:49 [LTP] [PATCH 0/3] Add optional kernel support checks for filesystem features Martin Doucha
2026-08-14 12:49 ` [LTP] [PATCH 1/3] struct tst_fs: Add flag for checking filesystem mount support in kernel Martin Doucha
2026-08-14 13:05   ` linuxtestproject.agent [this message]
2026-08-14 12:49 ` [LTP] [PATCH 2/3] refluxfs: Check kernel reflink support before mount Martin Doucha
2026-08-14 12:49 ` [LTP] [PATCH 3/3] file_attr02: Simplify device mounting Martin Doucha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260814130528.8519-1-linuxtestproject.agent@gmail.com \
    --to=linuxtestproject.agent@gmail.com \
    --cc=ltp@lists.linux.it \
    --cc=mdoucha@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.