From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D25933F5B0 for ; Fri, 14 Aug 2026 13:48:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786715290; cv=none; b=ahn5Gtb6JelbANbsbtxYjlt6UdSRQjfnp6OYnxHoPWGUyPJ6Mnchg0VvLtmOBXSDc3WGX9ZjrRrqMOdogxC2wrmGItkeFPKoKqF822me3fTuvfBtDeTe+PSVK7i5i/7kgHvr2g4QQKua11JrfGJo5luvWamPCcmF6hQ51Ba+/t0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786715290; c=relaxed/simple; bh=96dAcMSbXeKbmqT+LsgdzhEXhEEwqTa3hMSL1SfCrNA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=VcRuilqJaccL50iomHqRLo37ay/tbyN5U+v3b0ZEATYHNmEvh+Viy4gzADsBLj36S77E6UCzhWqEBnvzBvW7wWetEfLQ9xbZjFX4+DDfmso/+ltr3klW4r9AJOpDD00WTcpd5poJmIGPzC1Hy7nDMSQXwm1EKqjPrK41y8T2TK4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=iU+2h/xC; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iU+2h/xC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0A7161F000E9; Fri, 14 Aug 2026 13:48:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786715289; bh=CTfUWRH2IR05AyLOlRfrre4xf/aRkQmOOhmHRekgZBs=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=iU+2h/xCH8WbNfGe+yBX7I9Mm6Zij1tkuQ62R35GkTGFW3jF2WFhVHUeYiyTKnGI0 V7rId7jxfRGWHUpkDRStjW6NLgFh00cXTaEQFMSSVWcZITZhLAHCisWAOWe4wEkAQx yGjaScneKGu1r37IJ939Vnb6bgBmgPPFBdHIFU2oYgIOLmIQDksvkQcSoP6+icemyE YiQmj386BUTwc6u5sbgvj1QeXdOn1yXsUAenU7mMBwW+yUtowkuubMgNCq58V9S6mB O/B3qYPgcoMKfnvIEO95hAg9HzQmeStef7lxr22+KIJdfT7UFGIAZ5Cef/uct0ikeP t6TXXG063a7YA== From: Damien Le Moal To: Jens Axboe , linux-block@vger.kernel.org Cc: Christoph Hellwig Subject: [PATCH v5 10/13] block: fail zone management operations to read-only and offline zones Date: Fri, 14 Aug 2026 22:47:47 +0900 Message-ID: <20260814134750.2100304-11-dlemoal@kernel.org> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20260814134750.2100304-1-dlemoal@kernel.org> References: <20260814134750.2100304-1-dlemoal@kernel.org> Precedence: bulk X-Mailing-List: linux-block@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Any zone management operation targeting a zone that is in the read-only or offline condition will fail. So there is no point in issuing such BIO. Modify the check in submit_bio_noacct() to use the new helper function bdev_zone_mgmt_allowed() to check that a zone is sequential (as was checked before) and also that the zone is not offline nor read-only. Signed-off-by: Damien Le Moal Reviewed-by: Bart Van Assche Reviewed-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- block/blk-core.c | 7 +++++-- block/blk-zoned.c | 25 +++++++++++++++++++++++++ block/blk.h | 6 ++++++ 3 files changed, 36 insertions(+), 2 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index 196bccf27f58..13dc70e8f55d 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -901,8 +901,11 @@ void submit_bio_noacct(struct bio *bio) case REQ_OP_ZONE_CLOSE: case REQ_OP_ZONE_RESET: case REQ_OP_ZONE_FINISH: - /* Zone management operations require sequential zones. */ - if (!bdev_zone_is_seq(bio->bi_bdev, bio->bi_iter.bi_sector)) + /* + * Zone management operations require sequential zones that are + * not offline nor read-only. + */ + if (!bdev_zone_mgmt_allowed(bdev, bio->bi_iter.bi_sector)) goto end_io; break; case REQ_OP_ZONE_RESET_ALL: diff --git a/block/blk-zoned.c b/block/blk-zoned.c index b88860cf5864..a4678a9e180b 100644 --- a/block/blk-zoned.c +++ b/block/blk-zoned.c @@ -323,6 +323,31 @@ bool bdev_zone_is_seq(struct block_device *bdev, sector_t sector) } EXPORT_SYMBOL_GPL(bdev_zone_is_seq); +/** + * bdev_zone_mgmt_allowed - check if management operations are allowed on a zone + * @bdev: block device to check + * @sector: sector number + * + * Check if the zone containing @sector on @bdev can be a target for a zone + * management operation, that is, if the zone is a sequential write required + * zone that is not offline nor read-only. + */ +bool bdev_zone_mgmt_allowed(struct block_device *bdev, sector_t sector) +{ + enum blk_zone_cond cond; + u8 zs; + + if (!bdev_is_zoned(bdev)) + return false; + + zs = disk_zone_get_state(bdev->bd_disk, sector); + if (blk_zstate_is_conv(zs)) + return false; + + cond = blk_zstate_to_zone_cond(zs); + return !disk_zone_cond_is_offline_or_readonly(cond); +} + /* * Zone report arguments for block device drivers report_zones operation. * @cb: report_zones_cb callback for each reported zone. diff --git a/block/blk.h b/block/blk.h index 50abfd932886..2cc03aa54c53 100644 --- a/block/blk.h +++ b/block/blk.h @@ -577,6 +577,7 @@ int blkdev_report_zones_ioctl(struct block_device *bdev, unsigned int cmd, unsigned long arg); int blkdev_zone_mgmt_ioctl(struct block_device *bdev, blk_mode_t mode, unsigned int cmd, unsigned long arg); +bool bdev_zone_mgmt_allowed(struct block_device *bdev, sector_t sector); #else /* CONFIG_BLK_DEV_ZONED */ static inline void disk_init_zone_resources(struct gendisk *disk) { @@ -619,6 +620,11 @@ static inline int blkdev_zone_mgmt_ioctl(struct block_device *bdev, { return -ENOTTY; } +static inline bool bdev_zone_mgmt_allowed(struct block_device *bdev, + sector_t sector) +{ + return false; +} #endif /* CONFIG_BLK_DEV_ZONED */ struct block_device *bdev_alloc(struct gendisk *disk, u8 partno); -- 2.55.0